Filipe Manana eaa7fe2023 btrfs: fix log context list corruption after rename whiteout error
commit 236ebc20d9afc5e9ff52f3cf3f365a91583aac10 upstream.

During a rename whiteout, if btrfs_whiteout_for_rename() returns an error
we can end up returning from btrfs_rename() with the log context object
still in the root's log context list - this happens if 'sync_log' was
set to true before we called btrfs_whiteout_for_rename() and it is
dangerous because we end up with a corrupt linked list (root->log_ctxs)
as the log context object was allocated on the stack.

After btrfs_rename() returns, any task that is running btrfs_sync_log()
concurrently can end up crashing because that linked list is traversed by
btrfs_sync_log() (through btrfs_remove_all_log_ctxs()). That results in
the same issue that commit e6c617102c7e4 ("Btrfs: fix log context list
corruption after rename exchange operation") fixed.

Fixes: d4682ba03ef618 ("Btrfs: sync log after logging new name")
CC: stable@vger.kernel.org # 4.19+
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-03-25 08:25:56 +01:00
..
2019-09-27 15:10:34 -07:00
2019-09-19 09:42:37 -07:00
2019-07-12 17:37:53 -07:00
2020-03-18 07:17:52 +01:00
2019-09-19 09:42:37 -07:00
2019-09-19 09:42:37 -07:00
2019-07-03 17:52:09 -04:00
2019-10-19 06:32:32 -04:00
2019-09-19 09:42:37 -07:00
2020-03-05 16:43:36 +01:00
2019-11-29 10:10:10 +01:00
2019-08-07 21:51:47 -04:00
2019-12-17 19:55:30 +01:00
2019-09-18 16:59:14 -07:00
2019-10-14 15:04:01 -07:00
2019-09-18 16:59:14 -07:00
2019-08-01 20:51:23 +02:00