iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/gpu/drm/i915/gt
History
Chris Wilson 6a736ebf31 drm/i915: Always wrap the ring offset before resetting 
We were passing in an unwrapped offset into intel_ring_reset() on
unpinning. Sooner or later that had to land on ring->size.

<3> [314.872147] intel_ring_reset:1237 GEM_BUG_ON(!intel_ring_offset_valid(ring, tail))
<4> [314.872272] ------------[ cut here ]------------
<2> [314.872276] kernel BUG at drivers/gpu/drm/i915/gt/intel_ringbuffer.c:1237!
<4> [314.872320] invalid opcode: 0000 [#1] PREEMPT SMP PTI
<4> [314.872331] CPU: 1 PID: 3466 Comm: i915_selftest Tainted: G     U            5.3.0-rc4-CI-Patchwork_14061+ #1
<4> [314.872346] Hardware name: Hewlett-Packard HP Compaq 8000 Elite CMT PC/3647h, BIOS 786G7 v01.02 10/22/2009
<4> [314.872477] RIP: 0010:intel_ring_reset+0x51/0x70 [i915]
<4> [314.872487] Code: 9e db 51 e0 48 8b 35 b6 c7 22 00 49 c7 c0 f8 d9 d6 a0 b9 d5 04 00 00 48 c7 c2 70 5b d4 a0 48 c7 c7 6c fc c0 a0 e8 cf be 58 e0 <0f> 0b 89 77 20 89 77 1c 89 77 24 e9 4f ed ff ff 0f 1f 44 00 00 66
<4> [314.872512] RSP: 0018:ffffc9000034fa98 EFLAGS: 00010282
<4> [314.872523] RAX: 0000000000000010 RBX: ffff8881019412c8 RCX: 0000000000000000
<4> [314.872534] RDX: 0000000000000001 RSI: 0000000000000008 RDI: 0000000000000f20
<4> [314.872545] RBP: ffff888104e0f740 R08: 0000000000000000 R09: 0000000000000f20
<4> [314.872557] R10: 0000000000000000 R11: ffff888117094518 R12: ffffffffa0d3d2c0
<4> [314.872569] R13: ffffffffa0e2a250 R14: ffffffffa0e2a1e0 R15: ffffc9000034fe88
<4> [314.872581] FS:  00007fe6d49f6e40(0000) GS:ffff888117a80000(0000) knlGS:0000000000000000
<4> [314.872595] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
<4> [314.872605] CR2: 000055e3283e9cc8 CR3: 0000000108842000 CR4: 00000000000406e0
<4> [314.872616] Call Trace:
<4> [314.872701]  intel_ring_unpin+0x1a/0x220 [i915]
<4> [314.872787]  ring_destroy+0x48/0xc0 [i915]
<4> [314.872870]  intel_engines_cleanup+0x24/0x40 [i915]
<4> [314.872964]  i915_gem_driver_release+0x1b/0xf0 [i915]
<4> [314.872984]  i915_driver_release+0x1c/0x80 [i915]

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190819075835.20065-2-chris@chris-wilson.co.uk
2019-08-19 09:51:02 +01:00
..
selftests
drm/i915: Markup expected timeline locks for i915_active
2019-08-16 18:02:07 +01:00
uc
drm/i915/uc: Never fail on HuC firmware errors
2019-08-18 11:58:41 +01:00
gen6_renderstate.c
drm/i915: Move the renderstate setup under gt/
2019-07-04 11:48:22 +01:00
gen7_renderstate.c
drm/i915: Move the renderstate setup under gt/
2019-07-04 11:48:22 +01:00
gen8_renderstate.c
drm/i915: Move the renderstate setup under gt/
2019-07-04 11:48:22 +01:00
gen9_renderstate.c
drm/i915: Move the renderstate setup under gt/
2019-07-04 11:48:22 +01:00
intel_breadcrumbs.c
drm/i915/gt: Save/restore interrupts around breadcrumb disable
2019-08-13 21:09:50 +01:00
intel_context_types.h
drm/i915/execlists: Lift process_csb() out of the irq-off spinlock
2019-08-16 20:59:02 +01:00
intel_context.c
drm/i915: Markup expected timeline locks for i915_active
2019-08-16 18:02:07 +01:00
intel_context.h
drm/i915/gt: Mark context->active_count as protected by timeline->mutex
2019-08-16 18:02:06 +01:00
intel_engine_cs.c
drm/i915/execlists: Lift process_csb() out of the irq-off spinlock
2019-08-16 20:59:02 +01:00
intel_engine_pm.c
drm/i915/gt: Mark context->active_count as protected by timeline->mutex
2019-08-16 18:02:06 +01:00
intel_engine_pm.h
drm/i915: Defer final intel_wakeref_put to process context
2019-08-08 21:28:51 +01:00
intel_engine_pool_types.h
drm/i915: Replace struct_mutex for batch pool serialisation
2019-08-04 14:31:18 +01:00
intel_engine_pool.c
drm/i915: Replace struct_mutex for batch pool serialisation
2019-08-04 14:31:18 +01:00
intel_engine_pool.h
drm/i915: Markup expected timeline locks for i915_active
2019-08-16 18:02:07 +01:00
intel_engine_types.h
drm/i915: Move engine IDs out of i915_reg.h
2019-08-16 21:52:48 +01:00
intel_engine_user.c
drm/i915: Fix up the inverse mapping for default ctx->engines[]
2019-08-08 15:45:35 +01:00
intel_engine_user.h
drm/i915: Rename engines to match their user interface
2019-08-07 14:30:55 +01:00
intel_engine.h
drm/i915/guc: Use a local cancel_port_requests
2019-08-13 07:54:39 +01:00
intel_gpu_commands.h
drm/i915/icl: Add command cache invalidate
2019-08-15 13:13:23 +01:00
intel_gt_irq.c
drm/i915: Extract general GT interrupt handlers
2019-08-12 15:36:13 +01:00
intel_gt_irq.h
drm/i915: Extract general GT interrupt handlers
2019-08-12 15:36:13 +01:00
intel_gt_pm_irq.c
drm/i915: Extract general GT interrupt handlers
2019-08-12 15:36:13 +01:00
intel_gt_pm_irq.h
drm/i915: Extract GT powermanagement interrupt handling
2019-08-12 15:36:06 +01:00
intel_gt_pm.c
drm/i915: Defer final intel_wakeref_put to process context
2019-08-08 21:28:51 +01:00
intel_gt_pm.h
drm/i915: Defer final intel_wakeref_put to process context
2019-08-08 21:28:51 +01:00
intel_gt_types.h
drm/i915: Move engine IDs out of i915_reg.h
2019-08-16 21:52:48 +01:00
intel_gt.c
drm/i915: Protect request retirement with timeline->mutex
2019-08-15 23:21:13 +01:00
intel_gt.h
drm/i915/gt: Move gt_cleanup_early out of gem_cleanup_early
2019-08-01 17:58:50 +01:00
intel_hangcheck.c
drm/i915/gt: Use intel_gt as the primary object for handling resets
2019-07-12 21:06:56 +01:00
intel_lrc_reg.h
…
intel_lrc.c
drm/i915/selftests: Check the context size
2019-08-17 09:27:58 +01:00
intel_lrc.h
…
intel_mocs.c
drm/i915/gt: Remove stale kerneldoc for internal MOCS functions
2019-08-05 18:27:17 +01:00
intel_mocs.h
drm/i915: Move MOCS setup to intel_mocs.c
2019-07-31 07:40:35 -07:00
intel_renderstate.c
drm/i915: Inline engine->init_context into its caller
2019-07-30 11:50:42 +01:00
intel_renderstate.h
drm/i915: Move the renderstate setup under gt/
2019-07-04 11:48:22 +01:00
intel_reset_types.h
drm/i915/gt: Use intel_gt as the primary object for handling resets
2019-07-12 21:06:56 +01:00
intel_reset.c
drm/i915/gt: Convert timeline tracking to spinlock
2019-08-15 23:21:13 +01:00
intel_reset.h
drm/i915/gt: Use intel_gt as the primary object for handling resets
2019-07-12 21:06:56 +01:00
intel_ringbuffer.c
drm/i915: Always wrap the ring offset before resetting
2019-08-19 09:51:02 +01:00
intel_sseu.c
drm/i915/perf: Refactor oa object to better manage resources
2019-08-07 20:34:39 +01:00
intel_sseu.h
…
intel_timeline_types.h
drm/i915/gt: Guard timeline pinning without relying on struct_mutex
2019-08-15 23:21:13 +01:00
intel_timeline.c
drm/i915: Markup expected timeline locks for i915_active
2019-08-16 18:02:07 +01:00
intel_timeline.h
drm/i915/gt: Track timeline activeness in enter/exit
2019-08-15 23:16:05 +01:00
intel_workarounds_types.h
drm/i915: Add engine name to workaround debug print
2019-07-12 09:55:30 +01:00
intel_workarounds.c
drm/i915/icl: Add Wa_1409178092
2019-07-19 15:35:21 +01:00
intel_workarounds.h
drm/i915: Convert gt workarounds to intel_gt
2019-06-21 13:48:25 +01:00
Makefile
drm/i915: use upstream version of header tests
2019-07-30 12:11:57 +03:00
mock_engine.c
drm/i915: Protect request retirement with timeline->mutex
2019-08-15 23:21:13 +01:00
mock_engine.h
…
selftest_context.c
drm/i915/selftests: Check the context size
2019-08-17 09:27:58 +01:00
selftest_engine_cs.c
drm/i915: Rename engines to match their user interface
2019-08-07 14:30:55 +01:00
selftest_engine_pm.c
drm/i915: Defer final intel_wakeref_put to process context
2019-08-08 21:28:51 +01:00
selftest_engine.c
drm/i915: Defer final intel_wakeref_put to process context
2019-08-08 21:28:51 +01:00
selftest_engine.h
drm/i915: Defer final intel_wakeref_put to process context
2019-08-08 21:28:51 +01:00
selftest_hangcheck.c
drm/i915/selftests: Careful not to flush hang_fini on error setups
2019-07-29 11:00:18 +01:00
selftest_lrc.c
drm/i915/selftests: Prevent the timeslice expiring during suppression tests
2019-08-12 13:18:13 +01:00
selftest_reset.c
drm/i915/gt: Use intel_gt as the primary object for handling resets
2019-07-12 21:06:56 +01:00
selftest_timeline.c
drm/i915: Markup expected timeline locks for i915_active
2019-08-16 18:02:07 +01:00
selftest_workarounds.c
drm/i915: Fix up the inverse mapping for default ctx->engines[]
2019-08-08 15:45:35 +01:00