linux

iv/linux

History

Florian Fainelli 5a8d7f126c of: of_mdio: Correct loop scanning logic

Commit 209c65b61d94 ("drivers/of/of_mdio.c:fix of_mdiobus_register()")
introduced a break of the loop on the premise that a successful
registration should exit the loop. The premise is correct but not to
code, because rc && rc != -ENODEV is just a special error condition,
that means we would exit the loop even with rc == -ENODEV which is
absolutely not correct since this is the error code to indicate to the
MDIO bus layer that scanning should continue.

Fix this by explicitly checking for rc = 0 as the only valid condition
to break out of the loop.

Fixes: 209c65b61d94 ("drivers/of/of_mdio.c:fix of_mdiobus_register()")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

2020-06-19 13:39:00 -07:00

unittest-data

of: unittest: kmemleak in duplicate property update

2020-04-17 08:31:34 -05:00

address.c

of/address: Support multiple 'dma-ranges' entries

2020-02-14 15:27:08 -06:00

base.c

ARM: SoC-related driver updates

2020-02-08 14:04:19 -08:00

device.c

treewide: remove redundant IS_ERR() before error code check