iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs/btrfs
History
Filipe Manana 6d548b9e5d btrfs: fix reclaim_size counter leak after stealing from global reserve 
Commit 7f9fe614407692 ("btrfs: improve global reserve stealing logic"),
added in the 5.8 merge window, introduced another leak for the space_info's
reclaim_size counter. This is very often triggered by the test cases
generic/269 and generic/416 from fstests, producing a stack trace like the
following during unmount:

[37079.155499] ------------[ cut here ]------------
[37079.156844] WARNING: CPU: 2 PID: 2000423 at fs/btrfs/block-group.c:3422 btrfs_free_block_groups+0x2eb/0x300 [btrfs]
[37079.158090] Modules linked in: dm_snapshot btrfs dm_thin_pool (...)
[37079.164440] CPU: 2 PID: 2000423 Comm: umount Tainted: G        W         5.7.0-rc7-btrfs-next-62 #1
[37079.165422] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), (...)
[37079.167384] RIP: 0010:btrfs_free_block_groups+0x2eb/0x300 [btrfs]
[37079.168375] Code: bd 58 ff ff ff 00 4c 8d (...)
[37079.170199] RSP: 0018:ffffaa53875c7de0 EFLAGS: 00010206
[37079.171120] RAX: ffff98099e701cf8 RBX: ffff98099e2d4000 RCX: 0000000000000000
[37079.172057] RDX: 0000000000000001 RSI: ffffffffc0acc5b1 RDI: 00000000ffffffff
[37079.173002] RBP: ffff98099e701cf8 R08: 0000000000000000 R09: 0000000000000000
[37079.173886] R10: 0000000000000000 R11: 0000000000000000 R12: ffff98099e701c00
[37079.174730] R13: ffff98099e2d5100 R14: dead000000000122 R15: dead000000000100
[37079.175578] FS:  00007f4d7d0a5840(0000) GS:ffff9809ec600000(0000) knlGS:0000000000000000
[37079.176434] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[37079.177289] CR2: 0000559224dcc000 CR3: 000000012207a004 CR4: 00000000003606e0
[37079.178152] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[37079.178935] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[37079.179675] Call Trace:
[37079.180419]  close_ctree+0x291/0x2d1 [btrfs]
[37079.181162]  generic_shutdown_super+0x6c/0x100
[37079.181898]  kill_anon_super+0x14/0x30
[37079.182641]  btrfs_kill_super+0x12/0x20 [btrfs]
[37079.183371]  deactivate_locked_super+0x31/0x70
[37079.184012]  cleanup_mnt+0x100/0x160
[37079.184650]  task_work_run+0x68/0xb0
[37079.185284]  exit_to_usermode_loop+0xf9/0x100
[37079.185920]  do_syscall_64+0x20d/0x260
[37079.186556]  entry_SYSCALL_64_after_hwframe+0x49/0xb3
[37079.187197] RIP: 0033:0x7f4d7d2d9357
[37079.187836] Code: eb 0b 00 f7 d8 64 89 01 48 (...)
[37079.189180] RSP: 002b:00007ffee4e0d368 EFLAGS: 00000246 ORIG_RAX: 00000000000000a6
[37079.189845] RAX: 0000000000000000 RBX: 00007f4d7d3fb224 RCX: 00007f4d7d2d9357
[37079.190515] RDX: ffffffffffffff78 RSI: 0000000000000000 RDI: 0000559224dc5c90
[37079.191173] RBP: 0000559224dc1970 R08: 0000000000000000 R09: 00007ffee4e0c0e0
[37079.191815] R10: 0000559224dc7b00 R11: 0000000000000246 R12: 0000000000000000
[37079.192451] R13: 0000559224dc5c90 R14: 0000559224dc1a80 R15: 0000559224dc1ba0
[37079.193096] irq event stamp: 0
[37079.193729] hardirqs last  enabled at (0): [<0000000000000000>] 0x0
[37079.194379] hardirqs last disabled at (0): [<ffffffff97ab8935>] copy_process+0x755/0x1ea0
[37079.195033] softirqs last  enabled at (0): [<ffffffff97ab8935>] copy_process+0x755/0x1ea0
[37079.195700] softirqs last disabled at (0): [<0000000000000000>] 0x0
[37079.196318] ---[ end trace b32710d864dea887 ]---

In the past commit d611add48b717a ("btrfs: fix reclaim counter leak of
space_info objects") fixed similar cases. That commit however has a date
more recent (April 7 2020) then the commit mentioned before (March 13
2020), however it was merged in kernel 5.7 while the older commit, which
introduces a new leak, was merged only in the 5.8 merge window. So the
leak sneaked in unnoticed.

Fix this by making steal_from_global_rsv() remove the ticket using the
helper remove_ticket(), which decrements the reclaim_size counter of the
space_info object.

Fixes: 7f9fe614407692 ("btrfs: improve global reserve stealing logic")
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
2020-07-02 10:18:34 +02:00
..
tests
btrfs: kill the subvol_srcu
2020-03-23 17:02:00 +01:00
acl.c
btrfs: cleanup btrfs_setxattr_trans and drop transaction parameter
2019-04-29 19:02:44 +02:00
async-thread.c
Btrfs: fix crash during unmount due to race with delayed inode workers
2020-03-23 17:01:51 +01:00
async-thread.h
Btrfs: fix crash during unmount due to race with delayed inode workers
2020-03-23 17:01:51 +01:00
backref.c
btrfs: simplify root lookup by id
2020-05-25 11:25:36 +02:00
backref.h
btrfs: rename BTRFS_ROOT_REF_COWS to BTRFS_ROOT_SHAREABLE
2020-05-25 11:25:35 +02:00
block-group.c
btrfs: fix race between block group removal and block group creation
2020-06-16 19:20:58 +02:00
block-group.h
btrfs: move the block group freeze/unfreeze helpers into block-group.c
2020-05-25 11:25:30 +02:00
block-rsv.c
btrfs: rename BTRFS_ROOT_REF_COWS to BTRFS_ROOT_SHAREABLE
2020-05-25 11:25:35 +02:00
block-rsv.h
btrfs: Remove __ prefix from btrfs_block_rsv_release
2020-03-23 17:01:55 +01:00
btrfs_inode.h
Revert "btrfs: remove BTRFS_INODE_READDIO_NEED_LOCK"
2020-06-09 19:21:48 +02:00
check-integrity.c
btrfs: remove buffer_heads form super block mirror integrity checking
2020-03-23 17:01:40 +01:00
check-integrity.h
btrfs: remove btrfsic_submit_bh()
2020-03-23 17:01:39 +01:00
compression.c
btrfs: unexport btrfs_compress_set_level()
2020-05-25 11:25:37 +02:00
compression.h
btrfs: unexport btrfs_compress_set_level()
2020-05-25 11:25:37 +02:00
ctree.c
btrfs: convert comments to fallthrough annotations
2020-07-02 10:18:30 +02:00
ctree.h
btrfs: check if a log root exists before locking the log_mutex on unlink
2020-06-16 19:22:23 +02:00
delalloc-space.c
btrfs: Remove __ prefix from btrfs_block_rsv_release
2020-03-23 17:01:55 +01:00
delalloc-space.h
btrfs: migrate the delalloc space stuff to it's own home
2019-07-04 17:26:17 +02:00
delayed-inode.c
btrfs: use nofs allocations for running delayed items
2020-03-25 16:26:00 +01:00
delayed-inode.h
btrfs: delayed-inode: Replace zero-length array with flexible-array member
2020-03-23 17:01:53 +01:00
delayed-ref.c
btrfs: Remove __ prefix from btrfs_block_rsv_release
2020-03-23 17:01:55 +01:00
delayed-ref.h
btrfs: migrate the delayed refs rsv code
2019-07-04 17:26:17 +02:00
dev-replace.c
btrfs: sysfs, rename device_link add/remove functions
2020-03-23 17:01:35 +01:00
dev-replace.h
btrfs: add __pure attribute to functions
2019-11-18 12:46:52 +01:00
dir-item.c
btrfs: remove unused parameter fs_info from btrfs_extend_item
2019-04-29 19:02:50 +02:00
discard.c
btrfs: add correction to handle -1 edge case in async discard
2020-01-20 16:41:01 +01:00
discard.h
btrfs: discard: Use the correct style for SPDX License Identifier
2020-04-20 17:43:42 +02:00
disk-io.c
btrfs: fix corrupt log due to concurrent fsync of inodes with shared extents
2020-05-25 11:25:37 +02:00
disk-io.h
btrfs: simplify root lookup by id
2020-05-25 11:25:36 +02:00
export.c
btrfs: simplify iget helpers
2020-05-25 11:25:37 +02:00
export.h
btrfs: export helpers for subvolume name/id resolution
2020-03-23 17:01:42 +01:00
extent_io.c
btrfs: fix fatal extent_buffer readahead vs releasepage race
2020-07-02 10:18:33 +02:00
extent_io.h
btrfs: constify extent_buffer in the API functions
2020-05-25 11:25:34 +02:00
extent_map.c
Btrfs: fix race between using extent maps and merging them
2020-02-12 17:16:46 +01:00
extent_map.h
btrfs: remove extent_map::bdev
2019-11-18 23:43:44 +01:00
extent-io-tree.h
btrfs: fix corrupt log due to concurrent fsync of inodes with shared extents
2020-05-25 11:25:37 +02:00
extent-tree.c
btrfs: rename BTRFS_ROOT_REF_COWS to BTRFS_ROOT_SHAREABLE
2020-05-25 11:25:35 +02:00
file-item.c
btrfs: remove useless 'fail_unlock' label from btrfs_csum_file_blocks()
2020-05-25 11:25:37 +02:00
file.c
btrfs: fix RWF_NOWAIT writes blocking on extent locks and waiting for IO
2020-06-16 19:22:45 +02:00
free-space-cache.c
btrfs: turn space cache writeout failure messages into debug messages
2020-05-25 11:25:38 +02:00
free-space-cache.h
btrfs: have multiple discard lists
2020-01-20 16:41:00 +01:00
free-space-tree.c
btrfs: move the root freeing stuff into btrfs_put_root
2020-03-23 17:01:59 +01:00
free-space-tree.h
btrfs: rename btrfs_block_group_cache
2019-11-18 17:51:51 +01:00
inode-item.c
btrfs: Make btrfs_find_name_in_ext_backref return struct btrfs_inode_extref
2019-09-09 14:59:16 +02:00
inode-map.c
btrfs: Remove __ prefix from btrfs_block_rsv_release
2020-03-23 17:01:55 +01:00
inode-map.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
inode.c
btrfs: fix failure of RWF_NOWAIT write into prealloc extent beyond eof
2020-06-16 19:22:31 +02:00
ioctl.c
btrfs: use kfree() in btrfs_ioctl_get_subvol_info()
2020-06-16 19:24:03 +02:00
Kconfig
Revert "btrfs: switch to iomap_dio_rw() for dio"
2020-06-14 01:19:02 +02:00
locking.c
btrfs: add missing annotation for btrfs_tree_lock()
2020-05-25 11:25:16 +02:00
locking.h
btrfs: Implement DREW lock
2020-03-23 17:01:43 +01:00
lzo.c
btrfs: compression: inline free_workspace
2019-11-18 12:46:59 +01:00
Makefile
Btrfs: move all reflink implementation code into its own file
2020-03-23 17:01:54 +01:00
misc.h
btrfs: rename tree_entry to rb_simple_node and export it
2020-05-25 11:25:19 +02:00
ordered-data.c
btrfs: drop argument tree from btrfs_lock_and_flush_ordered_range
2020-03-23 17:01:34 +01:00
ordered-data.h
btrfs: drop argument tree from btrfs_lock_and_flush_ordered_range
2020-03-23 17:01:34 +01:00
orphan.c
btrfs: replace GPL boilerplate by SPDX -- sources
2018-04-12 16:29:51 +02:00
print-tree.c
btrfs: Remove unneeded semicolon
2020-01-20 16:40:55 +01:00
print-tree.h
btrfs: print-tree: debugging output enhancement
2018-04-20 19:18:16 +02:00
props.c
btrfs: simplify iget helpers
2020-05-25 11:25:37 +02:00
props.h
btrfs: delete unused function btrfs_set_prop_trans
2019-04-29 19:02:54 +02:00
qgroup.c
btrfs: qgroup: mark qgroup inconsistent if we're inherting snapshot to a new qgroup
2020-05-25 11:25:29 +02:00
qgroup.h
btrfs: destroy qgroup extent records on transaction abort
2020-02-19 00:35:54 +01:00
raid56.c
btrfs: use struct_size to calculate size of raid hash table
2020-03-23 17:01:44 +01:00
raid56.h
btrfs: constify map parameter for nr_parity_stripes and nr_data_stripes
2019-07-01 13:34:58 +02:00
rcu-string.h
btrfs: rcu-string: Replace zero-length array with flexible-array member
2020-03-23 17:01:53 +01:00
reada.c
btrfs: rename btrfs_block_group_cache
2019-11-18 17:51:51 +01:00
ref-verify.c
btrfs: convert comments to fallthrough annotations
2020-07-02 10:18:30 +02:00
ref-verify.h
btrfs: ref-verify: Use btrfs_ref to refactor btrfs_ref_tree_mod()
2019-04-29 19:02:49 +02:00
reflink.c
btrfs: fix lost i_size update after cloning inline extent
2020-04-08 19:10:34 +02:00
reflink.h
Btrfs: move all reflink implementation code into its own file
2020-03-23 17:01:54 +01:00
relocation.c
btrfs: simplify iget helpers
2020-05-25 11:25:37 +02:00
root-tree.c
btrfs: simplify root lookup by id
2020-05-25 11:25:36 +02:00
scrub.c
btrfs: simplify root lookup by id
2020-05-25 11:25:36 +02:00
send.c
btrfs: simplify iget helpers
2020-05-25 11:25:37 +02:00
send.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
space-info.c
btrfs: fix reclaim_size counter leak after stealing from global reserve
2020-07-02 10:18:34 +02:00
space-info.h
btrfs: improve global reserve stealing logic
2020-05-25 11:25:22 +02:00
struct-funcs.c
btrfs: update documentation of set/get helpers
2020-05-25 11:25:35 +02:00
super.c
btrfs: convert comments to fallthrough annotations
2020-07-02 10:18:30 +02:00
sysfs.c
btrfs: sysfs: Use scnprintf() instead of snprintf()
2020-03-23 18:14:47 +01:00
sysfs.h
btrfs: sysfs, rename device_link add/remove functions
2020-03-23 17:01:35 +01:00
transaction.c
btrfs: simplify root lookup by id
2020-05-25 11:25:36 +02:00
transaction.h
btrfs: improve global reserve stealing logic
2020-05-25 11:25:22 +02:00
tree-checker.c
btrfs: tree-checker: remove duplicate definition of 'inode_item_err'
2020-05-25 11:25:23 +02:00
tree-checker.h
btrfs: get fs_info from eb in btrfs_check_chunk_valid
2019-04-29 19:02:39 +02:00
tree-defrag.c
btrfs: rename BTRFS_ROOT_REF_COWS to BTRFS_ROOT_SHAREABLE
2020-05-25 11:25:35 +02:00
tree-log.c
btrfs: check if a log root exists before locking the log_mutex on unlink
2020-06-16 19:22:23 +02:00
tree-log.h
btrfs: get fs_info from trans in btrfs_set_log_full_commit
2019-04-29 19:02:41 +02:00
ulist.c
btrfs: replace GPL boilerplate by SPDX -- sources
2018-04-12 16:29:51 +02:00
ulist.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
uuid-tree.c
btrfs: simplify root lookup by id
2020-05-25 11:25:36 +02:00
volumes.c
btrfs: drop stale reference to volume_mutex
2020-05-25 11:25:35 +02:00
volumes.h
btrfs: convert comments to fallthrough annotations
2020-07-02 10:18:30 +02:00
xattr.c
Btrfs: fix failure to persist compression property xattr deletion on fsync
2019-06-17 16:37:17 +02:00
xattr.h
btrfs: cleanup btrfs_setxattr_trans and drop transaction parameter
2019-04-29 19:02:44 +02:00
zlib.c
btrfs: use larger zlib buffer for s390 hardware compression
2020-01-31 10:30:40 -08:00
zstd.c
btrfs: compression: inline free_workspace
2019-11-18 12:46:59 +01:00