linux

iv/linux

History

Guenter Roeck 3c0d2a46c0 net: 6pack: Fix tx timeout and slot time

tx timeout and slot time are currently specified in units of HZ.  On
Alpha, HZ is defined as 1024.  When building alpha:allmodconfig, this
results in the following error message.

  drivers/net/hamradio/6pack.c: In function 'sixpack_open':
  drivers/net/hamradio/6pack.c:71:41: error:
  	unsigned conversion from 'int' to 'unsigned char'
  	changes value from '256' to '0'

In the 6PACK protocol, tx timeout is specified in units of 10 ms and
transmitted over the wire:

    https://www.linux-ax25.org/wiki/6PACK

Defining a value dependent on HZ doesn't really make sense, and
presumably comes from the (very historical) situation where HZ was
originally 100.

Note that the SIXP_SLOTTIME use explicitly is about 10ms granularity:

        mod_timer(&sp->tx_t, jiffies + ((when + 1) * HZ) / 100);

and the SIXP_TXDELAY walue is sent as a byte over the wire.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

2021-09-16 12:52:06 -07:00

6pack.c

net: 6pack: Fix tx timeout and slot time

2021-09-16 12:52:06 -07:00

baycom_epp.c

hamradio: use ndo_siocdevprivate

2021-07-27 20:11:44 +01:00

baycom_par.c

hamradio: use ndo_siocdevprivate

2021-07-27 20:11:44 +01:00

baycom_ser_fdx.c

hamradio: use ndo_siocdevprivate