iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs
History
Tudor Ambarus 6d9a705a65 ext4: avoid a potential slab-out-of-bounds in ext4_group_desc_csum 
commit 4f04351888a83e595571de672e0a4a8b74f4fb31 upstream.

When modifying the block device while it is mounted by the filesystem,
syzbot reported the following:

BUG: KASAN: slab-out-of-bounds in crc16+0x206/0x280 lib/crc16.c:58
Read of size 1 at addr ffff888075f5c0a8 by task syz-executor.2/15586

CPU: 1 PID: 15586 Comm: syz-executor.2 Not tainted 6.2.0-rc5-syzkaller-00205-gc96618275234 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/12/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1b1/0x290 lib/dump_stack.c:106
 print_address_description+0x74/0x340 mm/kasan/report.c:306
 print_report+0x107/0x1f0 mm/kasan/report.c:417
 kasan_report+0xcd/0x100 mm/kasan/report.c:517
 crc16+0x206/0x280 lib/crc16.c:58
 ext4_group_desc_csum+0x81b/0xb20 fs/ext4/super.c:3187
 ext4_group_desc_csum_set+0x195/0x230 fs/ext4/super.c:3210
 ext4_mb_clear_bb fs/ext4/mballoc.c:6027 [inline]
 ext4_free_blocks+0x191a/0x2810 fs/ext4/mballoc.c:6173
 ext4_remove_blocks fs/ext4/extents.c:2527 [inline]
 ext4_ext_rm_leaf fs/ext4/extents.c:2710 [inline]
 ext4_ext_remove_space+0x24ef/0x46a0 fs/ext4/extents.c:2958
 ext4_ext_truncate+0x177/0x220 fs/ext4/extents.c:4416
 ext4_truncate+0xa6a/0xea0 fs/ext4/inode.c:4342
 ext4_setattr+0x10c8/0x1930 fs/ext4/inode.c:5622
 notify_change+0xe50/0x1100 fs/attr.c:482
 do_truncate+0x200/0x2f0 fs/open.c:65
 handle_truncate fs/namei.c:3216 [inline]
 do_open fs/namei.c:3561 [inline]
 path_openat+0x272b/0x2dd0 fs/namei.c:3714
 do_filp_open+0x264/0x4f0 fs/namei.c:3741
 do_sys_openat2+0x124/0x4e0 fs/open.c:1310
 do_sys_open fs/open.c:1326 [inline]
 __do_sys_creat fs/open.c:1402 [inline]
 __se_sys_creat fs/open.c:1396 [inline]
 __x64_sys_creat+0x11f/0x160 fs/open.c:1396
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f72f8a8c0c9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f72f97e3168 EFLAGS: 00000246 ORIG_RAX: 0000000000000055
RAX: ffffffffffffffda RBX: 00007f72f8bac050 RCX: 00007f72f8a8c0c9
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000020000280
RBP: 00007f72f8ae7ae9 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffd165348bf R14: 00007f72f97e3300 R15: 0000000000022000

Replace
	le16_to_cpu(sbi->s_es->s_desc_size)
with
	sbi->s_desc_size

It reduces ext4's compiled text size, and makes the code more efficient
(we remove an extra indirect reference and a potential byte
swap on big endian systems), and there is no downside. It also avoids the
potential KASAN / syzkaller failure, as a bonus.

Reported-by: syzbot+fc51227e7100c9294894@syzkaller.appspotmail.com
Reported-by: syzbot+8785e41224a3afd04321@syzkaller.appspotmail.com
Link: https://syzkaller.appspot.com/bug?id=70d28d11ab14bd7938f3e088365252aa923cff42
Link: https://syzkaller.appspot.com/bug?id=b85721b38583ecc6b5e72ff524c67302abbc30f3
Link: https://lore.kernel.org/all/000000000000ece18705f3b20934@google.com/
Fixes: 717d50e4971b ("Ext4: Uninitialized Block Groups")
Cc: stable@vger.kernel.org
Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Link: https://lore.kernel.org/r/20230504121525.3275886-1-tudor.ambarus@linaro.org
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-05-17 11:50:29 +02:00
..
9p
9p: fix a bunch of checkpatch warnings
2022-08-17 14:24:07 +02:00
adfs
…
affs
affs: initialize fsdata in affs_truncate()
2023-02-01 08:27:06 +01:00
afs
afs: Fix updating of i_size with dv jump from server
2023-05-11 23:00:38 +09:00
autofs
autofs: fix wait name hash calculation in autofs_wait()
2021-10-20 21:09:02 -04:00
befs
isystem: ship and use stdarg.h
2021-08-19 09:02:55 +09:00
bfs
…
btrfs
btrfs: fix space cache inconsistency after error loading it from disk
2023-05-17 11:50:22 +02:00
cachefiles
fs: add is_idmapped_mnt() helper
2022-07-02 16:41:14 +02:00
ceph
ceph: update the time stamps and try to drop the suid/sgid
2023-03-10 09:40:08 +01:00
cifs
SMB3: force unmount was failing to close deferred close files
2023-05-17 11:50:23 +02:00
coda
coda: Avoid partial allocation of sig_inputArgs
2023-03-10 09:39:50 +01:00
configfs
configfs: fix possible memory leak in configfs_create_dir()
2022-12-31 13:14:15 +01:00
cramfs
…
crypto
fscrypt: fix keyring memory leak on mount failure
2022-11-10 18:15:37 +01:00
debugfs
debugfs: fix error when writing negative value to atomic_t debugfs file
2022-12-31 13:14:03 +01:00
devpts
fsnotify: fix fsnotify hooks in pseudo filesystems
2022-02-01 17:27:01 +01:00
dlm
fs: dlm: start midcomms before scand
2023-03-17 08:48:50 +01:00
ecryptfs
fs: add is_idmapped_mnt() helper
2022-07-02 16:41:14 +02:00
efivarfs
…
efs
…
erofs
erofs: fix potential overflow calculating xattr_isize
2023-05-11 23:00:20 +09:00
exfat
exfat: fix inode->i_blocks for non-512 byte sector size device
2023-03-10 09:39:58 +01:00
exportfs
exportfs: support idmapped mounts
2022-06-09 10:23:32 +02:00
ext2
ext2: Use kvmalloc() for group descriptor array
2022-10-26 12:35:51 +02:00
ext4
ext4: avoid a potential slab-out-of-bounds in ext4_group_desc_csum
2023-05-17 11:50:29 +02:00
f2fs
f2fs: fix potential corruption when moving a directory
2023-05-17 11:50:25 +02:00
fat
fat: add ratelimit to fat*_ent_bread()
2022-06-09 10:22:42 +02:00
freevxfs
…
fscache
fscache: Remove an unused static variable
2021-10-04 22:13:12 +01:00
fuse
fuse: fix deadlock between atomic O_TRUNC and page invalidation
2023-04-26 13:51:54 +02:00
gfs2
gfs2: Improve gfs2_make_fs_rw error handling
2023-03-10 09:39:53 +01:00
hfs
hfs: fix missing hfs_bnode_get() in __hfs_bnode_create
2023-03-10 09:39:57 +01:00
hfsplus
fs: hfsplus: fix UAF issue in hfsplus_put_super
2023-03-10 09:39:57 +01:00
hostfs
hostfs: support splice_write
2021-08-26 22:28:02 +02:00
hpfs
hpfs: use iomap_fiemap to implement ->fiemap
2021-07-27 11:00:36 +02:00
hugetlbfs
hugetlbfs: fix null-ptr-deref in hugetlbfs_parse_param()
2022-12-31 13:14:44 +01:00
iomap
iomap: iomap_write_failed fix
2022-06-09 10:22:55 +02:00
isofs
isofs: Fix out of bound access for corrupted isofs image
2021-11-12 15:05:50 +01:00
jbd2
jdb2: Don't refuse invalidation of already invalidated buffers
2023-05-11 23:00:29 +09:00
jffs2
jffs2: correct logic when creating a hole in jffs2_write_begin
2023-03-22 13:31:30 +01:00
jfs
fs/jfs: fix shift exponent db_agl2size negative
2023-03-11 13:57:22 +01:00
kernfs
kernfs: fix use-after-free in __kernfs_remove
2022-11-03 23:59:13 +09:00
ksmbd
ksmbd: not allow guest user on multichannel
2023-05-17 11:50:29 +02:00
lockd
lockd: set file_lock start and end when decoding nlm4 testargs
2023-03-30 12:47:56 +02:00
minix
minix: fix bug when opening a file with O_DIRECT
2022-04-13 20:59:10 +02:00
netfs
netfs: fix parameter of cleanup()
2021-12-29 12:28:59 +01:00
nfs
NFSv4.1: Always send a RECLAIM_COMPLETE after establishing lease
2023-05-11 23:00:36 +09:00
nfs_common
nfs: Fix kerneldoc warning shown up by W=1
2021-10-04 22:02:17 +01:00
nfsd
NFSD: callback request does not use correct credential for AUTH_SYS
2023-04-13 16:48:19 +02:00
nilfs2
nilfs2: fix infinite loop in nilfs_mdt_get_block()
2023-05-11 23:00:39 +09:00
nls
…
notify
inotify: Avoid reporting event with invalid wd
2023-05-17 11:50:22 +02:00
ntfs
ntfs: check overflow when iterating ATTR_RECORDs
2022-11-26 09:24:52 +01:00
ntfs3
fs/ntfs3: Refactoring of various minor issues
2023-05-17 11:50:26 +02:00
ocfs2
ocfs2: fix freeing uninitialized resource on ocfs2_dlm_shutdown
2023-04-13 16:48:26 +02:00
omfs
…
openpromfs
…
orangefs
orangefs: Fix kmemleak in orangefs_{kernel,client}_debug_init()
2022-12-31 13:14:44 +01:00
overlayfs
ovl: Use "buf" flexible array for memcpy() destination
2023-02-09 11:26:47 +01:00
proc
mm: hugetlb: proc: check for hugetlb shared PMD in /proc/PID/smaps
2023-02-09 11:26:44 +01:00
pstore
pstore: Revert pmsg_lock back to a normal mutex
2023-05-11 23:00:31 +09:00
qnx4
qnx4: work around gcc false positive warning bug
2021-09-21 08:36:48 -07:00
qnx6
…
quota
ext4: fix bug_on in __es_tree_search caused by bad quota inode
2023-01-12 11:59:01 +01:00
ramfs
…
reiserfs
reiserfs: Add security prefix to xattr name in reiserfs_security_write()
2023-05-11 23:00:17 +09:00
romfs
…
smbfs_common
cifs: Fix crash on unload of cifs_arc4.ko
2021-12-14 10:57:12 +01:00
squashfs
revert "squashfs: harden sanity check in squashfs_read_xattr_id_table"
2023-02-22 12:57:07 +01:00
sysfs
sysfs: Allow deferred execution of iomem_get_mapping()
2021-08-06 13:05:28 +02:00
sysv
fs: sysv: Fix sysv_nblocks() returns wrong value
2022-12-31 13:14:05 +01:00
tracefs
tracefs: Only clobber mode/uid/gid on remount if asked
2022-09-20 12:39:43 +02:00
ubifs
ubifs: Fix memory leak in do_rename
2023-05-17 11:50:14 +02:00
udf
udf: Fix off-by-one error when discarding preallocation
2023-03-17 08:48:50 +01:00
ufs
isystem: ship and use stdarg.h
2021-08-19 09:02:55 +09:00
unicode
…
vboxsf
vboxfs: fix broken legacy mount signature checking
2021-09-27 11:26:21 -07:00
verity
fsverity: don't drop pagecache at end of FS_IOC_ENABLE_VERITY
2023-04-05 11:24:51 +02:00
xfs
xfs: don't consider future format versions valid
2023-05-11 23:00:18 +09:00
zonefs
zonefs: Fix error message in zonefs_file_dio_append()
2023-04-05 11:25:01 +02:00
aio.c
aio: fix mremap after fork null-deref
2023-02-22 12:57:05 +01:00
anon_inodes.c
…
attr.c
attr: use consistent sgid stripping checks
2023-03-17 08:49:01 +01:00
bad_inode.c
vfs: add rcu argument to ->get_acl() callback
2021-08-18 22:08:24 +02:00
binfmt_aout.c
binfmt: a.out: Fix bogus semicolon
2021-09-05 10:15:05 -07:00
binfmt_elf_fdpic.c
binfmt: Fix error return code in load_elf_fdpic_binary()
2023-01-12 11:58:46 +01:00
binfmt_elf.c
fs/binfmt_elf: Fix memory leak in load_elf_binary()
2022-11-03 23:59:12 +09:00
binfmt_flat.c
binfmt_flat: do not stop relocating GOT entries prematurely on riscv
2022-06-09 10:22:26 +02:00
binfmt_misc.c
binfmt_misc: fix shift-out-of-bounds in check_special_flags
2022-12-31 13:14:39 +01:00
binfmt_script.c
…
buffer.c
mm: fs: initialize fsdata passed to write_begin/write_end interface
2022-11-26 09:24:51 +01:00
char_dev.c
chardev: fix error handling in cdev_device_add()
2022-12-31 13:14:30 +01:00
compat_binfmt_elf.c
…
coredump.c
coredump: Use the vma snapshot in fill_files_note
2022-04-08 14:24:18 +02:00
d_path.c
d_path: make 'prepend()' fill up the buffer exactly on overflow
2021-09-02 10:07:29 -07:00
dax.c
fsdax: Fix infinite loop in dax_iomap_rw()
2022-09-28 11:11:56 +02:00
dcache.c
…
direct-io.c
…
drop_caches.c
fs: drop_caches: fix skipping over shadow cache inodes
2021-09-03 09:58:10 -07:00
eventfd.c
eventfd: provide a eventfd_signal_mask() helper
2023-01-24 07:22:43 +01:00
eventpoll.c
eventpoll: add EPOLL_URING_WAKE poll wakeup flag
2023-01-24 07:22:43 +01:00
exec.c
exec: Copy oldsighand->action under spin-lock
2022-11-03 23:59:12 +09:00
fcntl.c
Merge branch 'akpm' (patches from Andrew)
2021-09-03 10:08:28 -07:00
fhandle.c
…
file_table.c
locks: fix TOCTOU race when granting write lease
2022-10-26 12:34:58 +02:00
file.c
fs: prevent out-of-bounds array speculation when closing a file descriptor
2023-03-17 08:48:47 +01:00
filesystems.c
fs: simplify get_filesystem_list / get_all_fs_names
2021-08-23 01:25:40 -04:00
fs_context.c
vfs: fs_context: fix up param length parsing in legacy_parse_param
2022-01-20 09:13:14 +01:00
fs_parser.c
namei: Standardize callers of filename_lookup()
2021-09-07 16:07:47 -04:00
fs_pin.c
…
fs_struct.c
…
fs_types.c
…
fs-writeback.c
writeback: fix call of incorrect macro
2023-05-17 11:50:16 +02:00
fsopen.c
…
init.c
…
inode.c
attr: use consistent sgid stripping checks
2023-03-17 08:49:01 +01:00
internal.h
attr: use consistent sgid stripping checks
2023-03-17 08:49:01 +01:00
ioctl.c
fs: fix an infinite loop in iomap_fiemap
2022-05-25 09:57:26 +02:00
Kconfig
4 cifs/smb3 fixes, one for DFS reconnect, and one to begin creating common headers for server and client and the other two to rename the cifs_common directory to smbfs_common to be more consistent ie change use of the name cifs to smb which is more accurate
2021-09-12 10:10:21 -07:00
Kconfig.binfmt
binfmt: remove support for em86 (alpha only)
2021-07-25 22:33:03 -07:00
kernel_read_file.c
vfs: check fd has read access in kernel_read_file_from_fd()
2021-10-18 20:22:03 -10:00
libfs.c
libfs: add DEFINE_SIMPLE_ATTRIBUTE_SIGNED for signed value
2022-12-31 13:14:03 +01:00
locks.c
filelocks: use mount idmapping for setlease permission check
2023-03-17 08:49:02 +01:00
Makefile
io_uring: move to separate directory
2022-12-14 11:37:31 +01:00
mbcache.c
mbcache: Avoid nesting of cache->c_list_lock under bit locks
2023-01-12 11:59:20 +01:00
mount.h
…
mpage.c
…
namei.c
fs: move S_ISGID stripping into the vfs_*() helpers
2023-03-17 08:49:00 +01:00
namespace.c
fs: drop peer group ids under namespace lock
2023-04-13 16:48:25 +02:00
no-block.c
…
nsfs.c
…
open.c
attr: use consistent sgid stripping checks
2023-03-17 08:49:01 +01:00
pipe.c
pipe: Fix missing lock in pipe_resize_ring()
2022-06-06 08:43:37 +02:00
pnode.c
pnode: terminate at peers of source
2023-01-12 11:58:47 +01:00
pnode.h
…
posix_acl.c
fs: fix acl translation
2022-07-02 16:41:17 +02:00
proc_namespace.c
fs: add is_idmapped_mnt() helper
2022-07-02 16:41:14 +02:00
read_write.c
vfs: fix copy_file_range() averts filesystem freeze protection
2022-12-19 12:36:39 +01:00
readdir.c
…
remap_range.c
fs/remap: constrain dedupe of EOF blocks
2022-07-21 21:24:14 +02:00
select.c
select: Fix indefinitely sleeping task in poll_schedule_timeout()
2022-01-29 10:58:25 +01:00
seq_file.c
rxrpc: Fix locking issue
2022-07-12 16:35:08 +02:00
signalfd.c
signalfd: use wake_up_pollfree()
2021-12-14 10:57:15 +01:00
splice.c
Revert "fs: check FMODE_LSEEK to control internal pipe splicing"
2022-10-26 12:34:17 +02:00
stack.c
…
stat.c
stat: fix inconsistency between struct stat and struct compat_stat
2022-04-27 14:38:57 +02:00
statfs.c
…
super.c
fscrypt: destroy keyring after security_sb_delete()
2023-03-30 12:47:56 +02:00
sync.c
vfs: make sync_filesystem return errors from ->sync_fs
2022-04-27 14:38:50 +02:00
timerfd.c
timerfd: Provide timerfd_resume()
2021-08-10 17:57:22 +02:00
userfaultfd.c
userfaultfd: open userfaultfds with O_RDONLY
2022-10-26 12:34:36 +02:00
utimes.c
…
xattr.c
fs: don't audit the capability check in simple_xattr_list()
2022-12-31 13:14:01 +01:00