Anton Protopopov b34ffb0c6d bpf: fix a memory leak in the LRU and LRU_PERCPU hash maps
The LRU and LRU_PERCPU maps allocate a new element on update before locking the
target hash table bucket. Right after that the maps try to lock the bucket.
If this fails, then maps return -EBUSY to the caller without releasing the
allocated element. This makes the element untracked: it doesn't belong to
either of free lists, and it doesn't belong to the hash table, so can't be
re-used; this eventually leads to the permanent -ENOMEM on LRU map updates,
which is unexpected. Fix this by returning the element to the local free list
if bucket locking fails.

Fixes: 20b6cc34ea74 ("bpf: Avoid hashtab deadlock with map_locked")
Signed-off-by: Anton Protopopov <aspsk@isovalent.com>
Link: https://lore.kernel.org/r/20230522154558.2166815-1-aspsk@isovalent.com
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
2023-05-22 10:26:39 -07:00
..
2023-04-29 10:05:22 -07:00
2023-04-27 12:07:50 -07:00
2022-12-02 11:25:00 +01:00
2023-04-29 10:29:57 -07:00
2023-04-28 14:41:53 -07:00
2022-12-21 14:31:52 -08:00
2023-04-28 14:53:30 -07:00
2023-05-05 12:56:55 -07:00
2023-04-24 12:16:14 -07:00
2023-05-05 13:11:02 -07:00
2022-08-29 19:47:03 -04:00
2022-09-26 10:13:13 -07:00
2023-04-28 15:57:53 -07:00
2023-04-30 13:00:38 -07:00
2023-03-24 11:01:29 +01:00
2023-04-27 16:36:55 -07:00
2023-04-20 22:55:35 -04:00
2023-04-03 11:16:56 +02:00
2023-04-27 16:36:55 -07:00
2022-08-06 16:38:17 -07:00
2023-04-29 09:48:52 -07:00