linux

iv/linux

History

Jacob Keller 6e2feaa344 i40e: fix warning about shadowed ring parameter

In commit 147e81ec7568 ("i40e: Test memory before ethtool alloc succeeds")
code was added to handle ring allocation on systems with low memory.

It shadowed the ring parameter pointer by introducing a local ring
pointer inside the for loop. Most of the code in the loop already just
accessed the ring via &rx_rings[i]. Since most of the code already does
this, just remove the local variable.

If someone considers it worth keeping a local around, they should use it
for the whole section instead of just a couple of accesses.

This fixes a warning when -Wshadow is enabled

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

2018-08-07 12:20:15 -07:00

e1000

treewide: kmalloc() -> kmalloc_array()

2018-06-12 16:19:22 -07:00

e1000e

treewide: kzalloc() -> kcalloc()

2018-06-12 16:19:22 -07:00

fm10k

treewide: Use array_size() in vmalloc()

2018-06-12 16:19:22 -07:00

i40e

i40e: fix warning about shadowed ring parameter