Eric W. Biederman 6eb0777228 netns: Fix icmp shutdown.
Recently I had a kernel panic in icmp_send during a network namespace
cleanup.  There were packets in the arp queue that failed to be sent
and we attempted to generate an ICMP host unreachable message, but
failed because icmp_sk_exit had already been called.

The network devices are removed from a network namespace and their
arp queues are flushed before we do attempt to shutdown subsystems
so this error should have been impossible.

It turns out icmp_init is using register_pernet_device instead
of register_pernet_subsys.  Which resulted in icmp being shut down
while we still had the possibility of packets in flight, making
a nasty NULL pointer deference in interrupt context possible.

Changing this to register_pernet_subsys fixes the problem in
my testing.

Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
Acked-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
2009-03-03 01:14:15 -08:00
..
2008-11-25 17:59:27 -08:00
2009-02-23 10:05:54 +11:00
2008-07-16 20:20:11 -07:00
2008-11-03 02:48:48 -08:00
2008-11-25 17:59:27 -08:00
2009-03-03 01:14:15 -08:00
2008-11-03 18:21:05 -08:00
2008-11-25 17:30:50 -08:00
2008-12-16 01:15:11 -08:00
2008-10-07 08:38:24 +11:00
2008-10-07 08:38:24 +11:00
2008-12-29 23:04:08 -08:00
2008-06-11 21:00:38 -07:00
2008-11-03 18:21:05 -08:00
2008-11-02 00:28:10 -07:00
2008-11-12 01:41:09 -08:00
2009-03-01 00:21:36 -08:00
2008-12-09 00:13:04 -08:00