Chris Wilson 6f13f29f2c drm/i915: Flush the change in debugobject before reallocation ...

When marking the debugobject as freed, be sure that write is flushed
before another CPU may see it on a reallocation path.

Only seen once in CI:

[  159.240873] WARNING: CPU: 3 PID: 6735 at lib/debugobjects.c:263 debug_print_object+0x87/0xb0
[  159.240897] ODEBUG: init destroyed (active state 0) object type: i915_sw_fence hint: submit_notify+0x0/0x4c [i915]
[  159.240902] Modules linked in: snd_hda_intel i915 x86_pkg_temp_thermal intel_powerclamp coretemp crct10dif_pclmul snd_hda_codec_realtek crc32_pclmul snd_hda_codec_generic snd_hda_codec_hdmi ghash_clmulni_intel snd_hda_codec snd_hwdep snd_hda_core snd_pcm mei_me lpc_ich mei e1000e ptp pps_core [last unloaded: i915]
[  159.240913] CPU: 3 PID: 6735 Comm: gem_exec_nop Tainted: G     U          4.10.0-rc3-CI-Trybot_479+ #1
[  159.240913] Hardware name: LENOVO 10AGS00601/SHARKBAY, BIOS FBKT34AUS 04/24/2013
[  159.240914] Call Trace:
[  159.240916]  dump_stack+0x67/0x92
[  159.240919]  __warn+0xc6/0xe0
[  159.240920]  warn_slowpath_fmt+0x4a/0x50
[  159.240921]  debug_print_object+0x87/0xb0
[  159.240935]  ? __i915_request_wait_for_execute+0x1d0/0x1d0 [i915]
[  159.240936]  __debug_object_init+0xb2/0x410
[  159.240950]  ? __i915_request_wait_for_execute+0x1d0/0x1d0 [i915]
[  159.240951]  debug_object_init+0x16/0x20
[  159.240962]  __i915_sw_fence_init+0x29/0x60 [i915]
[  159.240975]  i915_gem_request_alloc+0x1fb/0x450 [i915]
[  159.240987]  i915_gem_do_execbuffer.isra.15+0x798/0x1b20 [i915]
[  159.241000]  i915_gem_execbuffer2+0xc0/0x250 [i915]
[  159.241003]  drm_ioctl+0x200/0x450
[  159.241016]  ? i915_gem_execbuffer+0x330/0x330 [i915]
[  159.241018]  do_vfs_ioctl+0x90/0x6e0
[  159.241020]  ? trace_hardirqs_on_caller+0x122/0x1b0
[  159.241021]  SyS_ioctl+0x3c/0x70
[  159.241023]  entry_SYSCALL_64_fastpath+0x1c/0xb1
[  159.241024] RIP: 0033:0x7f9bc4f41357
[  159.241025] RSP: 002b:00007ffc6cd5c568 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
[  159.241026] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f9bc4f41357
[  159.241026] RDX: 00007ffc6cd5c640 RSI: 0000000040406469 RDI: 0000000000000003
[  159.241027] RBP: 00007ffc6cd5c640 R08: 0000000000047508 R09: 0000000000000001
[  159.241027] R10: 000b58552d323c3d R11: 0000000000000246 R12: 0000000040406469
[  159.241028] R13: 0000000000000003 R14: 0000000000000004 R15: 0000000000000001

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: http://patchwork.freedesktop.org/patch/msgid/20170113214335.5829-1-chris@chris-wilson.co.uk
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

2017-01-16 12:21:19 +00:00

..

amd

Merge tag 'drm-misc-next-2017-01-09' of git://anongit.freedesktop.org/git/drm-misc into drm-next

2017-01-10 08:06:56 +10:00

arc

drm: bridge: Link encoder and bridge in core code

2016-12-18 16:31:45 +05:30

arm

drm: Nuke fb->pixel_format

2016-12-15 14:55:34 +02:00

armada

Merge tag 'drm-misc-next-2017-01-09' of git://anongit.freedesktop.org/git/drm-misc into drm-next

2017-01-10 08:06:56 +10:00

ast

Merge tag 'drm-misc-next-2017-01-09' of git://anongit.freedesktop.org/git/drm-misc into drm-next

2017-01-10 08:06:56 +10:00

atmel-hlcdc

drm: bridge: Link encoder and bridge in core code

2016-12-18 16:31:45 +05:30

bochs

drm: fix compilations issues introduced by "drm: allow to use mmuless SoC"

2017-01-09 11:30:30 +01:00

bridge

drm: bridge: Link encoder and bridge in core code

2016-12-18 16:31:45 +05:30

cirrus

drm: fix compilations issues introduced by "drm: allow to use mmuless SoC"

2017-01-09 11:30:30 +01:00

etnaviv

Merge tag 'drm-misc-next-2017-01-09' of git://anongit.freedesktop.org/git/drm-misc into drm-next

2017-01-10 08:06:56 +10:00

exynos

Merge tag 'drm-misc-next-2017-01-09' of git://anongit.freedesktop.org/git/drm-misc into drm-next

2017-01-10 08:06:56 +10:00

fsl-dcu

drm: Change the return type of the unload hook to void

2017-01-09 11:25:22 +01:00

gma500

Merge tag 'drm-misc-next-2017-01-09' of git://anongit.freedesktop.org/git/drm-misc into drm-next

2017-01-10 08:06:56 +10:00

hisilicon

drm: fix compilations issues introduced by "drm: allow to use mmuless SoC"

2017-01-09 11:30:30 +01:00

i2c

drm/i2c: tda998x: fix spelling mistake

2016-11-18 00:00:40 +00:00

i810

drm: define drm_compat_ioctl NULL on CONFIG_COMPAT=n and reduce #ifdefs

2016-11-02 11:33:47 -04:00

i915

drm/i915: Flush the change in debugobject before reallocation

2017-01-16 12:21:19 +00:00

imx

drm/imx: imx-tve: Remove unused variable

2017-01-05 09:44:20 +01:00

lib

drm: Add a simple generator of random permutations

2016-12-27 12:34:00 +01:00

mediatek

drm: bridge: Link encoder and bridge in core code

2016-12-18 16:31:45 +05:30

meson

drm: Nuke fb->pixel_format

2016-12-15 14:55:34 +02:00

mga

drm: Change the return type of the unload hook to void

2017-01-09 11:25:22 +01:00

mgag200

drm: fix compilations issues introduced by "drm: allow to use mmuless SoC"

2017-01-09 11:30:30 +01:00

msm

Merge tag 'drm-misc-next-2017-01-09' of git://anongit.freedesktop.org/git/drm-misc into drm-next

2017-01-10 08:06:56 +10:00

mxsfb

drm: Nuke fb->pixel_format

2016-12-15 14:55:34 +02:00

nouveau

Merge tag 'drm-misc-next-2017-01-09' of git://anongit.freedesktop.org/git/drm-misc into drm-next

2017-01-10 08:06:56 +10:00

omapdrm

Merge tag 'drm-misc-next-2017-01-09' of git://anongit.freedesktop.org/git/drm-misc into drm-next

2017-01-10 08:06:56 +10:00

panel

drm/panel: simple: Add support for AUO G185HAN01

2016-12-06 17:06:32 +01:00

qxl

drm: fix compilations issues introduced by "drm: allow to use mmuless SoC"

2017-01-09 11:30:30 +01:00

r128

…

radeon

Merge tag 'drm-misc-next-2017-01-09' of git://anongit.freedesktop.org/git/drm-misc into drm-next

2017-01-10 08:06:56 +10:00

rcar-du

drm: bridge: Link encoder and bridge in core code

2016-12-18 16:31:45 +05:30

rockchip

drm: rockchip: use crtc helper drm_crtc_from_index()

2016-12-30 12:15:11 +01:00

savage

drm: Change the return type of the unload hook to void

2017-01-09 11:25:22 +01:00

selftests

drm/mm: Convert to drm_printer

2016-12-30 12:08:28 +01:00

shmobile

drm: Change the return type of the unload hook to void

2017-01-09 11:25:22 +01:00

sis

drm: Change the return type of the unload hook to void

2017-01-09 11:25:22 +01:00

sti

drm: bridge: Link encoder and bridge in core code

2016-12-18 16:31:45 +05:30

sun4i

drm: bridge: Link encoder and bridge in core code

2016-12-18 16:31:45 +05:30

tdfx

drm: define drm_compat_ioctl NULL on CONFIG_COMPAT=n and reduce #ifdefs

2016-11-02 11:33:47 -04:00

tegra

Merge tag 'drm-misc-next-2017-01-09' of git://anongit.freedesktop.org/git/drm-misc into drm-next

2017-01-10 08:06:56 +10:00

tilcdc

Merge tag 'drm-misc-next-2017-01-09' of git://anongit.freedesktop.org/git/drm-misc into drm-next

2017-01-10 08:06:56 +10:00

ttm

Merge tag 'drm-misc-next-2017-01-09' of git://anongit.freedesktop.org/git/drm-misc into drm-next

2017-01-10 08:06:56 +10:00

udl

Merge tag 'drm-misc-next-2017-01-09' of git://anongit.freedesktop.org/git/drm-misc into drm-next

2017-01-10 08:06:56 +10:00

vc4

drm: Don't include <drm/drm_encoder.h> in <drm/drm_crtc.h>

2016-12-18 16:29:29 +05:30

vgem

mm: use vmf->address instead of of vmf->virtual_address

2016-12-14 16:04:09 -08:00

via

drm: Change the return type of the unload hook to void

2017-01-09 11:25:22 +01:00

virtio

Merge tag 'drm-misc-next-2017-01-09' of git://anongit.freedesktop.org/git/drm-misc into drm-next

2017-01-10 08:06:56 +10:00

vmwgfx

drm: fix compilations issues introduced by "drm: allow to use mmuless SoC"

2017-01-09 11:30:30 +01:00

zte

drm: zte: use crtc helper drm_crtc_from_index()

2016-12-30 12:15:01 +01:00

ati_pcigart.c

…

drm_agpsupport.c

…

drm_atomic_helper.c

drm: reference count event->completion

2017-01-04 11:03:06 +01:00

drm_atomic.c

drm: Add kernel-doc for drm_crtc_commit_get/put

2017-01-05 08:55:02 +01:00

drm_auth.c

drm/doc: use preferred struct reference in kernel-doc

2016-12-30 13:34:59 +01:00

drm_blend.c

…

drm_bridge.c

drm/bridge: Use recommened kerneldoc for struct member refs

2017-01-02 09:17:26 +01:00

drm_bufs.c

…

drm_cache.c

…

drm_color_mgmt.c

drm/doc: use preferred struct reference in kernel-doc

2016-12-30 13:34:59 +01:00

drm_connector.c

drm/doc: use preferred struct reference in kernel-doc

2016-12-30 13:34:59 +01:00

drm_context.c

…

drm_crtc_helper_internal.h

…

drm_crtc_helper.c

drm/doc: use preferred struct reference in kernel-doc

2016-12-30 13:34:59 +01:00

drm_crtc_internal.h

drm: Move atomic debugfs functions into drm_crtc_internal.h

2016-12-18 14:18:12 +01:00

drm_crtc.c

drm: add more document for drm_crtc_from_index()

2017-01-09 11:24:16 +01:00

drm_debugfs_crc.c

drm: crc: Call wake_up_interruptible() each time there is a new CRC entry

2017-01-06 15:23:19 +01:00

drm_debugfs.c

drm: Move atomic debugfs functions into drm_crtc_internal.h

2016-12-18 14:18:12 +01:00

drm_dma.c

…

drm_dp_aux_dev.c

…

drm_dp_dual_mode_helper.c

drm: Print some debug/error info during DP dual mode detect

2016-10-26 15:57:11 -04:00

drm_dp_helper.c

…

drm_dp_mst_topology.c

drm/dp/mst: Check peer device type before attempting EDID read

2016-10-26 18:53:44 +02:00

drm_drv.c

drm: Avoid NULL dereference of drm_device.dev

2016-12-30 15:29:44 +01:00

drm_dumb_buffers.c

drm/doc: use preferred struct reference in kernel-doc

2016-12-30 13:34:59 +01:00

drm_edid_load.c

…

drm_edid.c

drm/edid: constify edid quirk list

2017-01-02 15:06:39 +02:00

drm_encoder_slave.c

…

drm_encoder.c

drm/doc: use preferred struct reference in kernel-doc

2016-12-30 13:34:59 +01:00

drm_fb_cma_helper.c

drm/cma-helpers: Use recommened kerneldoc for struct member refs

2016-12-30 17:58:15 +01:00

drm_fb_helper.c

drm: remove useless parameters from drm_pick_cmdline_mode function

2017-01-09 11:18:41 +01:00

drm_flip_work.c

…

drm_fops.c

drm: reference count event->completion

2017-01-04 11:03:06 +01:00

drm_fourcc.c

drm: move allocation out of drm_get_format_name()

2016-11-12 14:19:38 +01:00

drm_framebuffer.c

drm/doc: use preferred struct reference in kernel-doc

2016-12-30 13:34:59 +01:00

drm_gem_cma_helper.c

drm: allow to use mmuless SoC

2017-01-06 11:04:54 +01:00

drm_gem.c

…

drm_global.c

drm: Update TTM initialization documentation

2016-12-30 12:52:10 +01:00

drm_hashtab.c

…

drm_info.c

…

drm_internal.h

drm/irq: drm_legacy_ prefix for legacy ioctls

2016-12-18 14:18:12 +01:00

drm_ioc32.c

…

drm_ioctl.c

drm: Export drm_ioctl_permit to kernel-doc

2016-12-30 12:40:48 +01:00

drm_irq.c

drm/doc: use preferred struct reference in kernel-doc

2016-12-30 13:34:59 +01:00

drm_kms_helper_common.c

…

drm_legacy.h

drm: compile drm_vm.c only when needed

2017-01-06 11:03:07 +01:00

drm_lock.c

drm: Avoid NULL dereference for DRM_LEGACY debug message

2016-11-28 08:39:41 +01:00

drm_memory.c

…

drm_mipi_dsi.c

…

drm_mm.c

drm/mm: Some doc polish

2016-12-30 12:53:51 +01:00

drm_mode_config.c

drm: Clean up connectors by unreferencing them

2016-12-18 14:33:51 +01:00

drm_mode_object.c

drm: Get atomic property value even if DRIVER_ATOMIC is not set

2016-12-27 10:44:33 +01:00

drm_modes.c

Revert "drm: Add aspect ratio parsing in DRM layer"

2016-11-15 15:01:42 +01:00

drm_modeset_helper.c

drm: Convert all helpers to drm_connector_list_iter

2016-12-18 14:33:22 +01:00

drm_modeset_lock.c

drm/doc: Fix indenting in drm_modeset_lock.c comment

2016-11-29 23:34:36 +01:00

drm_of.c

drm: Don't include <drm/drm_encoder.h> in <drm/drm_crtc.h>

2016-12-18 16:29:29 +05:30

drm_panel.c

…

drm_pci.c

drm: Deduplicate driver initialization message

2016-12-30 12:37:39 +01:00

drm_plane_helper.c

drm/doc: use preferred struct reference in kernel-doc

2016-12-30 13:34:59 +01:00

drm_plane.c

drm: add more document for drm_crtc_from_index()

2017-01-09 11:24:16 +01:00

drm_platform.c

drm: Deduplicate driver initialization message

2016-12-30 12:37:39 +01:00

drm_prime.c

drm: Take ownership of the dmabuf->obj when exporting

2016-12-08 10:29:22 +01:00

drm_print.c

drm/printer: add debug printer

2016-12-30 11:43:40 +01:00

drm_probe_helper.c

drm/doc: use preferred struct reference in kernel-doc

2016-12-30 13:34:59 +01:00

drm_property.c

drm/doc: use preferred struct reference in kernel-doc

2016-12-30 13:34:59 +01:00

drm_rect.c

drm/rect: Fix formatting of example code

2016-12-30 13:35:54 +01:00

drm_scatter.c

…

drm_simple_kms_helper.c

drm/doc: use preferred struct reference in kernel-doc

2016-12-30 13:34:59 +01:00

drm_sysfs.c

…

drm_trace_points.c

…

drm_trace.h

…

drm_vm.c

mm: use vmf->address instead of of vmf->virtual_address

2016-12-14 16:04:09 -08:00

drm_vma_manager.c

…

Kconfig

drm: fix compilations issues introduced by "drm: allow to use mmuless SoC"

2017-01-09 11:30:30 +01:00

Makefile

drm: compile drm_vm.c only when needed

2017-01-06 11:03:07 +01:00