Xiaoguang Wang 6f2cc1664d io_uring: fix possible race condition against REQ_F_NEED_CLEANUP
In io_read() or io_write(), when io request is submitted successfully,
it'll go through the below sequence:

    kfree(iovec);
    req->flags &= ~REQ_F_NEED_CLEANUP;
    return ret;

But clearing REQ_F_NEED_CLEANUP might be unsafe. The io request may
already have been completed, and then io_complete_rw_iopoll()
and io_complete_rw() will be called, both of which will also modify
req->flags if needed. This causes a race condition, with concurrent
non-atomic modification of req->flags.

To eliminate this race, in io_read() or io_write(), if io request is
submitted successfully, we don't remove REQ_F_NEED_CLEANUP flag. If
REQ_F_NEED_CLEANUP is set, we'll leave __io_req_aux_free() to the
iovec cleanup work correspondingly.

Cc: stable@vger.kernel.org
Signed-off-by: Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2020-06-18 08:32:44 -06:00
..
2020-03-27 09:29:56 +00:00
2020-06-14 09:47:25 -07:00
2020-06-01 12:10:17 -07:00
2020-06-05 16:43:16 -07:00
2020-06-02 20:16:55 -07:00
2020-06-09 11:24:59 -07:00
2020-06-09 10:04:47 -07:00
2020-06-09 11:28:59 -07:00
2020-06-09 15:48:24 -07:00
2020-06-08 12:47:09 -07:00
2020-06-02 15:29:19 -07:00
2020-06-13 12:44:30 -07:00
2020-06-02 15:29:19 -07:00
2020-06-02 20:11:35 -07:00
2020-06-11 12:22:41 -07:00
2020-06-11 10:33:13 -07:00
2020-06-09 15:40:50 -07:00
2020-06-13 13:29:16 -07:00
\n
2020-06-04 13:53:10 -07:00
2020-06-05 14:05:57 -07:00
2020-06-02 15:29:19 -07:00
2020-06-13 12:40:24 -07:00
2020-06-04 13:50:13 -07:00
2020-06-02 15:37:03 -07:00
2020-06-14 09:47:25 -07:00
2020-05-14 16:44:25 +02:00
2020-06-05 16:26:36 -07:00
2020-06-15 08:51:38 -06:00
2020-06-11 10:33:13 -07:00
2020-05-14 16:44:24 +02:00
2020-06-02 19:45:12 -07:00
2020-06-09 15:40:50 -07:00
2020-05-14 16:44:24 +02:00
2020-04-09 15:33:09 -04:00