Herbert Xu 6f4b6ec1cf [IPV6]: Fix illegal dst locking in softirq context.
On Tue, Jan 31, 2006 at 10:24:32PM +0100, Ingo Molnar wrote:
>
>  [<c04de9e8>] _write_lock+0x8/0x10
>  [<c0499015>] inet6_destroy_sock+0x25/0x100
>  [<c04b8672>] tcp_v6_destroy_sock+0x12/0x20
>  [<c046bbda>] inet_csk_destroy_sock+0x4a/0x150
>  [<c047625c>] tcp_rcv_state_process+0xd4c/0xdd0
>  [<c047d8e9>] tcp_v4_do_rcv+0xa9/0x340
>  [<c047eabb>] tcp_v4_rcv+0x8eb/0x9d0

OK this is definitely broken.  We should never touch the dst lock in
softirq context.  Since inet6_destroy_sock may be called from that
context due to the asynchronous nature of sockets, we can't take the
lock there.

In fact this sk_dst_reset is totally redundant since all IPv6 sockets
use inet_sock_destruct as their socket destructor which always cleans
up the dst anyway.  So the solution is to simply remove the call.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
2006-02-02 17:01:13 -08:00
..
2006-01-11 18:42:14 -08:00
2006-01-11 18:42:14 -08:00
2006-01-11 18:42:14 -08:00
2006-01-31 17:44:07 -08:00
2006-01-11 18:42:14 -08:00
2006-01-11 18:42:14 -08:00
2006-01-24 12:57:19 -08:00
2005-08-29 15:31:14 -07:00
2006-01-11 18:42:14 -08:00
2006-01-17 13:03:54 -08:00
2006-01-11 18:42:14 -08:00
2005-09-08 08:14:11 -07:00
2006-01-12 14:06:31 -08:00
2006-01-03 13:11:17 -08:00
2005-04-16 15:20:36 -07:00