linux

iv/linux

History

Jeff Layton 6fc1fe5e4c Revert "ceph: SetPageError() for writeback pages if writepages fails"

This reverts commit b109eec6f4332bd517e2f41e207037c4b9065094.

If I'm filling up a filesystem with this sort of command:

    $ dd if=/dev/urandom of=/mnt/cephfs/fillfile bs=2M oflag=sync

...then I'll eventually get back EIO on a write. Further calls
will give us ENOSPC.

I'm not sure what prompted this change, but I don't think it's what we
want to do. If writepages failed, we will have already set the mapping
error appropriately, and that's what gets reported by fsync() or
close().

__filemap_fdatawait_range however, does this:

	wait_on_page_writeback(page);
	if (TestClearPageError(page))
		ret = -EIO;

...and that -EIO ends up trumping the mapping's error if one exists.

When writepages fails, we only want to set the error in the mapping,
and not flag the individual pages.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: "Yan, Zheng” <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

2017-05-04 09:19:22 +02:00

acl.c

ceph: Propagate dentry down to inode_change_ok()

2016-09-22 10:56:19 +02:00

addr.c

Revert "ceph: SetPageError() for writeback pages if writepages fails"

2017-05-04 09:19:22 +02:00

cache.c

ceph: fix spelling mistake: "enabing" -> "enabling"

2017-02-20 12:16:05 +01:00

cache.h

ceph: improve fscache revalidation