iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
70a2f9120f
linux/drivers/media/rc
History
James Hogan 70a2f9120f [media] media: rc: only turn on LED if keypress generated 
Since v3.12, specifically 153a60bb0f ([media] rc: add feedback led
trigger for rc keypresses), an LED trigger is activated on IR keydown
whether or not a keypress is generated (i.e. even if there's no matching
keycode). However the repeat and keyup logic isn't used unless there is
a keypress, which results in non-keypress keydown events turning on the
LED and not turning it off again.

On the assumption that the intent was for the LED only to light up on
valid key presses (you probably don't want it lighting up for the wrong
remote control for example), move the led_trigger_event() call inside
the keycode check.

Signed-off-by: James Hogan <james.hogan@imgtec.com>
Acked-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
2014-02-04 13:09:00 -02:00
..
keymaps [media] dw2102: Use RC Core instead of the legacy RC (second edition) 2013-12-10 15:22:30 -02:00
ati_remote.c [media] rc: Make probe cleanup goto labels more verbose 2012-12-21 18:26:08 -02:00
ene_ir.c [media] ene_ir: disable the device if wake is disabled 2013-07-29 11:48:26 -03:00
ene_ir.h [media] ene_ir: don't use pr_debug after all 2013-07-29 11:49:45 -03:00
fintek-cir.c Merge branch 'v4l_for_linus' into staging/for_v3.9 2013-01-24 18:49:18 -02:00
fintek-cir.h [media] rc: Fir warnings on m68k arch 2013-11-08 09:45:37 -02:00
gpio-ir-recv.c [media] gpio-ir-recv: Include linux/of.h header 2013-10-31 08:19:02 -02:00
iguanair.c Merge branch 'topic/kbuild-fixes-for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media 2013-11-18 15:10:05 -08:00
imon.c [media] media: Remove OOM message after input_allocate_device 2014-01-07 08:01:42 -02:00
ir-jvc-decoder.c [media] rc-core: don't treat dev->rc_map.rc_type as a bitmap 2013-03-23 11:25:54 -03:00
ir-lirc-codec.c [media] media: lirc: Allow lirc dev to talk to rc device 2013-07-31 16:30:27 -03:00
ir-mce_kbd-decoder.c [media] rc-core: don't treat dev->rc_map.rc_type as a bitmap 2013-03-23 11:25:54 -03:00
ir-nec-decoder.c [media] rc-core: don't treat dev->rc_map.rc_type as a bitmap 2013-03-23 11:25:54 -03:00
ir-raw.c [media] rc-core: don't treat dev->rc_map.rc_type as a bitmap 2013-03-23 11:25:54 -03:00
ir-rc5-decoder.c [media] rc-core: don't treat dev->rc_map.rc_type as a bitmap 2013-03-23 11:25:54 -03:00
ir-rc5-sz-decoder.c [media] rc-core: don't treat dev->rc_map.rc_type as a bitmap 2013-03-23 11:25:54 -03:00
ir-rc6-decoder.c [media] rc-core: don't treat dev->rc_map.rc_type as a bitmap 2013-03-23 11:25:54 -03:00
ir-rx51.c [media] ir-rx51: remove deprecated IRQF_DISABLED 2013-10-17 06:09:02 -03:00
ir-sanyo-decoder.c [media] rc-core: don't treat dev->rc_map.rc_type as a bitmap 2013-03-23 11:25:54 -03:00
ir-sony-decoder.c [media] rc-core: don't treat dev->rc_map.rc_type as a bitmap 2013-03-23 11:25:54 -03:00
ite-cir.c [media] rc: ite-cir: fix potential double free in ite_probe() 2013-04-14 21:37:53 -03:00
ite-cir.h
Kconfig [media] media: st-rc: Add ST remote control driver 2013-10-31 08:20:08 -02:00
lirc_dev.c [media] media: lirc: Allow lirc dev to talk to rc device 2013-07-31 16:30:27 -03:00
Makefile [media] media: st-rc: Add ST remote control driver 2013-10-31 08:20:08 -02:00
mceusb.c [media] mceusb: Add Hauppauge WinTV-HVR-930C HD 2013-12-10 15:33:52 -02:00
nuvoton-cir.c [media] rc: nuvoton-cir: fix potential double free in nvt_probe() 2013-04-14 21:38:05 -03:00
nuvoton-cir.h [media] rc: Fir warnings on m68k arch 2013-11-08 09:45:37 -02:00
rc-core-priv.h [media] rc-core: don't treat dev->rc_map.rc_type as a bitmap 2013-03-23 11:25:54 -03:00
rc-loopback.c [media] rc-core: add separate defines for protocol bitmaps and numbers 2012-10-27 11:49:51 -02:00
rc-main.c [media] media: rc: only turn on LED if keypress generated 2014-02-04 13:09:00 -02:00
redrat3.c [media] media_tree: Fix spelling errors 2013-11-29 14:43:50 -02:00
st_rc.c [media] media: st-rc: Add reset support 2014-01-15 11:45:22 -02:00
streamzap.c Drivers: media: remove __dev* attributes. 2013-01-03 15:57:02 -08:00
ttusbir.c [media] ttusbir: wire up rc feedback led 2013-08-22 11:48:32 -03:00
winbond-cir.c [media] winbond-cir: remove deprecated IRQF_DISABLED 2013-10-17 06:09:14 -03:00