1bc479d665
ASan complains a memory leakage in hisi_ptt_process_auxtrace_event()
that the data buffer is not freed. Since currently we only support the
raw dump trace mode, the data buffer is used only within this function.
So fix this by freeing the data buffer before going out.
Fixes: 5e91e57e68
("perf auxtrace arm64: Add support for parsing HiSilicon PCIe Trace packet")
Reviewed-by: Ian Rogers <irogers@google.com>
Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Acked-by: Namhyung Kim <Namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
Cc: Junhao He <hejunhao3@huawei.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Qi Liu <liuqi115@huawei.com>
Link: https://lore.kernel.org/r/20231207081635.8427-3-yangyicong@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
196 lines
4.5 KiB
C
196 lines
4.5 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* HiSilicon PCIe Trace and Tuning (PTT) support
|
|
* Copyright (c) 2022 HiSilicon Technologies Co., Ltd.
|
|
*/
|
|
|
|
#include <byteswap.h>
|
|
#include <endian.h>
|
|
#include <errno.h>
|
|
#include <inttypes.h>
|
|
#include <linux/bitops.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/log2.h>
|
|
#include <linux/types.h>
|
|
#include <linux/zalloc.h>
|
|
#include <stdlib.h>
|
|
#include <unistd.h>
|
|
|
|
#include "auxtrace.h"
|
|
#include "color.h"
|
|
#include "debug.h"
|
|
#include "evsel.h"
|
|
#include "hisi-ptt.h"
|
|
#include "hisi-ptt-decoder/hisi-ptt-pkt-decoder.h"
|
|
#include "machine.h"
|
|
#include "session.h"
|
|
#include "tool.h"
|
|
#include <internal/lib.h>
|
|
|
|
struct hisi_ptt {
|
|
struct auxtrace auxtrace;
|
|
u32 auxtrace_type;
|
|
struct perf_session *session;
|
|
struct machine *machine;
|
|
u32 pmu_type;
|
|
};
|
|
|
|
struct hisi_ptt_queue {
|
|
struct hisi_ptt *ptt;
|
|
struct auxtrace_buffer *buffer;
|
|
};
|
|
|
|
static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type(unsigned char *buf)
|
|
{
|
|
uint32_t head = *(uint32_t *)buf;
|
|
|
|
if ((HISI_PTT_8DW_CHECK_MASK & head) == HISI_PTT_IS_8DW_PKT)
|
|
return HISI_PTT_8DW_PKT;
|
|
|
|
return HISI_PTT_4DW_PKT;
|
|
}
|
|
|
|
static void hisi_ptt_dump(struct hisi_ptt *ptt __maybe_unused,
|
|
unsigned char *buf, size_t len)
|
|
{
|
|
const char *color = PERF_COLOR_BLUE;
|
|
enum hisi_ptt_pkt_type type;
|
|
size_t pos = 0;
|
|
int pkt_len;
|
|
|
|
type = hisi_ptt_check_packet_type(buf);
|
|
len = round_down(len, hisi_ptt_pkt_size[type]);
|
|
color_fprintf(stdout, color, ". ... HISI PTT data: size %zu bytes\n",
|
|
len);
|
|
|
|
while (len > 0) {
|
|
pkt_len = hisi_ptt_pkt_desc(buf, pos, type);
|
|
if (!pkt_len)
|
|
color_fprintf(stdout, color, " Bad packet!\n");
|
|
|
|
pos += pkt_len;
|
|
len -= pkt_len;
|
|
}
|
|
}
|
|
|
|
static void hisi_ptt_dump_event(struct hisi_ptt *ptt, unsigned char *buf,
|
|
size_t len)
|
|
{
|
|
printf(".\n");
|
|
|
|
hisi_ptt_dump(ptt, buf, len);
|
|
}
|
|
|
|
static int hisi_ptt_process_event(struct perf_session *session __maybe_unused,
|
|
union perf_event *event __maybe_unused,
|
|
struct perf_sample *sample __maybe_unused,
|
|
struct perf_tool *tool __maybe_unused)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static int hisi_ptt_process_auxtrace_event(struct perf_session *session,
|
|
union perf_event *event,
|
|
struct perf_tool *tool __maybe_unused)
|
|
{
|
|
struct hisi_ptt *ptt = container_of(session->auxtrace, struct hisi_ptt,
|
|
auxtrace);
|
|
int fd = perf_data__fd(session->data);
|
|
int size = event->auxtrace.size;
|
|
void *data = malloc(size);
|
|
off_t data_offset;
|
|
int err;
|
|
|
|
if (!data)
|
|
return -errno;
|
|
|
|
if (perf_data__is_pipe(session->data)) {
|
|
data_offset = 0;
|
|
} else {
|
|
data_offset = lseek(fd, 0, SEEK_CUR);
|
|
if (data_offset == -1) {
|
|
free(data);
|
|
return -errno;
|
|
}
|
|
}
|
|
|
|
err = readn(fd, data, size);
|
|
if (err != (ssize_t)size) {
|
|
free(data);
|
|
return -errno;
|
|
}
|
|
|
|
if (dump_trace)
|
|
hisi_ptt_dump_event(ptt, data, size);
|
|
|
|
free(data);
|
|
return 0;
|
|
}
|
|
|
|
static int hisi_ptt_flush(struct perf_session *session __maybe_unused,
|
|
struct perf_tool *tool __maybe_unused)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static void hisi_ptt_free_events(struct perf_session *session __maybe_unused)
|
|
{
|
|
}
|
|
|
|
static void hisi_ptt_free(struct perf_session *session)
|
|
{
|
|
struct hisi_ptt *ptt = container_of(session->auxtrace, struct hisi_ptt,
|
|
auxtrace);
|
|
|
|
session->auxtrace = NULL;
|
|
free(ptt);
|
|
}
|
|
|
|
static bool hisi_ptt_evsel_is_auxtrace(struct perf_session *session,
|
|
struct evsel *evsel)
|
|
{
|
|
struct hisi_ptt *ptt = container_of(session->auxtrace, struct hisi_ptt, auxtrace);
|
|
|
|
return evsel->core.attr.type == ptt->pmu_type;
|
|
}
|
|
|
|
static void hisi_ptt_print_info(__u64 type)
|
|
{
|
|
if (!dump_trace)
|
|
return;
|
|
|
|
fprintf(stdout, " PMU Type %" PRId64 "\n", (s64) type);
|
|
}
|
|
|
|
int hisi_ptt_process_auxtrace_info(union perf_event *event,
|
|
struct perf_session *session)
|
|
{
|
|
struct perf_record_auxtrace_info *auxtrace_info = &event->auxtrace_info;
|
|
struct hisi_ptt *ptt;
|
|
|
|
if (auxtrace_info->header.size < HISI_PTT_AUXTRACE_PRIV_SIZE +
|
|
sizeof(struct perf_record_auxtrace_info))
|
|
return -EINVAL;
|
|
|
|
ptt = zalloc(sizeof(*ptt));
|
|
if (!ptt)
|
|
return -ENOMEM;
|
|
|
|
ptt->session = session;
|
|
ptt->machine = &session->machines.host; /* No kvm support */
|
|
ptt->auxtrace_type = auxtrace_info->type;
|
|
ptt->pmu_type = auxtrace_info->priv[0];
|
|
|
|
ptt->auxtrace.process_event = hisi_ptt_process_event;
|
|
ptt->auxtrace.process_auxtrace_event = hisi_ptt_process_auxtrace_event;
|
|
ptt->auxtrace.flush_events = hisi_ptt_flush;
|
|
ptt->auxtrace.free_events = hisi_ptt_free_events;
|
|
ptt->auxtrace.free = hisi_ptt_free;
|
|
ptt->auxtrace.evsel_is_auxtrace = hisi_ptt_evsel_is_auxtrace;
|
|
session->auxtrace = &ptt->auxtrace;
|
|
|
|
hisi_ptt_print_info(auxtrace_info->priv[0]);
|
|
|
|
return 0;
|
|
}
|