Xiyu Yang 7217e6e694 scsi: lpfc: Fix lpfc_nodelist leak when processing unsolicited event
In order to create or activate a new node, lpfc_els_unsol_buffer() invokes
lpfc_nlp_init() or lpfc_enable_node() or lpfc_nlp_get(), all of them will
return a reference of the specified lpfc_nodelist object to "ndlp" with
increased refcnt.

When lpfc_els_unsol_buffer() returns, local variable "ndlp" becomes
invalid, so the refcount should be decreased to keep refcount balanced.

The reference counting issue happens in one exception handling path of
lpfc_els_unsol_buffer(). When "ndlp" in DEV_LOSS, the function forgets to
decrease the refcnt increased by lpfc_nlp_init() or lpfc_enable_node() or
lpfc_nlp_get(), causing a refcnt leak.

Fix this issue by calling lpfc_nlp_put() when "ndlp" in DEV_LOSS.

Link: https://lore.kernel.org/r/1590416184-52592-1-git-send-email-xiyuyang19@fudan.edu.cn
Reviewed-by: Daniel Wagner <dwagner@suse.de>
Reviewed-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2020-05-26 15:55:14 -04:00
..
2020-04-02 17:03:53 -07:00
2020-01-29 18:16:16 -08:00
2019-11-07 06:43:18 -07:00
2020-03-11 23:07:59 -04:00
2020-04-10 12:21:11 -07:00
2019-03-02 11:39:54 -08:00
2019-11-12 22:21:35 -05:00
2020-02-24 14:54:25 -05:00
2020-03-11 23:07:59 -04:00
2020-04-14 21:32:39 -04:00
2019-01-08 21:58:35 -05:00
2020-02-28 20:54:52 -05:00
2019-07-11 15:14:01 -07:00
2019-06-18 19:46:18 -04:00
2019-07-11 15:17:41 -07:00
2020-04-02 17:03:53 -07:00
2018-11-06 21:31:28 -05:00
2020-04-02 17:03:53 -07:00
2019-07-11 15:14:01 -07:00
2020-03-24 07:57:07 -06:00
2019-07-11 15:17:41 -07:00
2019-07-11 15:14:01 -07:00
2019-12-08 12:23:42 -08:00
2019-07-11 15:14:01 -07:00
2020-02-24 15:01:57 -05:00
2020-02-10 22:46:55 -05:00
2019-07-11 15:14:01 -07:00