20498d52c9
Commit e4c23e19aa2a ("clk: mediatek: Register clock gate with device") introduces a helper function for the sole purpose of propagating a struct device pointer to the clk API when registering the mtk-gate clocks to take advantage of Runtime PM when/where needed and where a power domain is defined in devicetree. Function mtk_clk_register_gates() then becomes a wrapper around the new mtk_clk_register_gates_with_dev() function that will simply pass NULL as struct device: this is essential when registering drivers with CLK_OF_DECLARE instead of as a platform device, as there will be no struct device to pass... but we can as well simply have only one function that always takes such pointer as a param and pass NULL when unavoidable. This commit removes the mtk_clk_register_gates() wrapper and renames mtk_clk_register_gates_with_dev() to the former and all of the calls to either of the two functions were fixed in all drivers in order to reflect this change; also, to improve consistency with other kernel functions, the pointer to struct device was moved as the first param. Since a lot of MediaTek clock drivers are actually registering as a platform device, but were still registering the mtk-gate clocks without passing any struct device to the clock framework, they've been changed to pass a valid one now, as to make all those platforms able to use runtime power management where available. While at it, some much needed indentation changes were also done. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org> Reviewed-by: Markus Schneider-Pargmann <msp@baylibre.com> Tested-by: Miles Chen <miles.chen@mediatek.com> Link: https://lore.kernel.org/r/20230120092053.182923-4-angelogioacchino.delregno@collabora.com Tested-by: Mingming Su <mingming.su@mediatek.com> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
169 lines
4.0 KiB
C
169 lines
4.0 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (C) 2018 MediaTek Inc.
|
|
* Author: Wenzhen Yu <Wenzhen Yu@mediatek.com>
|
|
* Ryder Lee <ryder.lee@mediatek.com>
|
|
*/
|
|
|
|
#include <linux/clk-provider.h>
|
|
#include <linux/of.h>
|
|
#include <linux/of_address.h>
|
|
#include <linux/of_device.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
#include "clk-mtk.h"
|
|
#include "clk-gate.h"
|
|
|
|
#include <dt-bindings/clock/mt7629-clk.h>
|
|
|
|
#define GATE_ETH(_id, _name, _parent, _shift) { \
|
|
.id = _id, \
|
|
.name = _name, \
|
|
.parent_name = _parent, \
|
|
.regs = ð_cg_regs, \
|
|
.shift = _shift, \
|
|
.ops = &mtk_clk_gate_ops_no_setclr_inv, \
|
|
}
|
|
|
|
static const struct mtk_gate_regs eth_cg_regs = {
|
|
.set_ofs = 0x30,
|
|
.clr_ofs = 0x30,
|
|
.sta_ofs = 0x30,
|
|
};
|
|
|
|
static const struct mtk_gate eth_clks[] = {
|
|
GATE_ETH(CLK_ETH_FE_EN, "eth_fe_en", "eth2pll", 6),
|
|
GATE_ETH(CLK_ETH_GP2_EN, "eth_gp2_en", "txclk_src_pre", 7),
|
|
GATE_ETH(CLK_ETH_GP1_EN, "eth_gp1_en", "txclk_src_pre", 8),
|
|
GATE_ETH(CLK_ETH_GP0_EN, "eth_gp0_en", "txclk_src_pre", 9),
|
|
GATE_ETH(CLK_ETH_ESW_EN, "eth_esw_en", "eth_500m", 16),
|
|
};
|
|
|
|
static const struct mtk_gate_regs sgmii_cg_regs = {
|
|
.set_ofs = 0xE4,
|
|
.clr_ofs = 0xE4,
|
|
.sta_ofs = 0xE4,
|
|
};
|
|
|
|
#define GATE_SGMII(_id, _name, _parent, _shift) { \
|
|
.id = _id, \
|
|
.name = _name, \
|
|
.parent_name = _parent, \
|
|
.regs = &sgmii_cg_regs, \
|
|
.shift = _shift, \
|
|
.ops = &mtk_clk_gate_ops_no_setclr_inv, \
|
|
}
|
|
|
|
static const struct mtk_gate sgmii_clks[2][4] = {
|
|
{
|
|
GATE_SGMII(CLK_SGMII_TX_EN, "sgmii_tx_en",
|
|
"ssusb_tx250m", 2),
|
|
GATE_SGMII(CLK_SGMII_RX_EN, "sgmii_rx_en",
|
|
"ssusb_eq_rx250m", 3),
|
|
GATE_SGMII(CLK_SGMII_CDR_REF, "sgmii_cdr_ref",
|
|
"ssusb_cdr_ref", 4),
|
|
GATE_SGMII(CLK_SGMII_CDR_FB, "sgmii_cdr_fb",
|
|
"ssusb_cdr_fb", 5),
|
|
}, {
|
|
GATE_SGMII(CLK_SGMII_TX_EN, "sgmii_tx_en1",
|
|
"ssusb_tx250m", 2),
|
|
GATE_SGMII(CLK_SGMII_RX_EN, "sgmii_rx_en1",
|
|
"ssusb_eq_rx250m", 3),
|
|
GATE_SGMII(CLK_SGMII_CDR_REF, "sgmii_cdr_ref1",
|
|
"ssusb_cdr_ref", 4),
|
|
GATE_SGMII(CLK_SGMII_CDR_FB, "sgmii_cdr_fb1",
|
|
"ssusb_cdr_fb", 5),
|
|
}
|
|
};
|
|
|
|
static u16 rst_ofs[] = { 0x34, };
|
|
|
|
static const struct mtk_clk_rst_desc clk_rst_desc = {
|
|
.version = MTK_RST_SIMPLE,
|
|
.rst_bank_ofs = rst_ofs,
|
|
.rst_bank_nr = ARRAY_SIZE(rst_ofs),
|
|
};
|
|
|
|
static int clk_mt7629_ethsys_init(struct platform_device *pdev)
|
|
{
|
|
struct clk_hw_onecell_data *clk_data;
|
|
struct device_node *node = pdev->dev.of_node;
|
|
int r;
|
|
|
|
clk_data = mtk_alloc_clk_data(CLK_ETH_NR_CLK);
|
|
|
|
mtk_clk_register_gates(&pdev->dev, node, eth_clks,
|
|
CLK_ETH_NR_CLK, clk_data);
|
|
|
|
r = of_clk_add_hw_provider(node, of_clk_hw_onecell_get, clk_data);
|
|
if (r)
|
|
dev_err(&pdev->dev,
|
|
"could not register clock provider: %s: %d\n",
|
|
pdev->name, r);
|
|
|
|
mtk_register_reset_controller_with_dev(&pdev->dev, &clk_rst_desc);
|
|
|
|
return r;
|
|
}
|
|
|
|
static int clk_mt7629_sgmiisys_init(struct platform_device *pdev)
|
|
{
|
|
struct clk_hw_onecell_data *clk_data;
|
|
struct device_node *node = pdev->dev.of_node;
|
|
static int id;
|
|
int r;
|
|
|
|
clk_data = mtk_alloc_clk_data(CLK_SGMII_NR_CLK);
|
|
|
|
mtk_clk_register_gates(&pdev->dev, node, sgmii_clks[id++],
|
|
CLK_SGMII_NR_CLK, clk_data);
|
|
|
|
r = of_clk_add_hw_provider(node, of_clk_hw_onecell_get, clk_data);
|
|
if (r)
|
|
dev_err(&pdev->dev,
|
|
"could not register clock provider: %s: %d\n",
|
|
pdev->name, r);
|
|
|
|
return r;
|
|
}
|
|
|
|
static const struct of_device_id of_match_clk_mt7629_eth[] = {
|
|
{
|
|
.compatible = "mediatek,mt7629-ethsys",
|
|
.data = clk_mt7629_ethsys_init,
|
|
}, {
|
|
.compatible = "mediatek,mt7629-sgmiisys",
|
|
.data = clk_mt7629_sgmiisys_init,
|
|
}, {
|
|
/* sentinel */
|
|
}
|
|
};
|
|
|
|
static int clk_mt7629_eth_probe(struct platform_device *pdev)
|
|
{
|
|
int (*clk_init)(struct platform_device *);
|
|
int r;
|
|
|
|
clk_init = of_device_get_match_data(&pdev->dev);
|
|
if (!clk_init)
|
|
return -EINVAL;
|
|
|
|
r = clk_init(pdev);
|
|
if (r)
|
|
dev_err(&pdev->dev,
|
|
"could not register clock provider: %s: %d\n",
|
|
pdev->name, r);
|
|
|
|
return r;
|
|
}
|
|
|
|
static struct platform_driver clk_mt7629_eth_drv = {
|
|
.probe = clk_mt7629_eth_probe,
|
|
.driver = {
|
|
.name = "clk-mt7629-eth",
|
|
.of_match_table = of_match_clk_mt7629_eth,
|
|
},
|
|
};
|
|
|
|
builtin_platform_driver(clk_mt7629_eth_drv);
|