Suniel Mahesh
d477bf3af1
cpufreq: dt: Fix sysfs duplicate filename creation for platform-device
...
ti-cpufreq and cpufreq-dt-platdev drivers are registering platform-device
with same name "cpufreq-dt" using platform_device_register_*() routines.
This is leading to build warnings appended below.
Providing hardware information to OPP framework along with the platform-
device creation should be done by ti-cpufreq driver before cpufreq-dt
driver comes into place.
This patch add's TI am33xx, am43 and dra7 platforms (which use opp-v2
property) to the blacklist of devices in cpufreq-dt-platform driver to
avoid creating platform-device twice and remove build warnings.
[ 2.370167] ------------[ cut here ]------------
[ 2.375087] WARNING: CPU: 0 PID: 1 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x58/0x78
[ 2.383112] sysfs: cannot create duplicate filename '/devices/platform/cpufreq-dt'
[ 2.391219] Modules linked in:
[ 2.394506] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.13.0-next-20170912 #1
[ 2.402006] Hardware name: Generic AM33XX (Flattened Device Tree)
[ 2.408437] [<c0110a28>] (unwind_backtrace) from [<c010ca84>] (show_stack+0x10/0x14)
[ 2.416568] [<c010ca84>] (show_stack) from [<c0827d64>] (dump_stack+0xac/0xe0)
[ 2.424165] [<c0827d64>] (dump_stack) from [<c0137470>] (__warn+0xd8/0x104)
[ 2.431488] [<c0137470>] (__warn) from [<c01374d0>] (warn_slowpath_fmt+0x34/0x44)
[ 2.439351] [<c01374d0>] (warn_slowpath_fmt) from [<c03459d0>] (sysfs_warn_dup+0x58/0x78)
[ 2.447938] [<c03459d0>] (sysfs_warn_dup) from [<c0345ab8>] (sysfs_create_dir_ns+0x80/0x98)
[ 2.456719] [<c0345ab8>] (sysfs_create_dir_ns) from [<c082c554>] (kobject_add_internal+0x9c/0x2d4)
[ 2.466124] [<c082c554>] (kobject_add_internal) from [<c082c7d8>] (kobject_add+0x4c/0x9c)
[ 2.474712] [<c082c7d8>] (kobject_add) from [<c05803e4>] (device_add+0xcc/0x57c)
[ 2.482489] [<c05803e4>] (device_add) from [<c0584b74>] (platform_device_add+0x100/0x220)
[ 2.491085] [<c0584b74>] (platform_device_add) from [<c05855a8>] (platform_device_register_full+0xf4/0x118)
[ 2.501305] [<c05855a8>] (platform_device_register_full) from [<c067023c>] (ti_cpufreq_init+0x150/0x22c)
[ 2.511253] [<c067023c>] (ti_cpufreq_init) from [<c0101df4>] (do_one_initcall+0x3c/0x170)
[ 2.519838] [<c0101df4>] (do_one_initcall) from [<c0c00eb4>] (kernel_init_freeable+0x1fc/0x2c4)
[ 2.528974] [<c0c00eb4>] (kernel_init_freeable) from [<c083bcac>] (kernel_init+0x8/0x110)
[ 2.537565] [<c083bcac>] (kernel_init) from [<c0107d18>] (ret_from_fork+0x14/0x3c)
[ 2.545981] ---[ end trace 2fc00e213c13ab20 ]---
[ 2.551051] ------------[ cut here ]------------
[ 2.555931] WARNING: CPU: 0 PID: 1 at lib/kobject.c:240 kobject_add_internal+0x254/0x2d4
[ 2.564578] kobject_add_internal failed for cpufreq-dt with -EEXIST, don't try to register
things with the same name in the same directory.
[ 2.577977] Modules linked in:
[ 2.581261] CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W 4.13.0-next-20170912 #1
[ 2.590013] Hardware name: Generic AM33XX (Flattened Device Tree)
[ 2.596437] [<c0110a28>] (unwind_backtrace) from [<c010ca84>] (show_stack+0x10/0x14)
[ 2.604573] [<c010ca84>] (show_stack) from [<c0827d64>] (dump_stack+0xac/0xe0)
[ 2.612172] [<c0827d64>] (dump_stack) from [<c0137470>] (__warn+0xd8/0x104)
[ 2.619494] [<c0137470>] (__warn) from [<c01374d0>] (warn_slowpath_fmt+0x34/0x44)
[ 2.627362] [<c01374d0>] (warn_slowpath_fmt) from [<c082c70c>] (kobject_add_internal+0x254/0x2d4)
[ 2.636666] [<c082c70c>] (kobject_add_internal) from [<c082c7d8>] (kobject_add+0x4c/0x9c)
[ 2.645255] [<c082c7d8>] (kobject_add) from [<c05803e4>] (device_add+0xcc/0x57c)
[ 2.653027] [<c05803e4>] (device_add) from [<c0584b74>] (platform_device_add+0x100/0x220)
[ 2.661615] [<c0584b74>] (platform_device_add) from [<c05855a8>] (platform_device_register_full+0xf4/0x118)
[ 2.671833] [<c05855a8>] (platform_device_register_full) from [<c067023c>] (ti_cpufreq_init+0x150/0x22c)
[ 2.681779] [<c067023c>] (ti_cpufreq_init) from [<c0101df4>] (do_one_initcall+0x3c/0x170)
[ 2.690377] [<c0101df4>] (do_one_initcall) from [<c0c00eb4>] (kernel_init_freeable+0x1fc/0x2c4)
[ 2.699510] [<c0c00eb4>] (kernel_init_freeable) from [<c083bcac>] (kernel_init+0x8/0x110)
[ 2.708106] [<c083bcac>] (kernel_init) from [<c0107d18>] (ret_from_fork+0x14/0x3c)
[ 2.716217] ---[ end trace 2fc00e213c13ab21 ]---
Fixes: edeec420de24 (cpufreq: dt-cpufreq: platdev Automatically create device with OPP v2)
Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2017-09-26 01:10:08 +02:00
..
2016-12-21 02:52:52 +01:00
2016-07-07 00:14:27 +02:00
2016-05-05 01:40:04 +02:00
2017-07-26 00:15:44 +02:00
2016-05-05 01:40:04 +02:00
2014-04-07 14:31:33 +02:00
2015-12-28 01:51:36 +01:00
2017-02-09 01:22:44 +01:00
2017-02-09 01:22:46 +01:00
2017-08-18 01:41:37 +02:00
2017-07-22 02:25:20 +02:00
2016-04-02 01:09:01 +02:00
2017-09-04 00:05:22 +02:00
2017-07-26 00:15:45 +02:00
2017-07-22 02:25:20 +02:00
2016-06-09 00:58:06 +02:00
2016-06-02 23:24:15 +02:00
2016-06-02 23:24:15 +02:00
2017-07-14 13:12:32 -07:00
2016-06-02 23:24:15 +02:00
2017-09-26 01:10:08 +02:00
2017-08-01 14:24:54 +02:00
2016-09-13 02:39:12 +02:00
2017-07-26 00:15:46 +02:00
2017-09-04 00:05:22 +02:00
2014-04-07 14:43:50 +02:00
2014-04-07 14:43:50 +02:00
2017-01-02 15:02:51 +05:30
2016-04-27 22:42:34 +02:00
2017-07-26 00:15:46 +02:00
2017-06-24 01:38:00 +02:00
2016-07-07 00:13:20 +02:00
2017-07-26 00:15:46 +02:00
2014-10-21 11:21:19 -07:00
2017-04-15 12:20:55 +02:00
2017-08-29 00:22:52 +02:00
2017-09-05 12:45:03 -07:00
2017-02-09 14:33:01 +01:00
2017-08-22 15:50:02 +02:00
2015-03-18 22:35:16 +01:00
2016-11-30 08:27:08 +01:00
2017-05-30 00:09:41 +02:00
2016-05-16 19:17:22 -07:00
2017-07-26 00:15:43 +02:00
2016-05-13 14:02:08 +02:00
2017-08-18 01:44:21 +02:00
2017-08-22 15:50:02 +02:00
2016-04-09 01:35:18 +02:00
2017-08-10 01:29:53 +02:00
2016-06-13 23:49:43 +02:00
2017-01-30 09:22:21 +01:00
2016-04-09 01:35:18 +02:00
2017-05-23 10:01:36 +02:00
2016-07-22 23:51:06 +02:00
2017-07-26 00:15:46 +02:00
2017-08-25 01:20:46 +02:00
2016-04-09 01:35:18 +02:00
2017-09-14 11:59:30 +02:00
2017-05-08 17:15:14 -07:00
2014-05-17 01:27:01 +02:00
2017-02-03 23:59:41 +01:00
2017-02-04 00:05:30 +01:00
2014-04-30 00:06:21 +02:00
2016-04-27 22:42:34 +02:00
2016-04-09 01:35:18 +02:00
2014-03-12 01:06:00 +01:00
2017-05-27 17:32:24 -07:00
2016-04-09 01:35:18 +02:00
2016-06-09 00:58:06 +02:00
2016-12-21 02:54:18 +01:00
2014-07-19 04:24:59 +09:00
2016-04-09 01:35:18 +02:00
2017-02-09 01:22:45 +01:00
2016-04-09 01:35:18 +02:00
2017-07-26 22:54:01 +02:00
2017-07-26 00:15:46 +02:00
2017-07-26 00:15:46 +02:00
2016-04-09 01:35:18 +02:00
2017-06-05 11:14:35 +01:00
2017-06-24 01:43:21 +02:00
2017-07-26 00:15:46 +02:00
2017-04-15 12:20:56 +02:00
2017-04-15 12:20:55 +02:00
2014-10-20 16:20:24 +02:00
2016-04-09 01:35:18 +02:00
2017-07-16 02:12:35 +02:00
2017-08-29 00:21:41 +02:00
2017-07-26 00:15:46 +02:00
2017-08-25 01:20:46 +02:00
2017-07-22 02:20:59 +02:00
2015-09-26 03:00:57 +02:00
2016-04-09 01:12:09 +02:00
2017-04-19 23:23:08 +02:00
2017-09-20 00:51:01 +02:00
2017-07-26 00:15:46 +02:00
2016-05-05 01:40:04 +02:00