iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/ipv4
History
Ido Schimmel 73cb11933c ipmr: Copy option to correct variable 
Cited commit mistakenly copied provided option to 'val' instead of to
'mfc':

```
-               if (copy_from_user(&mfc, optval, sizeof(mfc))) {
+               if (copy_from_sockptr(&val, optval, sizeof(val))) {
```

Fix this by copying the option to 'mfc'.

selftest router_multicast.sh before:

$ ./router_multicast.sh
smcroutectl: Unknown or malformed IPC message 'a' from client.
smcroutectl: failed removing multicast route, does not exist.
TEST: mcast IPv4                                                    [FAIL]
        Multicast not received on first host
TEST: mcast IPv6                                                    [ OK ]
smcroutectl: Unknown or malformed IPC message 'a' from client.
smcroutectl: failed removing multicast route, does not exist.
TEST: RPF IPv4                                                      [FAIL]
        Multicast not received on first host
TEST: RPF IPv6                                                      [ OK ]

selftest router_multicast.sh after:

$ ./router_multicast.sh
TEST: mcast IPv4                                                    [ OK ]
TEST: mcast IPv6                                                    [ OK ]
TEST: RPF IPv4                                                      [ OK ]
TEST: RPF IPv6                                                      [ OK ]

Fixes: 01ccb5b48f08 ("net/ipv4: switch ip_mroute_setsockopt to sockptr_t")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
2020-07-27 11:39:55 -07:00
..
bpfilter
net: optimize the sockptr_t for unified kernel/user address spaces
2020-07-24 15:41:54 -07:00
netfilter
netfilter: switch nf_setsockopt to sockptr_t
2020-07-24 15:41:54 -07:00
af_inet.c
net: remove compat_sock_common_{get,set}sockopt
2020-07-19 18:16:40 -07:00
ah4.c
inet: Use fallthrough;
2020-03-12 15:55:00 -07:00
arp.c
inet: Use fallthrough;
2020-03-12 15:55:00 -07:00
bpf_tcp_ca.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next
2020-03-30 19:52:37 -07:00
cipso_ipv4.c
net: ipv4: kerneldoc fixes
2020-07-13 17:20:39 -07:00
datagram.c
inet: stop leaking jiffies on the wire
2019-11-01 14:57:52 -07:00
devinet.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-05-31 17:48:46 -07:00
esp4_offload.c
net: Add MODULE_DESCRIPTION entries to network modules
2020-06-20 21:33:57 -07:00
esp4.c
ESP: Export esp_output_fill_trailer function
2020-02-19 13:52:32 +01:00
fib_frontend.c
ipv4: nexthop version of fib_info_nh_uses_dev
2020-05-26 16:06:07 -07:00
fib_lookup.h
net: add net available in build_state
2020-03-29 22:30:57 -07:00
fib_notifier.c
net: fib_notifier: propagate extack down to the notifier block callback
2019-10-04 11:10:56 -07:00
fib_rules.c
net: fib_notifier: propagate extack down to the notifier block callback
2019-10-04 11:10:56 -07:00
fib_semantics.c
net: Fix the arp error in some cases
2020-06-18 20:21:51 -07:00
fib_trie.c
Replace HTTP links with HTTPS ones: IPv*
2020-07-06 13:23:03 -07:00
fou.c
net: Add MODULE_DESCRIPTION entries to network modules
2020-06-20 21:33:57 -07:00
gre_demux.c
gre: fix uninit-value in __iptunnel_pull_header
2020-03-08 21:25:37 -07:00
gre_offload.c
net: remove the check argument from __skb_gro_checksum_convert
2020-01-03 12:24:34 -08:00
icmp.c
icmp6: support rfc 4884
2020-07-24 17:12:41 -07:00
igmp.c
ip*_mc_gsfget(): lift copyout of struct group_filter into callers
2020-05-20 20:31:27 -04:00
inet_connection_sock.c
net/ipv6: remove compat_ipv6_{get,set}sockopt
2020-07-19 18:16:41 -07:00
inet_diag.c
inet_diag: support for wider protocol numbers
2020-07-09 12:38:41 -07:00
inet_fragment.c
inet: frags: re-introduce skb coalescing for local delivery
2019-08-08 15:55:10 -07:00
inet_hashtables.c
inet: Run SK_LOOKUP BPF program on socket lookup
2020-07-17 20:18:16 -07:00
inet_timewait_sock.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
inetpeer.c
inetpeer: fix data-race in inet_putpeer / inet_putpeer
2019-11-07 16:15:56 -08:00
ip_forward.c
ipv4: Revert removal of rt_uses_gateway
2019-09-20 18:23:33 -07:00
ip_fragment.c
inet: frags: re-introduce skb coalescing for local delivery
2019-08-08 15:55:10 -07:00
ip_gre.c
net: add a new ndo_tunnel_ioctl method
2020-05-19 15:45:11 -07:00
ip_input.c
bpf: Add socket assign support
2020-03-30 13:45:04 -07:00
ip_options.c
net/ipv4: merge ip_options_get and ip_options_get_from_user
2020-07-24 15:41:54 -07:00
ip_output.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-07-11 00:46:00 -07:00
ip_sockglue.c
icmp: prepare rfc 4884 for ipv6
2020-07-24 17:12:41 -07:00
ip_tunnel_core.c
net: ip_tunnel: add header_ops for layer 3 devices
2020-06-30 12:29:39 -07:00
ip_tunnel.c
ip_tunnel: fix use-after-free in ip_tunnel_lookup()
2020-06-18 20:12:34 -07:00
ip_vti.c
net: vti: implement header_ops->parse_protocol for AF_PACKET
2020-06-30 12:29:39 -07:00
ipcomp.c
Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next
2019-07-05 15:01:15 -07:00
ipconfig.c
Documentation: nfsroot.rst: Fix references to nfsroot.rst
2020-03-02 13:11:46 -07:00
ipip.c
net: ipip: implement header_ops->parse_protocol for AF_PACKET
2020-06-30 12:29:39 -07:00
ipmr_base.c
net: fib_notifier: propagate extack down to the notifier block callback
2019-10-04 11:10:56 -07:00
ipmr.c
ipmr: Copy option to correct variable
2020-07-27 11:39:55 -07:00
Kconfig
Replace HTTP links with HTTPS ones: IPv*
2020-07-06 13:23:03 -07:00
Makefile
udp_tunnel: add central NIC RX port offload infrastructure
2020-07-10 13:54:00 -07:00
metrics.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
netfilter.c
netfilter: ipv4: remove useless export_symbol
2019-01-28 11:32:58 +01:00
netlink.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
nexthop.c
nexthop: Fix fdb labeling for groups
2020-06-10 13:18:40 -07:00
ping.c
ipv4: fill fl4_icmp_{type,code} in ping_v4_sendmsg
2020-07-07 15:26:37 -07:00
proc.c
tcp: add SNMP counter for no. of duplicate segments reported by DSACK
2020-07-17 12:54:30 -07:00
protocol.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
raw_diag.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-03-12 22:34:48 -07:00
raw.c
net: pass a sockptr_t into ->setsockopt
2020-07-24 15:41:54 -07:00
route.c
net: ipv4: Fix wrong type conversion from hint to rt in ip_route_use_hint()
2020-06-27 18:02:32 -07:00
syncookies.c
mptcp: handle tcp fallback when using syn cookies
2020-01-29 17:45:20 +01:00
sysctl_net_ipv4.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next
2020-05-01 17:02:27 -07:00
tcp_bbr.c
tcp_bbr: improve arithmetic division in bbr_update_bw()
2020-01-21 10:45:49 +01:00
tcp_bic.c
tcp: fix stretch ACK bugs in BIC
2020-03-16 18:26:54 -07:00
tcp_bpf.c
bpf: tcp: Recv() should return 0 when the peer socket is closed
2020-06-12 15:10:12 -07:00
tcp_cdg.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
tcp_cong.c
tcp: make sure listeners don't initialize congestion-control state
2020-07-09 13:07:45 -07:00
tcp_cubic.c
tcp_cubic: fix spurious HYSTART_DELAY exit upon drop in min RTT
2020-06-25 16:08:47 -07:00
tcp_dctcp.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
tcp_dctcp.h
tcp: refactor DCTCP ECN ACK handling
2018-10-10 22:26:00 -07:00
tcp_diag.c
inet_diag: Move the INET_DIAG_REQ_BYTECODE nlattr to cb->data
2020-02-27 18:50:19 -08:00
tcp_fastopen.c
tcp: add TCP_INFO status for failed client TFO
2019-10-25 19:25:37 -07:00
tcp_highspeed.c
Replace HTTP links with HTTPS ones: IPv*
2020-07-06 13:23:03 -07:00
tcp_htcp.c
Replace HTTP links with HTTPS ones: IPv*
2020-07-06 13:23:03 -07:00
tcp_hybla.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
tcp_illinois.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
tcp_input.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-07-25 17:49:04 -07:00
tcp_ipv4.c
net/tcp: switch ->md5_parse to sockptr_t
2020-07-24 15:41:54 -07:00
tcp_lp.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
tcp_metrics.c
net-tcp: Disable TCP ssthresh metrics cache by default
2019-12-09 20:17:48 -08:00
tcp_minisocks.c
mptcp: add new sock flag to deal with join subflows
2020-05-15 12:30:13 -07:00
tcp_nv.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
tcp_offload.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
tcp_output.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-07-25 17:49:04 -07:00
tcp_rate.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
tcp_recovery.c
tcp: introduce tcp_skb_timestamp_us() helper
2018-09-21 19:37:59 -07:00
tcp_scalable.c
tcp: fix stretch ACK bugs in Scalable
2020-03-16 18:26:54 -07:00
tcp_timer.c
net: ipv4: kerneldoc fixes
2020-07-13 17:20:39 -07:00
tcp_ulp.c
bpf: sockmap: Only check ULP for TCP sockets
2020-03-09 22:34:58 +01:00
tcp_vegas.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
tcp_vegas.h
…
tcp_veno.c
Replace HTTP links with HTTPS ones: IPv*
2020-07-06 13:23:03 -07:00
tcp_westwood.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
tcp_yeah.c
tcp: fix stretch ACK bugs in Yeah
2020-03-16 18:26:55 -07:00
tcp.c
net: pass a sockptr_t into ->setsockopt
2020-07-24 15:41:54 -07:00
tunnel4.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
udp_bpf.c
bpf: Add sockmap hooks for UDP sockets
2020-03-09 22:34:58 +01:00
udp_diag.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-03-12 22:34:48 -07:00
udp_impl.h
net: pass a sockptr_t into ->setsockopt
2020-07-24 15:41:54 -07:00
udp_offload.c
udp: initialize is_flist with 0 in udp_gro_receive
2020-03-30 10:35:03 -07:00
udp_tunnel_core.c
udp_tunnel: add central NIC RX port offload infrastructure
2020-07-10 13:54:00 -07:00
udp_tunnel_nic.c
ethtool: add tunnel info interface
2020-07-10 13:54:00 -07:00
udp_tunnel_stub.c
udp_tunnel: add central NIC RX port offload infrastructure
2020-07-10 13:54:00 -07:00
udp.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-07-25 17:49:04 -07:00
udplite.c
net/ipv4: remove compat_ip_{get,set}sockopt
2020-07-19 18:16:41 -07:00
xfrm4_input.c
xfrm: state: remove extract_input indirection from xfrm_state_afinfo
2020-05-06 09:40:08 +02:00
xfrm4_output.c
xfrm: fix unused variable warning if CONFIG_NETFILTER=n
2020-05-11 15:12:27 +02:00
xfrm4_policy.c
net: add bool confirm_neigh parameter for dst_ops.update_pmtu
2019-12-24 22:28:54 -08:00
xfrm4_protocol.c
xfrm: add route lookup to xfrm4_rcv_encap
2019-12-09 09:59:07 +01:00
xfrm4_state.c
xfrm: remove output_finish indirection from xfrm_state_afinfo
2020-05-06 09:40:08 +02:00
xfrm4_tunnel.c
xfrm: remove type and offload_type map from xfrm_state_afinfo
2019-06-06 08:34:50 +02:00