817a7c9967
mptsas_cleanup_fw_event_q() uses in_interrupt() to determine if it is safe to cancel a worker item. Aside of that in_interrupt() is deprecated as it does not provide what the name suggests. It covers more than hard/soft interrupt servicing context and is semantically ill defined. Looking closer there are a few problems with the current construct: - It could be invoked from an interrupt handler / non-blocking context because cancel_delayed_work() has no such restriction. Also, mptsas_free_fw_event() has no such restriction. - The list is accessed unlocked. It may dequeue a valid work-item but at the time of invoking cancel_delayed_work() the memory may be released or reused because the worker has already run. mptsas_cleanup_fw_event_q() is invoked via mptsas_shutdown() which is always invoked from preemtible context on device shutdown. It is also invoked via mptsas_ioc_reset(, MPT_IOC_POST_RESET) which is a MptResetHandlers callback. The only caller here are mpt_SoftResetHandler(), mpt_HardResetHandler() and mpt_Soft_Hard_ResetHandler(). All these functions have a `sleepFlag' argument and each caller uses caller uses `CAN_SLEEP' here and according to current documentation: | @sleepFlag: Indicates if sleep or schedule must be called So it is safe to sleep. Add mptsas_hotplug_event::users member. Initialize it to one by default so mptsas_free_fw_event() will free the memory. mptsas_cleanup_fw_event_q() will increment its value for items it dequeues and then it may keep a pointer after dropping the lock. Invoke cancel_delayed_work_sync() to cancel the work item and wait if the worker is currently busy. Free the memory afterwards since it owns the last reference to it. Link: https://lore.kernel.org/r/20201126132952.2287996-15-bigeasy@linutronix.de Cc: Sathya Prakash <sathya.prakash@broadcom.com> Cc: Sreekanth Reddy <sreekanth.reddy@broadcom.com> Cc: Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com> Cc: MPT-FusionLinux.pdl@broadcom.com Reviewed-by: Daniel Wagner <dwagner@suse.de> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
194 lines
6.6 KiB
C
194 lines
6.6 KiB
C
/*
|
|
* linux/drivers/message/fusion/mptsas.h
|
|
* High performance SCSI + LAN / Fibre Channel device drivers.
|
|
* For use with PCI chip/adapter(s):
|
|
* LSIFC9xx/LSI409xx Fibre Channel
|
|
* running LSI MPT (Message Passing Technology) firmware.
|
|
*
|
|
* Copyright (c) 1999-2008 LSI Corporation
|
|
* (mailto:DL-MPTFusionLinux@lsi.com)
|
|
*
|
|
*/
|
|
/*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/
|
|
/*
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
NO WARRANTY
|
|
THE PROGRAM IS PROVIDED ON AN "AS IS" BASIS, WITHOUT WARRANTIES OR
|
|
CONDITIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED INCLUDING, WITHOUT
|
|
LIMITATION, ANY WARRANTIES OR CONDITIONS OF TITLE, NON-INFRINGEMENT,
|
|
MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE. Each Recipient is
|
|
solely responsible for determining the appropriateness of using and
|
|
distributing the Program and assumes all risks associated with its
|
|
exercise of rights under this Agreement, including but not limited to
|
|
the risks and costs of program errors, damage to or loss of data,
|
|
programs or equipment, and unavailability or interruption of operations.
|
|
|
|
DISCLAIMER OF LIABILITY
|
|
NEITHER RECIPIENT NOR ANY CONTRIBUTORS SHALL HAVE ANY LIABILITY FOR ANY
|
|
DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
DAMAGES (INCLUDING WITHOUT LIMITATION LOST PROFITS), HOWEVER CAUSED AND
|
|
ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
|
|
TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
|
|
USE OR DISTRIBUTION OF THE PROGRAM OR THE EXERCISE OF ANY RIGHTS GRANTED
|
|
HEREUNDER, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGES
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*/
|
|
|
|
#ifndef MPTSAS_H_INCLUDED
|
|
#define MPTSAS_H_INCLUDED
|
|
/*{-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/
|
|
|
|
struct mptsas_target_reset_event {
|
|
struct list_head list;
|
|
EVENT_DATA_SAS_DEVICE_STATUS_CHANGE sas_event_data;
|
|
u8 target_reset_issued;
|
|
unsigned long time_count;
|
|
};
|
|
|
|
enum mptsas_hotplug_action {
|
|
MPTSAS_ADD_DEVICE,
|
|
MPTSAS_DEL_DEVICE,
|
|
MPTSAS_ADD_RAID,
|
|
MPTSAS_DEL_RAID,
|
|
MPTSAS_ADD_PHYSDISK,
|
|
MPTSAS_ADD_PHYSDISK_REPROBE,
|
|
MPTSAS_DEL_PHYSDISK,
|
|
MPTSAS_DEL_PHYSDISK_REPROBE,
|
|
MPTSAS_ADD_INACTIVE_VOLUME,
|
|
MPTSAS_IGNORE_EVENT,
|
|
};
|
|
|
|
struct mptsas_mapping{
|
|
u8 id;
|
|
u8 channel;
|
|
};
|
|
|
|
struct mptsas_device_info {
|
|
struct list_head list;
|
|
struct mptsas_mapping os; /* operating system mapping*/
|
|
struct mptsas_mapping fw; /* firmware mapping */
|
|
u64 sas_address;
|
|
u32 device_info; /* specific bits for devices */
|
|
u16 slot; /* enclosure slot id */
|
|
u64 enclosure_logical_id; /*enclosure address */
|
|
u8 is_logical_volume; /* is this logical volume */
|
|
/* this belongs to volume */
|
|
u8 is_hidden_raid_component;
|
|
/* this valid when is_hidden_raid_component set */
|
|
u8 volume_id;
|
|
/* cached data for a removed device */
|
|
u8 is_cached;
|
|
};
|
|
|
|
struct mptsas_hotplug_event {
|
|
MPT_ADAPTER *ioc;
|
|
enum mptsas_hotplug_action event_type;
|
|
u64 sas_address;
|
|
u8 channel;
|
|
u8 id;
|
|
u32 device_info;
|
|
u16 handle;
|
|
u8 phy_id;
|
|
u8 phys_disk_num; /* hrc - unique index*/
|
|
struct scsi_device *sdev;
|
|
};
|
|
|
|
struct fw_event_work {
|
|
struct list_head list;
|
|
struct delayed_work work;
|
|
int users;
|
|
MPT_ADAPTER *ioc;
|
|
u32 event;
|
|
u8 retries;
|
|
char event_data[] __aligned(4);
|
|
};
|
|
|
|
struct mptsas_discovery_event {
|
|
struct work_struct work;
|
|
MPT_ADAPTER *ioc;
|
|
};
|
|
|
|
/*
|
|
* SAS topology structures
|
|
*
|
|
* The MPT Fusion firmware interface spreads information about the
|
|
* SAS topology over many manufacture pages, thus we need some data
|
|
* structure to collect it and process it for the SAS transport class.
|
|
*/
|
|
|
|
struct mptsas_devinfo {
|
|
u16 handle; /* unique id to address this device */
|
|
u16 handle_parent; /* unique id to address parent device */
|
|
u16 handle_enclosure; /* enclosure identifier of the enclosure */
|
|
u16 slot; /* physical slot in enclosure */
|
|
u8 phy_id; /* phy number of parent device */
|
|
u8 port_id; /* sas physical port this device
|
|
is assoc'd with */
|
|
u8 id; /* logical target id of this device */
|
|
u32 phys_disk_num; /* phys disk id, for csmi-ioctls */
|
|
u8 channel; /* logical bus number of this device */
|
|
u64 sas_address; /* WWN of this device,
|
|
SATA is assigned by HBA,expander */
|
|
u32 device_info; /* bitfield detailed info about this device */
|
|
u16 flags; /* sas device pg0 flags */
|
|
};
|
|
|
|
/*
|
|
* Specific details on ports, wide/narrow
|
|
*/
|
|
struct mptsas_portinfo_details{
|
|
u16 num_phys; /* number of phys belong to this port */
|
|
u64 phy_bitmask; /* TODO, extend support for 255 phys */
|
|
struct sas_rphy *rphy; /* transport layer rphy object */
|
|
struct sas_port *port; /* transport layer port object */
|
|
struct scsi_target *starget;
|
|
struct mptsas_portinfo *port_info;
|
|
};
|
|
|
|
struct mptsas_phyinfo {
|
|
u16 handle; /* unique id to address this */
|
|
u8 phy_id; /* phy index */
|
|
u8 port_id; /* firmware port identifier */
|
|
u8 negotiated_link_rate; /* nego'd link rate for this phy */
|
|
u8 hw_link_rate; /* hardware max/min phys link rate */
|
|
u8 programmed_link_rate; /* programmed max/min phy link rate */
|
|
u8 sas_port_add_phy; /* flag to request sas_port_add_phy*/
|
|
struct mptsas_devinfo identify; /* point to phy device info */
|
|
struct mptsas_devinfo attached; /* point to attached device info */
|
|
struct sas_phy *phy; /* transport layer phy object */
|
|
struct mptsas_portinfo *portinfo;
|
|
struct mptsas_portinfo_details * port_details;
|
|
};
|
|
|
|
struct mptsas_portinfo {
|
|
struct list_head list;
|
|
u16 num_phys; /* number of phys */
|
|
struct mptsas_phyinfo *phy_info;
|
|
};
|
|
|
|
struct mptsas_enclosure {
|
|
u64 enclosure_logical_id; /* The WWN for the enclosure */
|
|
u16 enclosure_handle; /* unique id to address this */
|
|
u16 flags; /* details enclosure management */
|
|
u16 num_slot; /* num slots */
|
|
u16 start_slot; /* first slot */
|
|
u8 start_id; /* starting logical target id */
|
|
u8 start_channel; /* starting logical channel id */
|
|
u8 sep_id; /* SEP device logical target id */
|
|
u8 sep_channel; /* SEP channel logical channel id */
|
|
};
|
|
|
|
/*}-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/
|
|
#endif
|