linux

iv/linux

History

Namhyung Kim 2b8dbf69ec perf annotate: Make sure to call symbol__annotate2() in TUI

The symbol__annotate2() initializes some data structures needed by TUI.
It has a logic to prevent calling it multiple times by checking if it
has the annotated source.  But data type profiling uses a different
code (symbol__annotate) to allocate the annotated lines in advance.
So TUI missed to call symbol__annotate2() when it shows the annotation
browser.

Make symbol__annotate() reentrant and handle that situation properly.
This fixes a crash in the annotation browser started by perf report in
TUI like below.

  $ perf report -s type,sym --tui
  # and press 'a' key and then move down

Fixes: 81e57deec325 ("perf report: Support data type profiling")
Reviewed-by: Ian Rogers <irogers@google.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20240405211800.1412920-2-namhyung@kernel.org

2024-04-11 10:14:58 -07:00

browsers

perf annotate: Make sure to call symbol__annotate2() in TUI

2024-04-11 10:14:58 -07:00

gtk

perf annotate: Calculate instruction overhead using hashmap

2024-03-06 20:25:20 -08:00

stdio

perf thread: Add accessor functions for thread

2023-06-12 15:57:53 -03:00

tui

perf TUI: Don't ignore job control