Damien Le Moal e1777d0997 null_blk: Fix scheduling in atomic with zoned mode
Commit aa1c09cb65e2 ("null_blk: Fix locking in zoned mode") changed
zone locking to using the potentially sleeping wait_on_bit_io()
function. This is acceptable when memory backing is enabled as the
device queue is in that case marked as blocking, but this triggers a
scheduling while in atomic context with memory backing disabled.

Fix this by relying solely on the device zone spinlock for zone
information protection without temporarily releasing this lock around
null_process_cmd() execution in null_zone_write(). This is OK to do
since when memory backing is disabled, command processing does not
block and the memory backing lock nullb->lock is unused. This solution
avoids the overhead of having to mark a zoned null_blk device queue as
blocking when memory backing is unused.

This patch also adds comments to the zone locking code to explain the
unusual locking scheme.

Fixes: aa1c09cb65e2 ("null_blk: Fix locking in zoned mode")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: stable@vger.kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2020-11-06 09:36:42 -07:00
..
2020-10-13 12:12:44 -07:00
2020-10-02 17:54:45 -06:00
2020-10-24 12:46:42 -07:00
2020-09-10 09:32:30 -06:00
2020-09-10 09:32:30 -06:00
2020-09-24 13:43:39 -06:00
2020-09-10 09:32:30 -06:00
2020-10-21 10:34:10 -07:00
2020-09-10 09:32:31 -06:00
2020-09-10 09:32:30 -06:00
2018-11-09 08:14:14 -07:00