Gal Pressman 75b81ce719 net/mlx5e: Don't override netdev features field unless in error flow
Set features function sets dev->features in order to keep track of which
features were successfully changed and which weren't (in case the user
asks for more than one change in a single command).

This breaks the logic in __netdev_update_features which assumes that
dev->features is not changed on success and checks for diffs between
features and dev->features (diffs that might not exist at this point
because of the driver override).

The solution is to keep track of successful/failed feature changes and
assign them to dev->features in case of failure only.

Fixes: 0e405443e803 ("net/mlx5e: Improve set features ndo resiliency")
Signed-off-by: Gal Pressman <galp@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
2018-01-12 02:01:49 +02:00
..
2018-01-08 14:30:28 -05:00
2017-11-14 15:46:17 +09:00
2018-01-10 15:08:46 -05:00
2017-11-21 15:57:07 -08:00
2017-11-16 10:49:00 +09:00
2017-12-02 21:31:03 -05:00
2017-12-02 21:31:03 -05:00
2017-12-08 12:58:51 -08:00
2017-12-19 13:37:27 -05:00