Chris Wilson
7771590692
drm/i915: Keep drm_i915_file_private around under RCU ...
Ensure that the drm_i915_file_private continues to exist as we attempt
to remove a request from its list, which may race with the destruction
of the file.
<6> [38.380714] [IGT] gem_ctx_create: starting subtest basic-files
<0> [42.201329] BUG: spinlock bad magic on CPU#0, kworker/u16:0/7
<4> [42.201356] general protection fault: 0000 [#1 ] PREEMPT SMP PTI
<4> [42.201371] CPU: 0 PID: 7 Comm: kworker/u16:0 Tainted: G U 5.3.0-rc5-CI-Patchwork_14169+ #1
<4> [42.201391] Hardware name: Dell Inc. OptiPlex 745 /0GW726, BIOS 2.3.1 05/21/2007
<4> [42.201594] Workqueue: i915 retire_work_handler [i915]
<4> [42.201614] RIP: 0010:spin_dump+0x5a/0x90
<4> [42.201625] Code: 00 48 8d 88 c0 06 00 00 48 c7 c7 00 71 09 82 e8 35 ef 00 00 48 85 db 44 8b 4d 08 41 b8 ff ff ff ff 48 c7 c1 0b cd 0f 82 74 0e <44> 8b 83 e0 04 00 00 48 8d 8b c0 06 00 00 8b 55 04 48 89 ee 48 c7
<4> [42.201660] RSP: 0018:ffffc9000004bd80 EFLAGS: 00010202
<4> [42.201673] RAX: 0000000000000031 RBX: 6b6b6b6b6b6b6b6b RCX: ffffffff820fcd0b
<4> [42.201688] RDX: 0000000000000000 RSI: ffff88803de266f8 RDI: 00000000ffffffff
<4> [42.201703] RBP: ffff888038381ff8 R08: 00000000ffffffff R09: 000000006b6b6b6b
<4> [42.201718] R10: 0000000041cb0b89 R11: 646162206b636f6c R12: ffff88802a618500
<4> [42.201733] R13: ffff88802b32c288 R14: ffff888038381ff8 R15: ffff88802b32c250
<4> [42.201748] FS: 0000000000000000(0000) GS:ffff88803de00000(0000) knlGS:0000000000000000
<4> [42.201765] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
<4> [42.201778] CR2: 00007f2cefc6d180 CR3: 00000000381ee000 CR4: 00000000000006f0
<4> [42.201793] Call Trace:
<4> [42.201805] do_raw_spin_lock+0x66/0xb0
<4> [42.201898] i915_request_retire+0x548/0x7c0 [i915]
<4> [42.201989] retire_requests+0x4d/0x60 [i915]
<4> [42.202078] i915_retire_requests+0x144/0x2e0 [i915]
<4> [42.202169] retire_work_handler+0x10/0x40 [i915]
Recently, in commit 44c22f3f1a0a ("drm/i915: Serialize insertion into the
file->mm.request_list"), we fixed a race on insertion. Now, it appears
we also have a race with destruction!
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190823181455.31910-1-chris@chris-wilson.co.uk
2019-08-23 22:13:17 +01:00
2019-08-03 07:02:01 -07:00
2019-07-12 12:24:03 -07:00
2019-07-24 11:02:28 +02:00
2019-07-31 08:51:17 -06:00
2019-07-15 11:06:27 -07:00
2019-07-09 12:34:26 -07:00
2019-07-28 10:26:10 -07:00
2019-07-31 08:51:56 -06:00
2019-07-31 13:17:33 -07:00
2019-07-19 17:13:56 -07:00
2019-06-14 14:20:46 -06:00
2019-08-05 00:55:00 +03:00
2019-07-22 15:04:54 -07:00
2019-07-10 11:05:26 +02:00
2019-07-21 13:31:14 -07:00
2019-07-11 15:36:02 -07:00
2019-07-23 09:49:10 +02:00
2019-07-18 09:49:30 +02:00
2019-07-19 12:23:37 -07:00
2019-07-19 10:42:02 -07:00
2019-06-19 17:09:55 +02:00
2019-07-17 09:55:43 -07:00
2019-08-17 18:46:33 +01:00
2019-06-27 10:24:47 -07:00
2019-06-19 17:09:55 +02:00
2019-07-25 20:09:37 -05:00
2019-07-26 09:43:43 -07:00
2019-07-24 11:29:41 +02:00
2019-06-19 17:09:11 +02:00
2019-07-29 00:57:39 +02:00
2019-08-23 22:13:17 +01:00
2019-07-15 09:42:32 -07:00
2019-07-18 17:08:07 -07:00
2019-07-21 19:18:45 -07:00
2019-06-29 21:08:14 -07:00
2019-07-12 14:42:05 -07:00
2019-08-01 22:24:16 +02:00
2019-07-09 09:04:31 -07:00
2019-07-09 12:34:26 -07:00
2019-07-12 12:24:03 -07:00
2019-08-01 12:53:53 -04:00
2019-07-20 12:22:30 -07:00
2019-07-29 11:34:12 -07:00
2019-07-11 15:38:21 -07:00
2019-08-01 20:21:00 +02:00
2019-07-15 11:10:31 -07:00
2019-07-09 08:59:39 -07:00
2019-06-21 03:14:30 -06:00
2019-07-31 21:44:45 +10:00
2019-07-14 16:36:51 -07:00
2019-07-30 18:59:24 -04:00
2019-07-22 09:01:47 -07:00
2019-07-20 09:34:55 -07:00
2019-07-11 18:11:21 -07:00
2019-07-11 15:14:01 -07:00
2019-07-15 20:18:40 -07:00
2019-08-01 14:05:17 +02:00
2019-07-22 15:31:00 +02:00
2019-08-04 16:37:08 -07:00
2019-07-27 11:04:18 -07:00
2019-07-02 12:00:50 -07:00
2019-07-21 09:46:59 -07:00
2019-07-27 08:25:51 -07:00
2019-07-23 17:47:02 +02:00
2019-07-12 12:24:03 -07:00
2019-07-17 11:26:09 -07:00
2019-07-15 20:44:49 -07:00
2019-07-04 22:01:59 -04:00
2019-07-09 12:34:26 -07:00
2019-07-21 09:46:59 -07:00
2019-07-09 12:34:26 -07:00
2019-07-29 11:43:48 +01:00
2019-07-01 15:04:59 +02:00
2019-07-13 15:02:27 -07:00
2019-07-29 18:24:59 +03:00
2019-07-15 11:03:02 -03:00
2019-07-15 21:06:15 -07:00
2019-07-22 11:23:00 +02:00
2019-07-16 19:23:24 -07:00
2019-06-15 13:43:06 -07:00
2019-07-09 08:57:45 -07:00
2019-07-17 08:58:04 -07:00
2019-07-15 20:18:40 -07:00
2019-07-17 11:44:41 -07:00
2019-07-19 17:13:56 -07:00
2019-07-17 10:03:50 -07:00
2019-08-02 15:13:27 -07:00
2019-08-02 14:46:33 -07:00
2019-07-22 13:51:20 -06:00
2019-07-05 08:15:08 +02:00
2019-07-12 12:24:03 -07:00
2019-06-25 08:05:34 +03:00
2019-07-16 12:21:41 -07:00
2019-07-22 17:04:20 -04:00
2019-07-23 09:36:07 +02:00
2019-07-12 12:24:03 -07:00
2019-07-28 10:18:33 -07:00
2019-06-19 17:09:55 +02:00
2019-07-25 11:26:42 +02:00
2019-06-19 17:09:07 +02:00
2019-07-17 11:23:13 -07:00
2019-07-26 07:49:29 -04:00
2019-08-16 21:10:09 +02:00
2019-07-19 10:42:02 -07:00
2019-06-24 05:22:31 +02:00
2019-07-15 11:03:02 -03:00
2019-07-15 08:49:11 +02:00
2019-08-02 15:26:48 -07:00
7771590692