4a0f07d71b
When making CONFIG_DEBUG_KMEMLEAK=y and CONFIG_DEBUG_KMEMLEAK_AUTO_SCAN=y,
modprobe handshake-test and then rmmmod handshake-test, the below memory
leak is detected.
The struct socket_alloc which is allocated by alloc_inode_sb() in
__sock_create() is not freed. And the struct dentry which is allocated
by __d_alloc() in sock_alloc_file() is not freed.
Since fput() will call file->f_op->release() which is sock_close() here and
it will call __sock_release(). and fput() will call dput(dentry) to free
the struct dentry. So replace sock_release() with fput() to fix the
below memory leak. After applying this patch, the following memory leak is
never detected.
unreferenced object 0xffff888109165840 (size 768):
comm "kunit_try_catch", pid 1852, jiffies 4294685807 (age 976.262s)
hex dump (first 32 bytes):
01 00 00 00 01 00 5a 5a 20 00 00 00 00 00 00 00 ......ZZ .......
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff8397993f>] sock_alloc_inode+0x1f/0x1b0
[<ffffffff81a2cb5b>] alloc_inode+0x5b/0x1a0
[<ffffffff81a32bed>] new_inode_pseudo+0xd/0x70
[<ffffffff8397889c>] sock_alloc+0x3c/0x260
[<ffffffff83979b46>] __sock_create+0x66/0x3d0
[<ffffffffa0209ba2>] 0xffffffffa0209ba2
[<ffffffff829cf03a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
[<ffffffff81236fc6>] kthread+0x2b6/0x380
[<ffffffff81096afd>] ret_from_fork+0x2d/0x70
[<ffffffff81003511>] ret_from_fork_asm+0x11/0x20
unreferenced object 0xffff88810f472008 (size 192):
comm "kunit_try_catch", pid 1852, jiffies 4294685808 (age 976.261s)
hex dump (first 32 bytes):
00 00 50 40 02 00 00 00 00 00 00 00 00 00 00 00 ..P@............
00 00 00 00 00 00 00 00 08 20 47 0f 81 88 ff ff ......... G.....
backtrace:
[<ffffffff81a1ff11>] __d_alloc+0x31/0x8a0
[<ffffffff81a2910e>] d_alloc_pseudo+0xe/0x50
[<ffffffff819d549e>] alloc_file_pseudo+0xce/0x210
[<ffffffff83978582>] sock_alloc_file+0x42/0x1b0
[<ffffffffa0209bbb>] 0xffffffffa0209bbb
[<ffffffff829cf03a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
[<ffffffff81236fc6>] kthread+0x2b6/0x380
[<ffffffff81096afd>] ret_from_fork+0x2d/0x70
[<ffffffff81003511>] ret_from_fork_asm+0x11/0x20
unreferenced object 0xffff88810958e580 (size 224):
comm "kunit_try_catch", pid 1852, jiffies 4294685808 (age 976.261s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 03 00 2e 08 01 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff819d4b90>] alloc_empty_file+0x50/0x160
[<ffffffff819d4cf9>] alloc_file+0x59/0x730
[<ffffffff819d5524>] alloc_file_pseudo+0x154/0x210
[<ffffffff83978582>] sock_alloc_file+0x42/0x1b0
[<ffffffffa0209bbb>] 0xffffffffa0209bbb
[<ffffffff829cf03a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
[<ffffffff81236fc6>] kthread+0x2b6/0x380
[<ffffffff81096afd>] ret_from_fork+0x2d/0x70
[<ffffffff81003511>] ret_from_fork_asm+0x11/0x20
unreferenced object 0xffff88810926dc88 (size 192):
comm "kunit_try_catch", pid 1854, jiffies 4294685809 (age 976.271s)
hex dump (first 32 bytes):
00 00 50 40 02 00 00 00 00 00 00 00 00 00 00 00 ..P@............
00 00 00 00 00 00 00 00 88 dc 26 09 81 88 ff ff ..........&.....
backtrace:
[<ffffffff81a1ff11>] __d_alloc+0x31/0x8a0
[<ffffffff81a2910e>] d_alloc_pseudo+0xe/0x50
[<ffffffff819d549e>] alloc_file_pseudo+0xce/0x210
[<ffffffff83978582>] sock_alloc_file+0x42/0x1b0
[<ffffffffa0208fdc>] 0xffffffffa0208fdc
[<ffffffff829cf03a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
[<ffffffff81236fc6>] kthread+0x2b6/0x380
[<ffffffff81096afd>] ret_from_fork+0x2d/0x70
[<ffffffff81003511>] ret_from_fork_asm+0x11/0x20
unreferenced object 0xffff88810a241380 (size 224):
comm "kunit_try_catch", pid 1854, jiffies 4294685809 (age 976.271s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 03 00 2e 08 01 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff819d4b90>] alloc_empty_file+0x50/0x160
[<ffffffff819d4cf9>] alloc_file+0x59/0x730
[<ffffffff819d5524>] alloc_file_pseudo+0x154/0x210
[<ffffffff83978582>] sock_alloc_file+0x42/0x1b0
[<ffffffffa0208fdc>] 0xffffffffa0208fdc
[<ffffffff829cf03a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
[<ffffffff81236fc6>] kthread+0x2b6/0x380
[<ffffffff81096afd>] ret_from_fork+0x2d/0x70
[<ffffffff81003511>] ret_from_fork_asm+0x11/0x20
unreferenced object 0xffff888109165040 (size 768):
comm "kunit_try_catch", pid 1856, jiffies 4294685811 (age 976.269s)
hex dump (first 32 bytes):
01 00 00 00 01 00 5a 5a 20 00 00 00 00 00 00 00 ......ZZ .......
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff8397993f>] sock_alloc_inode+0x1f/0x1b0
[<ffffffff81a2cb5b>] alloc_inode+0x5b/0x1a0
[<ffffffff81a32bed>] new_inode_pseudo+0xd/0x70
[<ffffffff8397889c>] sock_alloc+0x3c/0x260
[<ffffffff83979b46>] __sock_create+0x66/0x3d0
[<ffffffffa0208860>] 0xffffffffa0208860
[<ffffffff829cf03a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
[<ffffffff81236fc6>] kthread+0x2b6/0x380
[<ffffffff81096afd>] ret_from_fork+0x2d/0x70
[<ffffffff81003511>] ret_from_fork_asm+0x11/0x20
unreferenced object 0xffff88810926d568 (size 192):
comm "kunit_try_catch", pid 1856, jiffies 4294685811 (age 976.269s)
hex dump (first 32 bytes):
00 00 50 40 02 00 00 00 00 00 00 00 00 00 00 00 ..P@............
00 00 00 00 00 00 00 00 68 d5 26 09 81 88 ff ff ........h.&.....
backtrace:
[<ffffffff81a1ff11>] __d_alloc+0x31/0x8a0
[<ffffffff81a2910e>] d_alloc_pseudo+0xe/0x50
[<ffffffff819d549e>] alloc_file_pseudo+0xce/0x210
[<ffffffff83978582>] sock_alloc_file+0x42/0x1b0
[<ffffffffa0208879>] 0xffffffffa0208879
[<ffffffff829cf03a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
[<ffffffff81236fc6>] kthread+0x2b6/0x380
[<ffffffff81096afd>] ret_from_fork+0x2d/0x70
[<ffffffff81003511>] ret_from_fork_asm+0x11/0x20
unreferenced object 0xffff88810a240580 (size 224):
comm "kunit_try_catch", pid 1856, jiffies 4294685811 (age 976.347s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 03 00 2e 08 01 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff819d4b90>] alloc_empty_file+0x50/0x160
[<ffffffff819d4cf9>] alloc_file+0x59/0x730
[<ffffffff819d5524>] alloc_file_pseudo+0x154/0x210
[<ffffffff83978582>] sock_alloc_file+0x42/0x1b0
[<ffffffffa0208879>] 0xffffffffa0208879
[<ffffffff829cf03a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
[<ffffffff81236fc6>] kthread+0x2b6/0x380
[<ffffffff81096afd>] ret_from_fork+0x2d/0x70
[<ffffffff81003511>] ret_from_fork_asm+0x11/0x20
unreferenced object 0xffff888109164c40 (size 768):
comm "kunit_try_catch", pid 1858, jiffies 4294685816 (age 976.342s)
hex dump (first 32 bytes):
01 00 00 00 01 00 5a 5a 20 00 00 00 00 00 00 00 ......ZZ .......
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff8397993f>] sock_alloc_inode+0x1f/0x1b0
[<ffffffff81a2cb5b>] alloc_inode+0x5b/0x1a0
[<ffffffff81a32bed>] new_inode_pseudo+0xd/0x70
[<ffffffff8397889c>] sock_alloc+0x3c/0x260
[<ffffffff83979b46>] __sock_create+0x66/0x3d0
[<ffffffffa0208541>] 0xffffffffa0208541
[<ffffffff829cf03a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
[<ffffffff81236fc6>] kthread+0x2b6/0x380
[<ffffffff81096afd>] ret_from_fork+0x2d/0x70
[<ffffffff81003511>] ret_from_fork_asm+0x11/0x20
unreferenced object 0xffff88810926cd18 (size 192):
comm "kunit_try_catch", pid 1858, jiffies 4294685816 (age 976.342s)
hex dump (first 32 bytes):
00 00 50 40 02 00 00 00 00 00 00 00 00 00 00 00 ..P@............
00 00 00 00 00 00 00 00 18 cd 26 09 81 88 ff ff ..........&.....
backtrace:
[<ffffffff81a1ff11>] __d_alloc+0x31/0x8a0
[<ffffffff81a2910e>] d_alloc_pseudo+0xe/0x50
[<ffffffff819d549e>] alloc_file_pseudo+0xce/0x210
[<ffffffff83978582>] sock_alloc_file+0x42/0x1b0
[<ffffffffa020855a>] 0xffffffffa020855a
[<ffffffff829cf03a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
[<ffffffff81236fc6>] kthread+0x2b6/0x380
[<ffffffff81096afd>] ret_from_fork+0x2d/0x70
[<ffffffff81003511>] ret_from_fork_asm+0x11/0x20
unreferenced object 0xffff88810a240200 (size 224):
comm "kunit_try_catch", pid 1858, jiffies 4294685816 (age 976.342s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 03 00 2e 08 01 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff819d4b90>] alloc_empty_file+0x50/0x160
[<ffffffff819d4cf9>] alloc_file+0x59/0x730
[<ffffffff819d5524>] alloc_file_pseudo+0x154/0x210
[<ffffffff83978582>] sock_alloc_file+0x42/0x1b0
[<ffffffffa020855a>] 0xffffffffa020855a
[<ffffffff829cf03a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
[<ffffffff81236fc6>] kthread+0x2b6/0x380
[<ffffffff81096afd>] ret_from_fork+0x2d/0x70
[<ffffffff81003511>] ret_from_fork_asm+0x11/0x20
unreferenced object 0xffff888109164840 (size 768):
comm "kunit_try_catch", pid 1860, jiffies 4294685817 (age 976.416s)
hex dump (first 32 bytes):
01 00 00 00 01 00 5a 5a 20 00 00 00 00 00 00 00 ......ZZ .......
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff8397993f>] sock_alloc_inode+0x1f/0x1b0
[<ffffffff81a2cb5b>] alloc_inode+0x5b/0x1a0
[<ffffffff81a32bed>] new_inode_pseudo+0xd/0x70
[<ffffffff8397889c>] sock_alloc+0x3c/0x260
[<ffffffff83979b46>] __sock_create+0x66/0x3d0
[<ffffffffa02093e2>] 0xffffffffa02093e2
[<ffffffff829cf03a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
[<ffffffff81236fc6>] kthread+0x2b6/0x380
[<ffffffff81096afd>] ret_from_fork+0x2d/0x70
[<ffffffff81003511>] ret_from_fork_asm+0x11/0x20
unreferenced object 0xffff88810926cab8 (size 192):
comm "kunit_try_catch", pid 1860, jiffies 4294685817 (age 976.416s)
hex dump (first 32 bytes):
00 00 50 40 02 00 00 00 00 00 00 00 00 00 00 00 ..P@............
00 00 00 00 00 00 00 00 b8 ca 26 09 81 88 ff ff ..........&.....
backtrace:
[<ffffffff81a1ff11>] __d_alloc+0x31/0x8a0
[<ffffffff81a2910e>] d_alloc_pseudo+0xe/0x50
[<ffffffff819d549e>] alloc_file_pseudo+0xce/0x210
[<ffffffff83978582>] sock_alloc_file+0x42/0x1b0
[<ffffffffa02093fb>] 0xffffffffa02093fb
[<ffffffff829cf03a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
[<ffffffff81236fc6>] kthread+0x2b6/0x380
[<ffffffff81096afd>] ret_from_fork+0x2d/0x70
[<ffffffff81003511>] ret_from_fork_asm+0x11/0x20
unreferenced object 0xffff88810a240040 (size 224):
comm "kunit_try_catch", pid 1860, jiffies 4294685817 (age 976.416s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 03 00 2e 08 01 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff819d4b90>] alloc_empty_file+0x50/0x160
[<ffffffff819d4cf9>] alloc_file+0x59/0x730
[<ffffffff819d5524>] alloc_file_pseudo+0x154/0x210
[<ffffffff83978582>] sock_alloc_file+0x42/0x1b0
[<ffffffffa02093fb>] 0xffffffffa02093fb
[<ffffffff829cf03a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
[<ffffffff81236fc6>] kthread+0x2b6/0x380
[<ffffffff81096afd>] ret_from_fork+0x2d/0x70
[<ffffffff81003511>] ret_from_fork_asm+0x11/0x20
unreferenced object 0xffff888109166440 (size 768):
comm "kunit_try_catch", pid 1862, jiffies 4294685819 (age 976.489s)
hex dump (first 32 bytes):
01 00 00 00 01 00 5a 5a 20 00 00 00 00 00 00 00 ......ZZ .......
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff8397993f>] sock_alloc_inode+0x1f/0x1b0
[<ffffffff81a2cb5b>] alloc_inode+0x5b/0x1a0
[<ffffffff81a32bed>] new_inode_pseudo+0xd/0x70
[<ffffffff8397889c>] sock_alloc+0x3c/0x260
[<ffffffff83979b46>] __sock_create+0x66/0x3d0
[<ffffffffa02097c1>] 0xffffffffa02097c1
[<ffffffff829cf03a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
[<ffffffff81236fc6>] kthread+0x2b6/0x380
[<ffffffff81096afd>] ret_from_fork+0x2d/0x70
[<ffffffff81003511>] ret_from_fork_asm+0x11/0x20
unreferenced object 0xffff88810926c398 (size 192):
comm "kunit_try_catch", pid 1862, jiffies 4294685819 (age 976.489s)
hex dump (first 32 bytes):
00 00 50 40 02 00 00 00 00 00 00 00 00 00 00 00 ..P@............
00 00 00 00 00 00 00 00 98 c3 26 09 81 88 ff ff ..........&.....
backtrace:
[<ffffffff81a1ff11>] __d_alloc+0x31/0x8a0
[<ffffffff81a2910e>] d_alloc_pseudo+0xe/0x50
[<ffffffff819d549e>] alloc_file_pseudo+0xce/0x210
[<ffffffff83978582>] sock_alloc_file+0x42/0x1b0
[<ffffffffa02097da>] 0xffffffffa02097da
[<ffffffff829cf03a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
[<ffffffff81236fc6>] kthread+0x2b6/0x380
[<ffffffff81096afd>] ret_from_fork+0x2d/0x70
[<ffffffff81003511>] ret_from_fork_asm+0x11/0x20
unreferenced object 0xffff888107e0b8c0 (size 224):
comm "kunit_try_catch", pid 1862, jiffies 4294685819 (age 976.489s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 03 00 2e 08 01 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff819d4b90>] alloc_empty_file+0x50/0x160
[<ffffffff819d4cf9>] alloc_file+0x59/0x730
[<ffffffff819d5524>] alloc_file_pseudo+0x154/0x210
[<ffffffff83978582>] sock_alloc_file+0x42/0x1b0
[<ffffffffa02097da>] 0xffffffffa02097da
[<ffffffff829cf03a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
[<ffffffff81236fc6>] kthread+0x2b6/0x380
[<ffffffff81096afd>] ret_from_fork+0x2d/0x70
[<ffffffff81003511>] ret_from_fork_asm+0x11/0x20
unreferenced object 0xffff888109164440 (size 768):
comm "kunit_try_catch", pid 1864, jiffies 4294685821 (age 976.487s)
hex dump (first 32 bytes):
01 00 00 00 01 00 5a 5a 20 00 00 00 00 00 00 00 ......ZZ .......
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff8397993f>] sock_alloc_inode+0x1f/0x1b0
[<ffffffff81a2cb5b>] alloc_inode+0x5b/0x1a0
[<ffffffff81a32bed>] new_inode_pseudo+0xd/0x70
[<ffffffff8397889c>] sock_alloc+0x3c/0x260
[<ffffffff83979b46>] __sock_create+0x66/0x3d0
[<ffffffffa020824e>] 0xffffffffa020824e
[<ffffffff829cf03a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
[<ffffffff81236fc6>] kthread+0x2b6/0x380
[<ffffffff81096afd>] ret_from_fork+0x2d/0x70
[<ffffffff81003511>] ret_from_fork_asm+0x11/0x20
unreferenced object 0xffff88810f4cf698 (size 192):
comm "kunit_try_catch", pid 1864, jiffies 4294685821 (age 976.501s)
hex dump (first 32 bytes):
00 00 50 40 02 00 00 00 00 00 00 00 00 00 00 00 ..P@............
00 00 00 00 00 00 00 00 98 f6 4c 0f 81 88 ff ff ..........L.....
backtrace:
[<ffffffff81a1ff11>] __d_alloc+0x31/0x8a0
[<ffffffff81a2910e>] d_alloc_pseudo+0xe/0x50
[<ffffffff819d549e>] alloc_file_pseudo+0xce/0x210
[<ffffffff83978582>] sock_alloc_file+0x42/0x1b0
[<ffffffffa0208267>] 0xffffffffa0208267
[<ffffffff829cf03a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
[<ffffffff81236fc6>] kthread+0x2b6/0x380
[<ffffffff81096afd>] ret_from_fork+0x2d/0x70
[<ffffffff81003511>] ret_from_fork_asm+0x11/0x20
unreferenced object 0xffff888107e0b000 (size 224):
comm "kunit_try_catch", pid 1864, jiffies 4294685821 (age 976.501s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 03 00 2e 08 01 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff819d4b90>] alloc_empty_file+0x50/0x160
[<ffffffff819d4cf9>] alloc_file+0x59/0x730
[<ffffffff819d5524>] alloc_file_pseudo+0x154/0x210
[<ffffffff83978582>] sock_alloc_file+0x42/0x1b0
[<ffffffffa0208267>] 0xffffffffa0208267
[<ffffffff829cf03a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
[<ffffffff81236fc6>] kthread+0x2b6/0x380
[<ffffffff81096afd>] ret_from_fork+0x2d/0x70
[<ffffffff81003511>] ret_from_fork_asm+0x11/0x20
Fixes: 88232ec1ec
("net/handshake: Add Kunit tests for the handshake consumer API")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
538 lines
13 KiB
C
538 lines
13 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (c) 2023 Oracle and/or its affiliates.
|
|
*
|
|
* KUnit test of the handshake upcall mechanism.
|
|
*/
|
|
|
|
#include <kunit/test.h>
|
|
#include <kunit/visibility.h>
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <net/sock.h>
|
|
#include <net/genetlink.h>
|
|
#include <net/netns/generic.h>
|
|
|
|
#include <uapi/linux/handshake.h>
|
|
#include "handshake.h"
|
|
|
|
MODULE_IMPORT_NS(EXPORTED_FOR_KUNIT_TESTING);
|
|
|
|
static int test_accept_func(struct handshake_req *req, struct genl_info *info,
|
|
int fd)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static void test_done_func(struct handshake_req *req, unsigned int status,
|
|
struct genl_info *info)
|
|
{
|
|
}
|
|
|
|
struct handshake_req_alloc_test_param {
|
|
const char *desc;
|
|
struct handshake_proto *proto;
|
|
gfp_t gfp;
|
|
bool expect_success;
|
|
};
|
|
|
|
static struct handshake_proto handshake_req_alloc_proto_2 = {
|
|
.hp_handler_class = HANDSHAKE_HANDLER_CLASS_NONE,
|
|
};
|
|
|
|
static struct handshake_proto handshake_req_alloc_proto_3 = {
|
|
.hp_handler_class = HANDSHAKE_HANDLER_CLASS_MAX,
|
|
};
|
|
|
|
static struct handshake_proto handshake_req_alloc_proto_4 = {
|
|
.hp_handler_class = HANDSHAKE_HANDLER_CLASS_TLSHD,
|
|
};
|
|
|
|
static struct handshake_proto handshake_req_alloc_proto_5 = {
|
|
.hp_handler_class = HANDSHAKE_HANDLER_CLASS_TLSHD,
|
|
.hp_accept = test_accept_func,
|
|
};
|
|
|
|
static struct handshake_proto handshake_req_alloc_proto_6 = {
|
|
.hp_handler_class = HANDSHAKE_HANDLER_CLASS_TLSHD,
|
|
.hp_privsize = UINT_MAX,
|
|
.hp_accept = test_accept_func,
|
|
.hp_done = test_done_func,
|
|
};
|
|
|
|
static struct handshake_proto handshake_req_alloc_proto_good = {
|
|
.hp_handler_class = HANDSHAKE_HANDLER_CLASS_TLSHD,
|
|
.hp_accept = test_accept_func,
|
|
.hp_done = test_done_func,
|
|
};
|
|
|
|
static const
|
|
struct handshake_req_alloc_test_param handshake_req_alloc_params[] = {
|
|
{
|
|
.desc = "handshake_req_alloc NULL proto",
|
|
.proto = NULL,
|
|
.gfp = GFP_KERNEL,
|
|
.expect_success = false,
|
|
},
|
|
{
|
|
.desc = "handshake_req_alloc CLASS_NONE",
|
|
.proto = &handshake_req_alloc_proto_2,
|
|
.gfp = GFP_KERNEL,
|
|
.expect_success = false,
|
|
},
|
|
{
|
|
.desc = "handshake_req_alloc CLASS_MAX",
|
|
.proto = &handshake_req_alloc_proto_3,
|
|
.gfp = GFP_KERNEL,
|
|
.expect_success = false,
|
|
},
|
|
{
|
|
.desc = "handshake_req_alloc no callbacks",
|
|
.proto = &handshake_req_alloc_proto_4,
|
|
.gfp = GFP_KERNEL,
|
|
.expect_success = false,
|
|
},
|
|
{
|
|
.desc = "handshake_req_alloc no done callback",
|
|
.proto = &handshake_req_alloc_proto_5,
|
|
.gfp = GFP_KERNEL,
|
|
.expect_success = false,
|
|
},
|
|
{
|
|
.desc = "handshake_req_alloc excessive privsize",
|
|
.proto = &handshake_req_alloc_proto_6,
|
|
.gfp = GFP_KERNEL | __GFP_NOWARN,
|
|
.expect_success = false,
|
|
},
|
|
{
|
|
.desc = "handshake_req_alloc all good",
|
|
.proto = &handshake_req_alloc_proto_good,
|
|
.gfp = GFP_KERNEL,
|
|
.expect_success = true,
|
|
},
|
|
};
|
|
|
|
static void
|
|
handshake_req_alloc_get_desc(const struct handshake_req_alloc_test_param *param,
|
|
char *desc)
|
|
{
|
|
strscpy(desc, param->desc, KUNIT_PARAM_DESC_SIZE);
|
|
}
|
|
|
|
/* Creates the function handshake_req_alloc_gen_params */
|
|
KUNIT_ARRAY_PARAM(handshake_req_alloc, handshake_req_alloc_params,
|
|
handshake_req_alloc_get_desc);
|
|
|
|
static void handshake_req_alloc_case(struct kunit *test)
|
|
{
|
|
const struct handshake_req_alloc_test_param *param = test->param_value;
|
|
struct handshake_req *result;
|
|
|
|
/* Arrange */
|
|
|
|
/* Act */
|
|
result = handshake_req_alloc(param->proto, param->gfp);
|
|
|
|
/* Assert */
|
|
if (param->expect_success)
|
|
KUNIT_EXPECT_NOT_NULL(test, result);
|
|
else
|
|
KUNIT_EXPECT_NULL(test, result);
|
|
|
|
kfree(result);
|
|
}
|
|
|
|
static void handshake_req_submit_test1(struct kunit *test)
|
|
{
|
|
struct socket *sock;
|
|
int err, result;
|
|
|
|
/* Arrange */
|
|
err = __sock_create(&init_net, PF_INET, SOCK_STREAM, IPPROTO_TCP,
|
|
&sock, 1);
|
|
KUNIT_ASSERT_EQ(test, err, 0);
|
|
|
|
/* Act */
|
|
result = handshake_req_submit(sock, NULL, GFP_KERNEL);
|
|
|
|
/* Assert */
|
|
KUNIT_EXPECT_EQ(test, result, -EINVAL);
|
|
|
|
sock_release(sock);
|
|
}
|
|
|
|
static void handshake_req_submit_test2(struct kunit *test)
|
|
{
|
|
struct handshake_req *req;
|
|
int result;
|
|
|
|
/* Arrange */
|
|
req = handshake_req_alloc(&handshake_req_alloc_proto_good, GFP_KERNEL);
|
|
KUNIT_ASSERT_NOT_NULL(test, req);
|
|
|
|
/* Act */
|
|
result = handshake_req_submit(NULL, req, GFP_KERNEL);
|
|
|
|
/* Assert */
|
|
KUNIT_EXPECT_EQ(test, result, -EINVAL);
|
|
|
|
/* handshake_req_submit() destroys @req on error */
|
|
}
|
|
|
|
static void handshake_req_submit_test3(struct kunit *test)
|
|
{
|
|
struct handshake_req *req;
|
|
struct socket *sock;
|
|
int err, result;
|
|
|
|
/* Arrange */
|
|
req = handshake_req_alloc(&handshake_req_alloc_proto_good, GFP_KERNEL);
|
|
KUNIT_ASSERT_NOT_NULL(test, req);
|
|
|
|
err = __sock_create(&init_net, PF_INET, SOCK_STREAM, IPPROTO_TCP,
|
|
&sock, 1);
|
|
KUNIT_ASSERT_EQ(test, err, 0);
|
|
sock->file = NULL;
|
|
|
|
/* Act */
|
|
result = handshake_req_submit(sock, req, GFP_KERNEL);
|
|
|
|
/* Assert */
|
|
KUNIT_EXPECT_EQ(test, result, -EINVAL);
|
|
|
|
/* handshake_req_submit() destroys @req on error */
|
|
sock_release(sock);
|
|
}
|
|
|
|
static void handshake_req_submit_test4(struct kunit *test)
|
|
{
|
|
struct handshake_req *req, *result;
|
|
struct socket *sock;
|
|
struct file *filp;
|
|
int err;
|
|
|
|
/* Arrange */
|
|
req = handshake_req_alloc(&handshake_req_alloc_proto_good, GFP_KERNEL);
|
|
KUNIT_ASSERT_NOT_NULL(test, req);
|
|
|
|
err = __sock_create(&init_net, PF_INET, SOCK_STREAM, IPPROTO_TCP,
|
|
&sock, 1);
|
|
KUNIT_ASSERT_EQ(test, err, 0);
|
|
filp = sock_alloc_file(sock, O_NONBLOCK, NULL);
|
|
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, filp);
|
|
KUNIT_ASSERT_NOT_NULL(test, sock->sk);
|
|
sock->file = filp;
|
|
|
|
err = handshake_req_submit(sock, req, GFP_KERNEL);
|
|
KUNIT_ASSERT_EQ(test, err, 0);
|
|
|
|
/* Act */
|
|
result = handshake_req_hash_lookup(sock->sk);
|
|
|
|
/* Assert */
|
|
KUNIT_EXPECT_NOT_NULL(test, result);
|
|
KUNIT_EXPECT_PTR_EQ(test, req, result);
|
|
|
|
handshake_req_cancel(sock->sk);
|
|
fput(filp);
|
|
}
|
|
|
|
static void handshake_req_submit_test5(struct kunit *test)
|
|
{
|
|
struct handshake_req *req;
|
|
struct handshake_net *hn;
|
|
struct socket *sock;
|
|
struct file *filp;
|
|
struct net *net;
|
|
int saved, err;
|
|
|
|
/* Arrange */
|
|
req = handshake_req_alloc(&handshake_req_alloc_proto_good, GFP_KERNEL);
|
|
KUNIT_ASSERT_NOT_NULL(test, req);
|
|
|
|
err = __sock_create(&init_net, PF_INET, SOCK_STREAM, IPPROTO_TCP,
|
|
&sock, 1);
|
|
KUNIT_ASSERT_EQ(test, err, 0);
|
|
filp = sock_alloc_file(sock, O_NONBLOCK, NULL);
|
|
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, filp);
|
|
KUNIT_ASSERT_NOT_NULL(test, sock->sk);
|
|
sock->file = filp;
|
|
|
|
net = sock_net(sock->sk);
|
|
hn = handshake_pernet(net);
|
|
KUNIT_ASSERT_NOT_NULL(test, hn);
|
|
|
|
saved = hn->hn_pending;
|
|
hn->hn_pending = hn->hn_pending_max + 1;
|
|
|
|
/* Act */
|
|
err = handshake_req_submit(sock, req, GFP_KERNEL);
|
|
|
|
/* Assert */
|
|
KUNIT_EXPECT_EQ(test, err, -EAGAIN);
|
|
|
|
fput(filp);
|
|
hn->hn_pending = saved;
|
|
}
|
|
|
|
static void handshake_req_submit_test6(struct kunit *test)
|
|
{
|
|
struct handshake_req *req1, *req2;
|
|
struct socket *sock;
|
|
struct file *filp;
|
|
int err;
|
|
|
|
/* Arrange */
|
|
req1 = handshake_req_alloc(&handshake_req_alloc_proto_good, GFP_KERNEL);
|
|
KUNIT_ASSERT_NOT_NULL(test, req1);
|
|
req2 = handshake_req_alloc(&handshake_req_alloc_proto_good, GFP_KERNEL);
|
|
KUNIT_ASSERT_NOT_NULL(test, req2);
|
|
|
|
err = __sock_create(&init_net, PF_INET, SOCK_STREAM, IPPROTO_TCP,
|
|
&sock, 1);
|
|
KUNIT_ASSERT_EQ(test, err, 0);
|
|
filp = sock_alloc_file(sock, O_NONBLOCK, NULL);
|
|
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, filp);
|
|
KUNIT_ASSERT_NOT_NULL(test, sock->sk);
|
|
sock->file = filp;
|
|
|
|
/* Act */
|
|
err = handshake_req_submit(sock, req1, GFP_KERNEL);
|
|
KUNIT_ASSERT_EQ(test, err, 0);
|
|
err = handshake_req_submit(sock, req2, GFP_KERNEL);
|
|
|
|
/* Assert */
|
|
KUNIT_EXPECT_EQ(test, err, -EBUSY);
|
|
|
|
handshake_req_cancel(sock->sk);
|
|
fput(filp);
|
|
}
|
|
|
|
static void handshake_req_cancel_test1(struct kunit *test)
|
|
{
|
|
struct handshake_req *req;
|
|
struct socket *sock;
|
|
struct file *filp;
|
|
bool result;
|
|
int err;
|
|
|
|
/* Arrange */
|
|
req = handshake_req_alloc(&handshake_req_alloc_proto_good, GFP_KERNEL);
|
|
KUNIT_ASSERT_NOT_NULL(test, req);
|
|
|
|
err = __sock_create(&init_net, PF_INET, SOCK_STREAM, IPPROTO_TCP,
|
|
&sock, 1);
|
|
KUNIT_ASSERT_EQ(test, err, 0);
|
|
|
|
filp = sock_alloc_file(sock, O_NONBLOCK, NULL);
|
|
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, filp);
|
|
sock->file = filp;
|
|
|
|
err = handshake_req_submit(sock, req, GFP_KERNEL);
|
|
KUNIT_ASSERT_EQ(test, err, 0);
|
|
|
|
/* NB: handshake_req hasn't been accepted */
|
|
|
|
/* Act */
|
|
result = handshake_req_cancel(sock->sk);
|
|
|
|
/* Assert */
|
|
KUNIT_EXPECT_TRUE(test, result);
|
|
|
|
fput(filp);
|
|
}
|
|
|
|
static void handshake_req_cancel_test2(struct kunit *test)
|
|
{
|
|
struct handshake_req *req, *next;
|
|
struct handshake_net *hn;
|
|
struct socket *sock;
|
|
struct file *filp;
|
|
struct net *net;
|
|
bool result;
|
|
int err;
|
|
|
|
/* Arrange */
|
|
req = handshake_req_alloc(&handshake_req_alloc_proto_good, GFP_KERNEL);
|
|
KUNIT_ASSERT_NOT_NULL(test, req);
|
|
|
|
err = __sock_create(&init_net, PF_INET, SOCK_STREAM, IPPROTO_TCP,
|
|
&sock, 1);
|
|
KUNIT_ASSERT_EQ(test, err, 0);
|
|
|
|
filp = sock_alloc_file(sock, O_NONBLOCK, NULL);
|
|
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, filp);
|
|
sock->file = filp;
|
|
|
|
err = handshake_req_submit(sock, req, GFP_KERNEL);
|
|
KUNIT_ASSERT_EQ(test, err, 0);
|
|
|
|
net = sock_net(sock->sk);
|
|
hn = handshake_pernet(net);
|
|
KUNIT_ASSERT_NOT_NULL(test, hn);
|
|
|
|
/* Pretend to accept this request */
|
|
next = handshake_req_next(hn, HANDSHAKE_HANDLER_CLASS_TLSHD);
|
|
KUNIT_ASSERT_PTR_EQ(test, req, next);
|
|
|
|
/* Act */
|
|
result = handshake_req_cancel(sock->sk);
|
|
|
|
/* Assert */
|
|
KUNIT_EXPECT_TRUE(test, result);
|
|
|
|
fput(filp);
|
|
}
|
|
|
|
static void handshake_req_cancel_test3(struct kunit *test)
|
|
{
|
|
struct handshake_req *req, *next;
|
|
struct handshake_net *hn;
|
|
struct socket *sock;
|
|
struct file *filp;
|
|
struct net *net;
|
|
bool result;
|
|
int err;
|
|
|
|
/* Arrange */
|
|
req = handshake_req_alloc(&handshake_req_alloc_proto_good, GFP_KERNEL);
|
|
KUNIT_ASSERT_NOT_NULL(test, req);
|
|
|
|
err = __sock_create(&init_net, PF_INET, SOCK_STREAM, IPPROTO_TCP,
|
|
&sock, 1);
|
|
KUNIT_ASSERT_EQ(test, err, 0);
|
|
|
|
filp = sock_alloc_file(sock, O_NONBLOCK, NULL);
|
|
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, filp);
|
|
sock->file = filp;
|
|
|
|
err = handshake_req_submit(sock, req, GFP_KERNEL);
|
|
KUNIT_ASSERT_EQ(test, err, 0);
|
|
|
|
net = sock_net(sock->sk);
|
|
hn = handshake_pernet(net);
|
|
KUNIT_ASSERT_NOT_NULL(test, hn);
|
|
|
|
/* Pretend to accept this request */
|
|
next = handshake_req_next(hn, HANDSHAKE_HANDLER_CLASS_TLSHD);
|
|
KUNIT_ASSERT_PTR_EQ(test, req, next);
|
|
|
|
/* Pretend to complete this request */
|
|
handshake_complete(next, -ETIMEDOUT, NULL);
|
|
|
|
/* Act */
|
|
result = handshake_req_cancel(sock->sk);
|
|
|
|
/* Assert */
|
|
KUNIT_EXPECT_FALSE(test, result);
|
|
|
|
fput(filp);
|
|
}
|
|
|
|
static struct handshake_req *handshake_req_destroy_test;
|
|
|
|
static void test_destroy_func(struct handshake_req *req)
|
|
{
|
|
handshake_req_destroy_test = req;
|
|
}
|
|
|
|
static struct handshake_proto handshake_req_alloc_proto_destroy = {
|
|
.hp_handler_class = HANDSHAKE_HANDLER_CLASS_TLSHD,
|
|
.hp_accept = test_accept_func,
|
|
.hp_done = test_done_func,
|
|
.hp_destroy = test_destroy_func,
|
|
};
|
|
|
|
static void handshake_req_destroy_test1(struct kunit *test)
|
|
{
|
|
struct handshake_req *req;
|
|
struct socket *sock;
|
|
struct file *filp;
|
|
int err;
|
|
|
|
/* Arrange */
|
|
handshake_req_destroy_test = NULL;
|
|
|
|
req = handshake_req_alloc(&handshake_req_alloc_proto_destroy, GFP_KERNEL);
|
|
KUNIT_ASSERT_NOT_NULL(test, req);
|
|
|
|
err = __sock_create(&init_net, PF_INET, SOCK_STREAM, IPPROTO_TCP,
|
|
&sock, 1);
|
|
KUNIT_ASSERT_EQ(test, err, 0);
|
|
|
|
filp = sock_alloc_file(sock, O_NONBLOCK, NULL);
|
|
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, filp);
|
|
sock->file = filp;
|
|
|
|
err = handshake_req_submit(sock, req, GFP_KERNEL);
|
|
KUNIT_ASSERT_EQ(test, err, 0);
|
|
|
|
handshake_req_cancel(sock->sk);
|
|
|
|
/* Act */
|
|
fput(filp);
|
|
|
|
/* Assert */
|
|
KUNIT_EXPECT_PTR_EQ(test, handshake_req_destroy_test, req);
|
|
}
|
|
|
|
static struct kunit_case handshake_api_test_cases[] = {
|
|
{
|
|
.name = "req_alloc API fuzzing",
|
|
.run_case = handshake_req_alloc_case,
|
|
.generate_params = handshake_req_alloc_gen_params,
|
|
},
|
|
{
|
|
.name = "req_submit NULL req arg",
|
|
.run_case = handshake_req_submit_test1,
|
|
},
|
|
{
|
|
.name = "req_submit NULL sock arg",
|
|
.run_case = handshake_req_submit_test2,
|
|
},
|
|
{
|
|
.name = "req_submit NULL sock->file",
|
|
.run_case = handshake_req_submit_test3,
|
|
},
|
|
{
|
|
.name = "req_lookup works",
|
|
.run_case = handshake_req_submit_test4,
|
|
},
|
|
{
|
|
.name = "req_submit max pending",
|
|
.run_case = handshake_req_submit_test5,
|
|
},
|
|
{
|
|
.name = "req_submit multiple",
|
|
.run_case = handshake_req_submit_test6,
|
|
},
|
|
{
|
|
.name = "req_cancel before accept",
|
|
.run_case = handshake_req_cancel_test1,
|
|
},
|
|
{
|
|
.name = "req_cancel after accept",
|
|
.run_case = handshake_req_cancel_test2,
|
|
},
|
|
{
|
|
.name = "req_cancel after done",
|
|
.run_case = handshake_req_cancel_test3,
|
|
},
|
|
{
|
|
.name = "req_destroy works",
|
|
.run_case = handshake_req_destroy_test1,
|
|
},
|
|
{}
|
|
};
|
|
|
|
static struct kunit_suite handshake_api_suite = {
|
|
.name = "Handshake API tests",
|
|
.test_cases = handshake_api_test_cases,
|
|
};
|
|
|
|
kunit_test_suites(&handshake_api_suite);
|
|
|
|
MODULE_DESCRIPTION("Test handshake upcall API functions");
|
|
MODULE_LICENSE("GPL");
|