iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
77da9481248c717f2538587dbdabb297f513ebc5
linux/fs/ocfs2
History
Jia-Ju Bai 22731e226b fs: ocfs2: fix a possible null-pointer dereference in ocfs2_info_scan_inode_alloc() 
[ Upstream commit 2abb7d3b12 ]

In ocfs2_info_scan_inode_alloc(), there is an if statement on line 283
to check whether inode_alloc is NULL:

    if (inode_alloc)

When inode_alloc is NULL, it is used on line 287:

    ocfs2_inode_lock(inode_alloc, &bh, 0);
        ocfs2_inode_lock_full_nested(inode, ...)
            struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);

Thus, a possible null-pointer dereference may occur.

To fix this bug, inode_alloc is checked on line 286.

This bug is found by a static analysis tool STCheck written by us.

Link: http://lkml.kernel.org/r/20190726033717.32359-1-baijiaju1990@gmail.com
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Cc: Mark Fasheh <mark@fasheh.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Cc: Changwei Ge <gechangwei@live.cn>
Cc: Gang He <ghe@suse.com>
Cc: Jun Piao <piaojun@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2019-11-06 12:43:15 +01:00
..
cluster
ocfs2: fix a panic problem caused by o2cb_ctl
2019-04-05 22:31:27 +02:00
dlm
ocfs2: wait for recovering done after direct unlock request
2019-10-07 18:55:14 +02:00
dlmfs
ocfs2: improve ocfs2 Makefile
2019-02-12 19:46:09 +01:00
acl.c
ocfs2/acl: use 'ip_xattr_sem' to protect getting extended attribute
2018-04-26 11:02:14 +02:00
acl.h
ocfs2: make ocfs2_set_acl() static
2017-09-06 17:27:24 -07:00
alloc.c
ocfs2: fstrim: Fix start offset of first cluster group during fstrim
2017-11-03 07:39:19 -07:00
alloc.h
ocfs2: clean up some dead code
2017-09-06 17:27:24 -07:00
aops.c
fs: ocfs2: fix a possible null-pointer dereference in ocfs2_write_end_nolock()
2019-11-06 12:43:15 +01:00
aops.h
ocfs2: clean up unused 'page' parameter in ocfs2_write_end_nolock()
2016-12-12 18:55:06 -08:00
blockcheck.c
…
blockcheck.h
…
buffer_head_io.c
ocfs2: don't clear bh uptodate for block read
2019-02-12 19:46:09 +01:00
buffer_head_io.h
…
dcache.c
fs/ocfs2: fix race in ocfs2_dentry_attach_lock()
2019-06-19 08:20:54 +02:00
dcache.h
…
dir.c
ocfs2: fix a misuse a of brelse after failing ocfs2_check_dir_entry
2018-11-21 09:24:09 +01:00
dir.h
VFS: normal filesystems (and lustre): d_inode() annotations
2015-04-15 15:06:57 -04:00
dlmglue.c
ocfs2: try a blocking lock before return AOP_TRUNCATED_PAGE
2018-02-22 15:42:16 +01:00
dlmglue.h
ocfs2/dlmglue: prepare tracking logic to avoid recursive cluster lock
2017-02-22 16:41:27 -08:00
export.c
ocfs2: fix ocfs2 read inode data panic in ocfs2_iget
2019-05-21 18:50:17 +02:00
export.h
…
extent_map.c
ocfs2: neaten do_error, ocfs2_error and ocfs2_abort
2015-09-04 16:54:41 -07:00
extent_map.h
…
file.c
ocfs2: should wait dio before inode lock in ocfs2_setattr()
2017-11-24 08:37:04 +01:00
file.h
statx: Add a system call to make enhanced file info available
2017-03-02 20:51:15 -05:00
filecheck.c
ocfs2: sysfile interfaces for online file check
2016-03-22 15:36:02 -07:00
filecheck.h
ocfs2: sysfile interfaces for online file check
2016-03-22 15:36:02 -07:00
heartbeat.c
…
heartbeat.h
…
inode.c
ocfs2: fix a static checker warning
2017-07-06 16:24:30 -07:00
inode.h
ocfs2: convert inode refcount test to a helper
2016-12-10 12:39:45 -08:00
ioctl.c
fs: ocfs2: fix a possible null-pointer dereference in ocfs2_info_scan_inode_alloc()
2019-11-06 12:43:15 +01:00
ioctl.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
journal.c
ocfs2: fix panic due to ocfs2_wq is null
2019-10-29 09:17:00 +01:00
journal.h
jbd2: add support for avoiding data writes during transaction commits
2016-04-24 00:56:07 -04:00
Kconfig
…
localalloc.c
ocfs2: fix panic due to ocfs2_wq is null
2019-10-29 09:17:00 +01:00
localalloc.h
…
locks.c
ocfs2: fix flock panic issue
2015-12-29 17:45:49 -08:00
locks.h
…
Makefile
ocfs2: improve ocfs2 Makefile
2019-02-12 19:46:09 +01:00
mmap.c
mm, fs: reduce fault, page_mkwrite, and pfn_mkwrite to take only vmf
2017-02-24 17:46:54 -08:00
mmap.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
move_extents.c
ocfs2: fix deadlock caused by ocfs2_defrag_extent()
2018-12-17 09:28:54 +01:00
move_extents.h
…
namei.c
ocfs2: replace CURRENT_TIME macro
2016-12-12 18:55:06 -08:00
namei.h
ocfs2: do not include dio entry in case of orphan scan
2015-11-05 19:34:48 -08:00
ocfs1_fs_compat.h
…
ocfs2_fs.h
ocfs2: use magic.h
2017-07-06 16:24:30 -07:00
ocfs2_ioctl.h
…
ocfs2_lockid.h
…
ocfs2_lockingver.h
…
ocfs2_trace.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
ocfs2.h
ocfs2: clean up some dead code
2017-09-06 17:27:24 -07:00
quota_global.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
quota_local.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
quota.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
refcounttree.c
ocfs2: fix inode bh swapping mixup in ocfs2_reflink_inodes_lock
2019-04-03 06:25:17 +02:00
refcounttree.h
ocfs2: implement the VFS clone_range, copy_range, and dedupe_range features
2016-12-10 12:39:45 -08:00
reservations.c
ocfs2: make resv_lock spinlock static
2015-02-10 14:30:29 -08:00
reservations.h
…
resize.c
ocfs2: solve a problem of crossing the boundary in updating backups
2016-03-25 16:37:42 -07:00
resize.h
…
slot_map.c
ocfs2: clean up an unneeded goto in ocfs2_put_slot()
2016-05-19 19:12:14 -07:00
slot_map.h
…
stack_o2cb.c
ocfs2: avoid a pointless delay in o2cb_cluster_check()
2015-04-14 16:48:57 -07:00
stack_user.c
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
stackglue.c
ocfs2: constify attribute_group structures
2017-07-06 16:24:30 -07:00
stackglue.h
ocfs2: fix crash caused by stale lvb with fsdlm plugin
2017-01-10 18:31:54 -08:00
suballoc.c
ocfs2: clean up some dead code
2017-09-06 17:27:24 -07:00
suballoc.h
…
super.c
ocfs2: return -EROFS to mount.ocfs2 if inode block is invalid
2018-04-26 11:02:14 +02:00
super.h
ocfs2: fix occurring deadlock by changing ocfs2_wq from global to local
2016-03-25 16:37:42 -07:00
symlink.c
vfs: remove ".readlink = generic_readlink" assignments
2016-12-09 16:45:04 +01:00
symlink.h
…
sysfile.c
…
sysfile.h
…
uptodate.c
…
uptodate.h
…
xattr.c
fs: ocfs2: fix possible null-pointer dereferences in ocfs2_xa_prepare_entry()
2019-11-06 12:43:14 +01:00
xattr.h
ocfs2: fix posix_acl_create deadlock
2016-05-12 15:52:50 -07:00