Eric Dumazet
17af6146dd
net_sched: reject silly cell_log in qdisc_get_rtab() ...
commit e4bedf48aaa5552bc1f49703abd17606e7e6e82a upstream
iproute2 probably never goes beyond 8 for the cell exponent,
but stick to the max shift exponent for signed 32bit.
UBSAN reported:
UBSAN: shift-out-of-bounds in net/sched/sch_api.c:389:22
shift exponent 130 is too large for 32-bit type 'int'
CPU: 1 PID: 8450 Comm: syz-executor586 Not tainted 5.11.0-rc3-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:79 [inline]
dump_stack+0x183/0x22e lib/dump_stack.c:120
ubsan_epilogue lib/ubsan.c:148 [inline]
__ubsan_handle_shift_out_of_bounds+0x432/0x4d0 lib/ubsan.c:395
__detect_linklayer+0x2a9/0x330 net/sched/sch_api.c:389
qdisc_get_rtab+0x2b5/0x410 net/sched/sch_api.c:435
cbq_init+0x28f/0x12c0 net/sched/sch_cbq.c:1180
qdisc_create+0x801/0x1470 net/sched/sch_api.c:1246
tc_modify_qdisc+0x9e3/0x1fc0 net/sched/sch_api.c:1662
rtnetlink_rcv_msg+0xb1d/0xe60 net/core/rtnetlink.c:5564
netlink_rcv_skb+0x1f0/0x460 net/netlink/af_netlink.c:2494
netlink_unicast_kernel net/netlink/af_netlink.c:1304 [inline]
netlink_unicast+0x7de/0x9b0 net/netlink/af_netlink.c:1330
netlink_sendmsg+0xaa6/0xe90 net/netlink/af_netlink.c:1919
sock_sendmsg_nosec net/socket.c:652 [inline]
sock_sendmsg net/socket.c:672 [inline]
____sys_sendmsg+0x5a2/0x900 net/socket.c:2345
___sys_sendmsg net/socket.c:2399 [inline]
__sys_sendmsg+0x319/0x400 net/socket.c:2432
do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
entry_SYSCALL_64_after_hwframe+0x44/0xa9
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Acked-by: Cong Wang <cong.wang@bytedance.com>
Link: https://lore.kernel.org/r/20210114160637.1660597-1-eric.dumazet@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
[sudip: adjust context]
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-02-10 09:09:23 +01:00
2020-01-29 10:24:22 +01:00
2020-11-10 10:23:54 +01:00
2020-01-12 11:24:27 +01:00
2019-12-21 10:41:45 +01:00
2020-10-01 20:40:12 +02:00
2020-07-31 16:44:06 +02:00
2020-12-02 08:31:27 +01:00
2020-12-29 13:44:53 +01:00
2020-12-29 13:44:48 +01:00
2019-05-08 07:19:07 +02:00
2019-07-10 09:55:33 +02:00
2020-11-10 10:23:59 +01:00
2021-01-30 13:27:16 +01:00
2021-01-23 15:38:18 +01:00
2020-05-20 08:15:30 +02:00
2019-12-05 15:35:12 +01:00
2018-07-22 14:27:39 +02:00
2020-04-13 10:32:53 +02:00
2020-01-12 11:24:19 +01:00
2020-10-01 20:40:01 +02:00
2020-03-20 09:07:39 +01:00
2021-01-30 13:27:15 +01:00
2021-01-30 13:27:16 +01:00
2017-05-25 15:44:41 +02:00
2018-09-15 09:43:01 +02:00
2020-12-11 13:37:56 +01:00
2019-04-17 08:36:44 +02:00
2020-10-01 20:39:59 +02:00
2021-01-09 13:35:49 +01:00
2016-09-10 23:12:53 -07:00
2019-06-22 08:17:22 +02:00
2020-07-22 09:10:47 +02:00
2021-02-03 23:19:51 +01:00
2020-10-01 20:40:18 +02:00
2020-05-20 08:15:30 +02:00
2021-01-12 19:49:01 +01:00
2021-02-03 23:19:51 +01:00
2020-11-24 13:02:56 +01:00
2020-07-22 09:10:48 +02:00
2020-05-02 17:23:08 +02:00
2021-02-03 23:19:52 +01:00
2020-10-14 09:48:16 +02:00
2020-10-14 09:48:13 +02:00
2019-03-23 13:19:44 +01:00
2020-06-03 08:16:29 +02:00
2020-08-21 11:01:49 +02:00
2020-01-12 11:24:23 +01:00
2020-12-11 13:37:56 +01:00
2021-01-23 15:38:19 +01:00
2021-02-10 09:09:23 +01:00
2020-11-24 13:02:58 +01:00
2018-04-29 11:32:02 +02:00
2021-01-23 15:38:18 +01:00
2016-10-19 10:58:04 -04:00
2021-01-23 15:38:19 +01:00
2020-10-01 20:40:06 +02:00
2020-11-10 10:24:03 +01:00
2021-02-03 23:19:49 +01:00
2020-12-11 13:37:57 +01:00
2021-02-03 23:19:51 +01:00
2020-08-21 11:02:08 +02:00
2020-08-21 11:02:04 +02:00
2016-10-06 09:52:23 -07:00
17af6146dd