Mathias Nyman 7895086afd xhci: fix off by one error in TRB DMA address boundary check
We need to check that a TRB is part of the current segment
before calculating its DMA address.

Previously a ring segment didn't use a full memory page, and every
new ring segment got a new memory page, so the off by one
error in checking the upper bound was never seen.

Now that we use a full memory page, 256 TRBs (4096 bytes), the off by one
didn't catch the case when a TRB was the first element of the next segment.

This is triggered if the virtual memory pages for a ring segment are
next to each in increasing order where the ring buffer wraps around and
causes errors like:

[  106.398223] xhci_hcd 0000:00:14.0: ERROR Transfer event TRB DMA ptr not part of current TD ep_index 0 comp_code 1
[  106.398230] xhci_hcd 0000:00:14.0: Looking for event-dma fffd3000 trb-start fffd4fd0 trb-end fffd5000 seg-start fffd4000 seg-end fffd4ff0

The trb-end address is one outside the end-seg address.

Cc: <stable@vger.kernel.org>
Tested-by: Arkadiusz Miśkiewicz <arekm@maven.pl>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-08-03 14:41:48 -07:00
..
2014-12-14 16:10:09 -08:00
2015-06-03 14:13:41 +09:00
2015-04-03 19:03:19 +02:00
2014-11-07 09:02:38 -08:00
2014-11-07 09:02:38 -08:00
2014-11-03 15:26:15 -08:00
2015-04-03 19:03:18 +02:00
2015-04-03 19:03:18 +02:00
2015-04-03 19:03:18 +02:00
2014-12-14 16:10:09 -08:00
2015-04-03 19:03:17 +02:00
2014-12-14 16:10:09 -08:00
2014-12-14 16:10:09 -08:00
2015-01-25 21:01:13 +08:00
2014-12-14 16:10:09 -08:00
2015-06-08 14:26:22 -07:00
2015-04-03 19:03:16 +02:00