Marek Szyprowski 7b814900b8 drm: radeon: fix common struct sg_table related issues
The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function
returns the number of the created entries in the DMA address space.
However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and
dma_unmap_sg must be called with the original number of the entries
passed to the dma_map_sg().

struct sg_table is a common structure used for describing a non-contiguous
memory buffer, used commonly in the DRM and graphics subsystems. It
consists of a scatterlist with memory pages and DMA addresses (sgl entry),
as well as the number of scatterlist entries: CPU pages (orig_nents entry)
and DMA mapped pages (nents entry).

It turned out that it was a common mistake to misuse nents and orig_nents
entries, calling DMA-mapping functions with a wrong number of entries or
ignoring the number of mapped entries returned by the dma_map_sg()
function.

To avoid such issues, lets use a common dma-mapping wrappers operating
directly on the struct sg_table objects and use scatterlist page
iterators where possible. This, almost always, hides references to the
nents and orig_nents entries, making the code robust, easier to follow
and copy/paste safe.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/371172/
Signed-off-by: Christian König <christian.koenig@amd.com>
2020-07-13 10:48:07 +02:00
..
2020-06-13 13:04:36 -07:00
2020-06-19 13:09:40 -07:00
2020-06-09 10:04:47 -07:00
2020-06-19 13:11:26 -07:00
2020-06-07 10:59:32 -07:00
2020-06-13 13:29:16 -07:00
2020-06-07 10:59:32 -07:00
2020-06-03 15:00:05 -07:00
2020-06-13 13:29:16 -07:00
2020-06-04 11:03:45 -07:00
2020-06-02 15:29:19 -07:00
2020-06-13 13:29:16 -07:00
2020-07-01 10:49:02 +02:00
2020-06-13 13:29:16 -07:00
2020-06-11 12:53:23 -07:00
2020-06-13 13:29:16 -07:00
2020-06-13 13:29:16 -07:00
2020-06-04 19:09:28 +02:00
2020-06-08 13:01:08 -07:00
2020-06-08 13:01:08 -07:00
2020-06-07 16:11:23 -07:00
2020-06-07 10:59:32 -07:00
2020-06-13 13:29:16 -07:00
2020-06-13 13:29:16 -07:00
2020-06-13 13:29:16 -07:00
2020-06-13 13:29:16 -07:00