iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net
History
Johannes Berg 7bc40aedf2 mac80211: free sta in sta_info_insert_finish() on errors 
If sta_info_insert_finish() fails, we currently keep the station
around and free it only in the caller, but there's only one such
caller and it always frees it immediately.

As syzbot found, another consequence of this split is that we can
put things that sleep only into __cleanup_single_sta() and not in
sta_info_free(), but this is the only place that requires such of
sta_info_free() now.

Change this to free the station in sta_info_insert_finish(), in
which case we can still sleep. This will also let us unify the
cleanup code later.

Cc: stable@vger.kernel.org
Fixes: dcd479e10a05 ("mac80211: always wind down STA state")
Reported-by: syzbot+32c6c38c4812d22f2f0b@syzkaller.appspotmail.com
Reported-by: syzbot+4c81fe92e372d26c4246@syzkaller.appspotmail.com
Reported-by: syzbot+6a7fe9faf0d1d61bc24a@syzkaller.appspotmail.com
Reported-by: syzbot+abed06851c5ffe010921@syzkaller.appspotmail.com
Reported-by: syzbot+b7aeb9318541a1c709f1@syzkaller.appspotmail.com
Reported-by: syzbot+d5a9416c6cafe53b5dd0@syzkaller.appspotmail.com
Link: https://lore.kernel.org/r/20201112112201.ee6b397b9453.I9c31d667a0ea2151441cc64ed6613d36c18a48e0@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2020-11-13 09:48:32 +01:00
..
6lowpan
…
9p
net: 9p: initialize sun_server.sun_path to have addr's value only when addr is valid
2020-10-12 10:05:47 +02:00
802
…
8021q
net: vlan: Fixed signedness in vlan_group_prealloc_vid()
2020-09-28 00:51:39 -07:00
appletalk
appletalk: Fix atalk_proc_init() return path
2020-08-03 15:48:32 -07:00
atm
net: atm: fix update of position index in lec_seq_next
2020-10-31 12:26:30 -07:00
ax25
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-07-25 17:49:04 -07:00
batman-adv
genetlink: move to smaller ops wherever possible
2020-10-02 19:11:11 -07:00
bluetooth
Bluetooth: Replace zero-length array with flexible-array member
2020-10-29 17:22:59 -05:00
bpf
bpf: fix raw_tp test run in preempt kernel
2020-09-30 08:34:08 -07:00
bpfilter
Revert "bpfilter: Fix build error with CONFIG_BPFILTER_UMH"
2020-10-15 12:33:24 -07:00
bridge
netfilter: ebtables: Fixes dropping of small packets in bridge nat
2020-10-20 13:54:53 +02:00
caif
caif: Remove duplicate macro SRVL_CTRL_PKT_SIZE
2020-09-05 15:57:05 -07:00
can
can: isotp: padlen(): make const array static, makes object smaller
2020-11-03 22:30:32 +01:00
ceph
libceph: clear con->out_msg on Policy::stateful_server faults
2020-10-12 15:29:27 +02:00
core
Networking fixes for 5.10-rc2.
2020-10-29 12:55:02 -07:00
dcb
net: DCB: Validate DCB_ATTR_DCB_BUFFER argument
2020-09-10 15:09:08 -07:00
dccp
inet: remove icsk_ack.blocked
2020-09-30 14:21:30 -07:00
decnet
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
dns_resolver
…
dsa
net: dsa: tag_ksz: KSZ8795 and KSZ9477 also use tail tags
2020-10-19 17:32:50 -07:00
ethernet
…
ethtool
ethtool: netlink: add missing netdev_features_change() call
2020-11-09 17:15:34 -08:00
hsr
genetlink: move to smaller ops wherever possible
2020-10-02 19:11:11 -07:00
ieee802154
genetlink: move to smaller ops wherever possible
2020-10-02 19:11:11 -07:00
ife
…
ipv4
net: Update window_clamp if SOCK_RCVBUF is set
2020-11-10 17:42:35 -08:00
ipv6
net: Update window_clamp if SOCK_RCVBUF is set
2020-11-10 17:42:35 -08:00
iucv
net/af_iucv: fix null pointer dereference on shutdown
2020-11-10 18:08:17 -08:00
kcm
net: pass a sockptr_t into ->setsockopt
2020-07-24 15:41:54 -07:00
key
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-08-02 01:02:12 -07:00
l2tp
genetlink: move to smaller ops wherever possible
2020-10-02 19:11:11 -07:00
l3mdev
net: Fix some comments
2020-08-27 07:55:59 -07:00
lapb
…
llc
net: pass a sockptr_t into ->setsockopt
2020-07-24 15:41:54 -07:00
mac80211
mac80211: free sta in sta_info_insert_finish() on errors
2020-11-13 09:48:32 +01:00
mac802154
Merge tag 'ieee802154-for-davem-2020-09-08' of git://git.kernel.org/pub/scm/linux/kernel/git/sschmidt/wpan
2020-09-08 20:12:58 -07:00
mpls
mpls: load mpls_gso after mpls_iptunnel
2020-10-20 21:16:45 -07:00
mptcp
mptcp: provide rmem[0] limit
2020-11-09 17:34:34 -08:00
ncsi
genetlink: move to smaller ops wherever possible
2020-10-02 19:11:11 -07:00
netfilter
netfilter: ipset: Update byte and packet counters regardless of whether they match
2020-10-31 11:11:11 +01:00
netlabel
netlabel: fix our progress tracking in netlbl_unlabel_staticlist()
2020-11-10 15:31:46 -08:00
netlink
netlink: export policy in extended ACK
2020-10-09 20:22:32 -07:00
netrom
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
nfc
nfc: Ensure presence of NFC_ATTR_FIRMWARE_NAME attribute in nfc_genl_fw_download()
2020-10-20 17:06:22 -07:00
nsh
…
openvswitch
net: openvswitch: silence suspicious RCU usage warning
2020-11-03 16:57:42 -08:00
packet
net/packet: Fix a comment about network_header
2020-09-19 16:40:48 -07:00
phonet
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
psample
genetlink: move to smaller ops wherever possible
2020-10-02 19:11:11 -07:00
qrtr
net: qrtr: ns: Fix the incorrect usage of rcu_read_lock()
2020-10-06 06:01:35 -07:00
rds
RDMA: Add rdma_connect_locked()
2020-10-28 09:14:49 -03:00
rfkill
rfkill: Fix use-after-free in rfkill_resume()
2020-11-12 09:18:06 +01:00
rose
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
rxrpc
rxrpc: Fix loss of final ack on shutdown
2020-10-15 13:28:00 +01:00
sched
netem: fix zero division in tabledist
2020-10-29 11:45:47 -07:00
sctp
sctp: Fix COMM_LOST/CANT_STR_ASSOC err reporting on big-endian platforms
2020-11-02 15:03:25 -08:00
smc
flexible-array member conversion patches for 5.10-rc2
2020-10-31 14:31:28 -07:00
strparser
…
sunrpc
The one new feature this time, from Anna Schumaker, is READ_PLUS, which
2020-10-22 09:44:27 -07:00
switchdev
net: switchdev: Fixed kerneldoc warning
2020-09-23 17:46:31 -07:00
tipc
tipc: fix memory leak in tipc_topsrv_start()
2020-11-11 14:39:23 -08:00
tls
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-10-15 12:43:21 -07:00
unix
networking changes for the 5.10 merge window
2020-10-15 18:42:13 -07:00
vmw_vsock
vsock: use ns_capable_noaudit() on socket create
2020-10-26 16:22:42 -07:00
wimax
genetlink: move to smaller ops wherever possible
2020-10-02 19:11:11 -07:00
wireless
cfg80211: regulatory: Fix inconsistent format argument
2020-10-30 10:06:56 +01:00
x25
net/x25: Fix null-ptr-deref in x25_connect
2020-11-11 14:53:56 -08:00
xdp
xsk: Fix possible memory leak at socket close
2020-10-29 15:19:56 +01:00
xfrm
Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec
2020-11-04 08:12:52 -08:00
compat.c
iov_iter: transparently handle compat iovecs in import_iovec
2020-10-03 00:02:13 -04:00
devres.c
…
Kconfig
drop_monitor: Convert to using devlink tracepoint
2020-09-30 18:01:26 -07:00
Makefile
…
socket.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-10-05 18:40:01 -07:00
sysctl_net.c
…