fc7a6209d5
The driver core ignores the return value of this callback because there is only little it can do when a device disappears. This is the final bit of a long lasting cleanup quest where several buses were converted to also return void from their remove callback. Additionally some resource leaks were fixed that were caused by drivers returning an error code in the expectation that the driver won't go away. With struct bus_type::remove returning void it's prevented that newly implemented buses return an ignored error code and so don't anticipate wrong expectations for driver authors. Reviewed-by: Tom Rix <trix@redhat.com> (For fpga) Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> Reviewed-by: Cornelia Huck <cohuck@redhat.com> (For drivers/s390 and drivers/vfio) Acked-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> (For ARM, Amba and related parts) Acked-by: Mark Brown <broonie@kernel.org> Acked-by: Chen-Yu Tsai <wens@csie.org> (for sunxi-rsb) Acked-by: Pali Rohár <pali@kernel.org> Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org> (for media) Acked-by: Hans de Goede <hdegoede@redhat.com> (For drivers/platform) Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Acked-By: Vinod Koul <vkoul@kernel.org> Acked-by: Juergen Gross <jgross@suse.com> (For xen) Acked-by: Lee Jones <lee.jones@linaro.org> (For mfd) Acked-by: Johannes Thumshirn <jth@kernel.org> (For mcb) Acked-by: Johan Hovold <johan@kernel.org> Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> (For slimbus) Acked-by: Kirti Wankhede <kwankhede@nvidia.com> (For vfio) Acked-by: Maximilian Luz <luzmaximilian@gmail.com> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> (For ulpi and typec) Acked-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com> (For ipack) Acked-by: Geoff Levand <geoff@infradead.org> (For ps3) Acked-by: Yehezkel Bernat <YehezkelShB@gmail.com> (For thunderbolt) Acked-by: Alexander Shishkin <alexander.shishkin@linux.intel.com> (For intel_th) Acked-by: Dominik Brodowski <linux@dominikbrodowski.net> (For pcmcia) Acked-by: Rafael J. Wysocki <rafael@kernel.org> (For ACPI) Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> (rpmsg and apr) Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> (For intel-ish-hid) Acked-by: Dan Williams <dan.j.williams@intel.com> (For CXL, DAX, and NVDIMM) Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com> (For isa) Acked-by: Stefan Richter <stefanr@s5r6.in-berlin.de> (For firewire) Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> (For hid) Acked-by: Thorsten Scherer <t.scherer@eckelmann.de> (For siox) Acked-by: Sven Van Asbroeck <TheSven73@gmail.com> (For anybuss) Acked-by: Ulf Hansson <ulf.hansson@linaro.org> (For MMC) Acked-by: Wolfram Sang <wsa@kernel.org> # for I2C Acked-by: Sudeep Holla <sudeep.holla@arm.com> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Acked-by: Finn Thain <fthain@linux-m68k.org> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20210713193522.1770306-6-u.kleine-koenig@pengutronix.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
414 lines
13 KiB
C
414 lines
13 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Surface System Aggregator Module bus and device integration.
|
|
*
|
|
* Copyright (C) 2019-2021 Maximilian Luz <luzmaximilian@gmail.com>
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/slab.h>
|
|
|
|
#include <linux/surface_aggregator/controller.h>
|
|
#include <linux/surface_aggregator/device.h>
|
|
|
|
#include "bus.h"
|
|
#include "controller.h"
|
|
|
|
static ssize_t modalias_show(struct device *dev, struct device_attribute *attr,
|
|
char *buf)
|
|
{
|
|
struct ssam_device *sdev = to_ssam_device(dev);
|
|
|
|
return sysfs_emit(buf, "ssam:d%02Xc%02Xt%02Xi%02Xf%02X\n",
|
|
sdev->uid.domain, sdev->uid.category, sdev->uid.target,
|
|
sdev->uid.instance, sdev->uid.function);
|
|
}
|
|
static DEVICE_ATTR_RO(modalias);
|
|
|
|
static struct attribute *ssam_device_attrs[] = {
|
|
&dev_attr_modalias.attr,
|
|
NULL,
|
|
};
|
|
ATTRIBUTE_GROUPS(ssam_device);
|
|
|
|
static int ssam_device_uevent(struct device *dev, struct kobj_uevent_env *env)
|
|
{
|
|
struct ssam_device *sdev = to_ssam_device(dev);
|
|
|
|
return add_uevent_var(env, "MODALIAS=ssam:d%02Xc%02Xt%02Xi%02Xf%02X",
|
|
sdev->uid.domain, sdev->uid.category,
|
|
sdev->uid.target, sdev->uid.instance,
|
|
sdev->uid.function);
|
|
}
|
|
|
|
static void ssam_device_release(struct device *dev)
|
|
{
|
|
struct ssam_device *sdev = to_ssam_device(dev);
|
|
|
|
ssam_controller_put(sdev->ctrl);
|
|
kfree(sdev);
|
|
}
|
|
|
|
const struct device_type ssam_device_type = {
|
|
.name = "surface_aggregator_device",
|
|
.groups = ssam_device_groups,
|
|
.uevent = ssam_device_uevent,
|
|
.release = ssam_device_release,
|
|
};
|
|
EXPORT_SYMBOL_GPL(ssam_device_type);
|
|
|
|
/**
|
|
* ssam_device_alloc() - Allocate and initialize a SSAM client device.
|
|
* @ctrl: The controller under which the device should be added.
|
|
* @uid: The UID of the device to be added.
|
|
*
|
|
* Allocates and initializes a new client device. The parent of the device
|
|
* will be set to the controller device and the name will be set based on the
|
|
* UID. Note that the device still has to be added via ssam_device_add().
|
|
* Refer to that function for more details.
|
|
*
|
|
* Return: Returns the newly allocated and initialized SSAM client device, or
|
|
* %NULL if it could not be allocated.
|
|
*/
|
|
struct ssam_device *ssam_device_alloc(struct ssam_controller *ctrl,
|
|
struct ssam_device_uid uid)
|
|
{
|
|
struct ssam_device *sdev;
|
|
|
|
sdev = kzalloc(sizeof(*sdev), GFP_KERNEL);
|
|
if (!sdev)
|
|
return NULL;
|
|
|
|
device_initialize(&sdev->dev);
|
|
sdev->dev.bus = &ssam_bus_type;
|
|
sdev->dev.type = &ssam_device_type;
|
|
sdev->dev.parent = ssam_controller_device(ctrl);
|
|
sdev->ctrl = ssam_controller_get(ctrl);
|
|
sdev->uid = uid;
|
|
|
|
dev_set_name(&sdev->dev, "%02x:%02x:%02x:%02x:%02x",
|
|
sdev->uid.domain, sdev->uid.category, sdev->uid.target,
|
|
sdev->uid.instance, sdev->uid.function);
|
|
|
|
return sdev;
|
|
}
|
|
EXPORT_SYMBOL_GPL(ssam_device_alloc);
|
|
|
|
/**
|
|
* ssam_device_add() - Add a SSAM client device.
|
|
* @sdev: The SSAM client device to be added.
|
|
*
|
|
* Added client devices must be guaranteed to always have a valid and active
|
|
* controller. Thus, this function will fail with %-ENODEV if the controller
|
|
* of the device has not been initialized yet, has been suspended, or has been
|
|
* shut down.
|
|
*
|
|
* The caller of this function should ensure that the corresponding call to
|
|
* ssam_device_remove() is issued before the controller is shut down. If the
|
|
* added device is a direct child of the controller device (default), it will
|
|
* be automatically removed when the controller is shut down.
|
|
*
|
|
* By default, the controller device will become the parent of the newly
|
|
* created client device. The parent may be changed before ssam_device_add is
|
|
* called, but care must be taken that a) the correct suspend/resume ordering
|
|
* is guaranteed and b) the client device does not outlive the controller,
|
|
* i.e. that the device is removed before the controller is being shut down.
|
|
* In case these guarantees have to be manually enforced, please refer to the
|
|
* ssam_client_link() and ssam_client_bind() functions, which are intended to
|
|
* set up device-links for this purpose.
|
|
*
|
|
* Return: Returns zero on success, a negative error code on failure.
|
|
*/
|
|
int ssam_device_add(struct ssam_device *sdev)
|
|
{
|
|
int status;
|
|
|
|
/*
|
|
* Ensure that we can only add new devices to a controller if it has
|
|
* been started and is not going away soon. This works in combination
|
|
* with ssam_controller_remove_clients to ensure driver presence for the
|
|
* controller device, i.e. it ensures that the controller (sdev->ctrl)
|
|
* is always valid and can be used for requests as long as the client
|
|
* device we add here is registered as child under it. This essentially
|
|
* guarantees that the client driver can always expect the preconditions
|
|
* for functions like ssam_request_sync (controller has to be started
|
|
* and is not suspended) to hold and thus does not have to check for
|
|
* them.
|
|
*
|
|
* Note that for this to work, the controller has to be a parent device.
|
|
* If it is not a direct parent, care has to be taken that the device is
|
|
* removed via ssam_device_remove(), as device_unregister does not
|
|
* remove child devices recursively.
|
|
*/
|
|
ssam_controller_statelock(sdev->ctrl);
|
|
|
|
if (sdev->ctrl->state != SSAM_CONTROLLER_STARTED) {
|
|
ssam_controller_stateunlock(sdev->ctrl);
|
|
return -ENODEV;
|
|
}
|
|
|
|
status = device_add(&sdev->dev);
|
|
|
|
ssam_controller_stateunlock(sdev->ctrl);
|
|
return status;
|
|
}
|
|
EXPORT_SYMBOL_GPL(ssam_device_add);
|
|
|
|
/**
|
|
* ssam_device_remove() - Remove a SSAM client device.
|
|
* @sdev: The device to remove.
|
|
*
|
|
* Removes and unregisters the provided SSAM client device.
|
|
*/
|
|
void ssam_device_remove(struct ssam_device *sdev)
|
|
{
|
|
device_unregister(&sdev->dev);
|
|
}
|
|
EXPORT_SYMBOL_GPL(ssam_device_remove);
|
|
|
|
/**
|
|
* ssam_device_id_compatible() - Check if a device ID matches a UID.
|
|
* @id: The device ID as potential match.
|
|
* @uid: The device UID matching against.
|
|
*
|
|
* Check if the given ID is a match for the given UID, i.e. if a device with
|
|
* the provided UID is compatible to the given ID following the match rules
|
|
* described in its &ssam_device_id.match_flags member.
|
|
*
|
|
* Return: Returns %true if the given UID is compatible to the match rule
|
|
* described by the given ID, %false otherwise.
|
|
*/
|
|
static bool ssam_device_id_compatible(const struct ssam_device_id *id,
|
|
struct ssam_device_uid uid)
|
|
{
|
|
if (id->domain != uid.domain || id->category != uid.category)
|
|
return false;
|
|
|
|
if ((id->match_flags & SSAM_MATCH_TARGET) && id->target != uid.target)
|
|
return false;
|
|
|
|
if ((id->match_flags & SSAM_MATCH_INSTANCE) && id->instance != uid.instance)
|
|
return false;
|
|
|
|
if ((id->match_flags & SSAM_MATCH_FUNCTION) && id->function != uid.function)
|
|
return false;
|
|
|
|
return true;
|
|
}
|
|
|
|
/**
|
|
* ssam_device_id_is_null() - Check if a device ID is null.
|
|
* @id: The device ID to check.
|
|
*
|
|
* Check if a given device ID is null, i.e. all zeros. Used to check for the
|
|
* end of ``MODULE_DEVICE_TABLE(ssam, ...)`` or similar lists.
|
|
*
|
|
* Return: Returns %true if the given ID represents a null ID, %false
|
|
* otherwise.
|
|
*/
|
|
static bool ssam_device_id_is_null(const struct ssam_device_id *id)
|
|
{
|
|
return id->match_flags == 0 &&
|
|
id->domain == 0 &&
|
|
id->category == 0 &&
|
|
id->target == 0 &&
|
|
id->instance == 0 &&
|
|
id->function == 0 &&
|
|
id->driver_data == 0;
|
|
}
|
|
|
|
/**
|
|
* ssam_device_id_match() - Find the matching ID table entry for the given UID.
|
|
* @table: The table to search in.
|
|
* @uid: The UID to matched against the individual table entries.
|
|
*
|
|
* Find the first match for the provided device UID in the provided ID table
|
|
* and return it. Returns %NULL if no match could be found.
|
|
*/
|
|
const struct ssam_device_id *ssam_device_id_match(const struct ssam_device_id *table,
|
|
const struct ssam_device_uid uid)
|
|
{
|
|
const struct ssam_device_id *id;
|
|
|
|
for (id = table; !ssam_device_id_is_null(id); ++id)
|
|
if (ssam_device_id_compatible(id, uid))
|
|
return id;
|
|
|
|
return NULL;
|
|
}
|
|
EXPORT_SYMBOL_GPL(ssam_device_id_match);
|
|
|
|
/**
|
|
* ssam_device_get_match() - Find and return the ID matching the device in the
|
|
* ID table of the bound driver.
|
|
* @dev: The device for which to get the matching ID table entry.
|
|
*
|
|
* Find the fist match for the UID of the device in the ID table of the
|
|
* currently bound driver and return it. Returns %NULL if the device does not
|
|
* have a driver bound to it, the driver does not have match_table (i.e. it is
|
|
* %NULL), or there is no match in the driver's match_table.
|
|
*
|
|
* This function essentially calls ssam_device_id_match() with the ID table of
|
|
* the bound device driver and the UID of the device.
|
|
*
|
|
* Return: Returns the first match for the UID of the device in the device
|
|
* driver's match table, or %NULL if no such match could be found.
|
|
*/
|
|
const struct ssam_device_id *ssam_device_get_match(const struct ssam_device *dev)
|
|
{
|
|
const struct ssam_device_driver *sdrv;
|
|
|
|
sdrv = to_ssam_device_driver(dev->dev.driver);
|
|
if (!sdrv)
|
|
return NULL;
|
|
|
|
if (!sdrv->match_table)
|
|
return NULL;
|
|
|
|
return ssam_device_id_match(sdrv->match_table, dev->uid);
|
|
}
|
|
EXPORT_SYMBOL_GPL(ssam_device_get_match);
|
|
|
|
/**
|
|
* ssam_device_get_match_data() - Find the ID matching the device in the
|
|
* ID table of the bound driver and return its ``driver_data`` member.
|
|
* @dev: The device for which to get the match data.
|
|
*
|
|
* Find the fist match for the UID of the device in the ID table of the
|
|
* corresponding driver and return its driver_data. Returns %NULL if the
|
|
* device does not have a driver bound to it, the driver does not have
|
|
* match_table (i.e. it is %NULL), there is no match in the driver's
|
|
* match_table, or the match does not have any driver_data.
|
|
*
|
|
* This function essentially calls ssam_device_get_match() and, if any match
|
|
* could be found, returns its ``struct ssam_device_id.driver_data`` member.
|
|
*
|
|
* Return: Returns the driver data associated with the first match for the UID
|
|
* of the device in the device driver's match table, or %NULL if no such match
|
|
* could be found.
|
|
*/
|
|
const void *ssam_device_get_match_data(const struct ssam_device *dev)
|
|
{
|
|
const struct ssam_device_id *id;
|
|
|
|
id = ssam_device_get_match(dev);
|
|
if (!id)
|
|
return NULL;
|
|
|
|
return (const void *)id->driver_data;
|
|
}
|
|
EXPORT_SYMBOL_GPL(ssam_device_get_match_data);
|
|
|
|
static int ssam_bus_match(struct device *dev, struct device_driver *drv)
|
|
{
|
|
struct ssam_device_driver *sdrv = to_ssam_device_driver(drv);
|
|
struct ssam_device *sdev = to_ssam_device(dev);
|
|
|
|
if (!is_ssam_device(dev))
|
|
return 0;
|
|
|
|
return !!ssam_device_id_match(sdrv->match_table, sdev->uid);
|
|
}
|
|
|
|
static int ssam_bus_probe(struct device *dev)
|
|
{
|
|
return to_ssam_device_driver(dev->driver)
|
|
->probe(to_ssam_device(dev));
|
|
}
|
|
|
|
static void ssam_bus_remove(struct device *dev)
|
|
{
|
|
struct ssam_device_driver *sdrv = to_ssam_device_driver(dev->driver);
|
|
|
|
if (sdrv->remove)
|
|
sdrv->remove(to_ssam_device(dev));
|
|
}
|
|
|
|
struct bus_type ssam_bus_type = {
|
|
.name = "surface_aggregator",
|
|
.match = ssam_bus_match,
|
|
.probe = ssam_bus_probe,
|
|
.remove = ssam_bus_remove,
|
|
};
|
|
EXPORT_SYMBOL_GPL(ssam_bus_type);
|
|
|
|
/**
|
|
* __ssam_device_driver_register() - Register a SSAM client device driver.
|
|
* @sdrv: The driver to register.
|
|
* @owner: The module owning the provided driver.
|
|
*
|
|
* Please refer to the ssam_device_driver_register() macro for the normal way
|
|
* to register a driver from inside its owning module.
|
|
*/
|
|
int __ssam_device_driver_register(struct ssam_device_driver *sdrv,
|
|
struct module *owner)
|
|
{
|
|
sdrv->driver.owner = owner;
|
|
sdrv->driver.bus = &ssam_bus_type;
|
|
|
|
/* force drivers to async probe so I/O is possible in probe */
|
|
sdrv->driver.probe_type = PROBE_PREFER_ASYNCHRONOUS;
|
|
|
|
return driver_register(&sdrv->driver);
|
|
}
|
|
EXPORT_SYMBOL_GPL(__ssam_device_driver_register);
|
|
|
|
/**
|
|
* ssam_device_driver_unregister - Unregister a SSAM device driver.
|
|
* @sdrv: The driver to unregister.
|
|
*/
|
|
void ssam_device_driver_unregister(struct ssam_device_driver *sdrv)
|
|
{
|
|
driver_unregister(&sdrv->driver);
|
|
}
|
|
EXPORT_SYMBOL_GPL(ssam_device_driver_unregister);
|
|
|
|
static int ssam_remove_device(struct device *dev, void *_data)
|
|
{
|
|
struct ssam_device *sdev = to_ssam_device(dev);
|
|
|
|
if (is_ssam_device(dev))
|
|
ssam_device_remove(sdev);
|
|
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* ssam_controller_remove_clients() - Remove SSAM client devices registered as
|
|
* direct children under the given controller.
|
|
* @ctrl: The controller to remove all direct clients for.
|
|
*
|
|
* Remove all SSAM client devices registered as direct children under the
|
|
* given controller. Note that this only accounts for direct children of the
|
|
* controller device. This does not take care of any client devices where the
|
|
* parent device has been manually set before calling ssam_device_add. Refer
|
|
* to ssam_device_add()/ssam_device_remove() for more details on those cases.
|
|
*
|
|
* To avoid new devices being added in parallel to this call, the main
|
|
* controller lock (not statelock) must be held during this (and if
|
|
* necessary, any subsequent deinitialization) call.
|
|
*/
|
|
void ssam_controller_remove_clients(struct ssam_controller *ctrl)
|
|
{
|
|
struct device *dev;
|
|
|
|
dev = ssam_controller_device(ctrl);
|
|
device_for_each_child_reverse(dev, NULL, ssam_remove_device);
|
|
}
|
|
|
|
/**
|
|
* ssam_bus_register() - Register and set-up the SSAM client device bus.
|
|
*/
|
|
int ssam_bus_register(void)
|
|
{
|
|
return bus_register(&ssam_bus_type);
|
|
}
|
|
|
|
/**
|
|
* ssam_bus_unregister() - Unregister the SSAM client device bus.
|
|
*/
|
|
void ssam_bus_unregister(void)
|
|
{
|
|
return bus_unregister(&ssam_bus_type);
|
|
}
|