iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/block
History
Jens Axboe 1af0bdca03 block: be a bit more careful in checking for NULL bdev while polling 
commit 310726c33ad76cebdee312dbfafc12c1b44bf977 upstream.

Wei reports a crash with an application using polled IO:

PGD 14265e067 P4D 14265e067 PUD 47ec50067 PMD 0
Oops: 0000 [#1] SMP
CPU: 0 PID: 21915 Comm: iocore_0 Kdump: loaded Tainted: G S                5.12.0-0_fbk12_clang_7346_g1bb6f2e7058f #1
Hardware name: Wiwynn Delta Lake MP T8/Delta Lake-Class2, BIOS Y3DLM08 04/10/2022
RIP: 0010:bio_poll+0x25/0x200
Code: 0f 1f 44 00 00 0f 1f 44 00 00 55 41 57 41 56 41 55 41 54 53 48 83 ec 28 65 48 8b 04 25 28 00 00 00 48 89 44 24 20 48 8b 47 08 <48> 8b 80 70 02 00 00 4c 8b 70 50 8b 6f 34 31 db 83 fd ff 75 25 65
RSP: 0018:ffffc90005fafdf8 EFLAGS: 00010292
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 74b43cd65dd66600
RDX: 0000000000000003 RSI: ffffc90005fafe78 RDI: ffff8884b614e140
RBP: ffff88849964df78 R08: 0000000000000000 R09: 0000000000000008
R10: 0000000000000000 R11: 0000000000000000 R12: ffff88849964df00
R13: ffffc90005fafe78 R14: ffff888137d3c378 R15: 0000000000000001
FS:  00007fd195000640(0000) GS:ffff88903f400000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000270 CR3: 0000000466121001 CR4: 00000000007706f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
PKRU: 55555554
Call Trace:
 iocb_bio_iopoll+0x1d/0x30
 io_do_iopoll+0xac/0x250
 __se_sys_io_uring_enter+0x3c5/0x5a0
 ? __x64_sys_write+0x89/0xd0
 do_syscall_64+0x2d/0x40
 entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x94f225d
Code: 24 cc 00 00 00 41 8b 84 24 d0 00 00 00 c1 e0 04 83 e0 10 41 09 c2 8b 33 8b 53 04 4c 8b 43 18 4c 63 4b 0c b8 aa 01 00 00 0f 05 <85> c0 0f 88 85 00 00 00 29 03 45 84 f6 0f 84 88 00 00 00 41 f6 c7
RSP: 002b:00007fd194ffcd88 EFLAGS: 00000202 ORIG_RAX: 00000000000001aa
RAX: ffffffffffffffda RBX: 00007fd194ffcdc0 RCX: 00000000094f225d
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000007
RBP: 00007fd194ffcdb0 R08: 0000000000000000 R09: 0000000000000008
R10: 0000000000000001 R11: 0000000000000202 R12: 00007fd269d68030
R13: 0000000000000000 R14: 0000000000000001 R15: 0000000000000000

which is due to bio->bi_bdev being NULL. This can happen if we have two
tasks doing polled IO, and task B ends up completing IO from task A if
they are sharing a poll queue. If task B completes the IO and puts the
bio into our cache, then it can allocate that bio again before task A
is done polling for it. As that would necessitate a preempt between the
two tasks, it's enough to just be a bit more careful in checking for
whether or not bio->bi_bdev is NULL.

Reported-and-tested-by: Wei Zhang <wzhang@meta.com>
Cc: stable@vger.kernel.org
Fixes: be4d234d7aeb ("bio: add allocation cache abstraction")
Reviewed-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-03-10 09:34:02 +01:00
..
partitions
block: don't add partitions if GD_SUPPRESS_PART_SCAN is set
2022-09-03 11:29:03 -06:00
badblocks.c
block/badblocks: Remove redundant assignments
2022-04-23 07:15:26 -06:00
bdev.c
vfs: support STATX_DIOALIGN on block devices
2022-09-11 19:47:12 -05:00
bfq-cgroup.c
block, bfq: fix uaf for bfqq in bic_set_bfqq()
2023-02-09 11:28:06 +01:00
bfq-iosched.c
block, bfq: fix uaf for bfqq in bic_set_bfqq()
2023-02-09 11:28:06 +01:00
bfq-iosched.h
block, bfq: remove unused variable for bfq_queue
2022-10-20 05:46:49 -07:00
bfq-wf2q.c
block, bfq: remove useless parameter for bfq_add/del_bfqq_busy()
2022-08-22 10:07:56 -06:00
bio-integrity.c
block: bio-integrity: Copy flags when bio_integrity_payload is cloned
2023-03-10 09:32:46 +01:00
bio.c
block: clear bio->bi_bdev when putting a bio back in the cache
2023-03-10 09:34:02 +01:00
blk-cgroup-fc-appid.c
cgroup: Homogenize cgroup_get_from_id() return value
2022-08-26 10:57:41 -10:00
blk-cgroup-rwstat.c
blk-cgroup: Fix the recursive blkg rwstat
2021-03-05 11:32:15 -07:00
blk-cgroup-rwstat.h
block: Use the new blk_opf_t type
2022-07-14 12:14:30 -06:00
blk-cgroup.c
blk-cgroup: synchronize pd_free_fn() from blkg_free_workfn() and blkcg_deactivate_policy()
2023-03-10 09:33:46 +01:00
blk-cgroup.h
blk-cgroup: pass a gendisk to blkcg_init_queue and blkcg_exit_queue
2022-09-26 19:09:31 -06:00
blk-core.c
block: be a bit more careful in checking for NULL bdev while polling
2023-03-10 09:34:02 +01:00
blk-crypto-fallback.c
treewide: use get_random_bytes() when possible
2022-10-11 17:42:58 -06:00
blk-crypto-internal.h
blk-crypto: show crypto capabilities in sysfs
2022-02-28 06:40:23 -07:00
blk-crypto-profile.c
blk-crypto: remove blk_crypto_unregister()
2021-11-29 06:38:51 -07:00
blk-crypto-sysfs.c
blk-crypto: show crypto capabilities in sysfs
2022-02-28 06:40:23 -07:00
blk-crypto.c
blk-crypto: show crypto capabilities in sysfs
2022-02-28 06:40:23 -07:00
blk-flush.c
block: change request end_io handler to pass back a return value
2022-09-30 07:49:09 -06:00
blk-ia-ranges.c
block: simplify disk_set_independent_access_ranges
2022-06-29 08:36:46 -06:00
blk-integrity.c
blk-crypto: remove blk_crypto_unregister()
2021-11-29 06:38:51 -07:00
blk-ioc.c
block: fix default IO priority handling again
2022-06-27 06:29:12 -06:00
blk-iocost.c
blk-iocost: fix divide by 0 error in calc_lcoefs()
2023-03-10 09:33:46 +01:00
blk-iolatency.c
blk-cgroup: pass a gendisk to blkcg_schedule_throttle
2022-09-26 19:17:28 -06:00
blk-ioprio.c
blk-ioprio: pass a gendisk to blk_ioprio_init and blk_ioprio_exit
2022-09-26 19:09:31 -06:00
blk-ioprio.h
blk-ioprio: pass a gendisk to blk_ioprio_init and blk_ioprio_exit
2022-09-26 19:09:31 -06:00
blk-lib.c
blk-lib: fix blkdev_issue_secure_erase
2022-09-15 00:25:17 -06:00
blk-map.c
block: extend functionality to map bvec iterator
2022-09-30 07:51:13 -06:00
blk-merge.c
block: use proper return value from bio_failfast()
2023-03-10 09:32:47 +01:00
blk-mq-cpumap.c
block: Change the return type of blk_mq_map_queues() into void
2022-08-22 10:07:53 -06:00
blk-mq-debugfs-zoned.c
block: move zone related fields to struct gendisk
2022-07-06 06:46:26 -06:00
blk-mq-debugfs.c
for-6.1/block-2022-10-03
2022-10-07 09:19:14 -07:00
blk-mq-debugfs.h
block: remove per-disk debugfs files in blk_unregister_queue
2022-06-17 07:31:05 -06:00
blk-mq-pci.c
block: Change the return type of blk_mq_map_queues() into void
2022-08-22 10:07:53 -06:00
blk-mq-rdma.c
block: Change the return type of blk_mq_map_queues() into void
2022-08-22 10:07:53 -06:00
blk-mq-sched.c
blk-mq: correct stale comment of .get_budget
2023-03-10 09:32:44 +01:00
blk-mq-sched.h
block: move blk_mq_sched_assign_ioc to blk-ioc.c
2021-11-29 06:41:29 -07:00
blk-mq-sysfs.c
blk-mq: fix possible memleak when register 'hctx' failed
2022-12-31 13:33:03 +01:00
blk-mq-tag.c
sbitmap: fix batched wait_cnt accounting
2022-09-12 00:10:34 -06:00
blk-mq-tag.h
blk-mq: blk_mq_tag_busy is no need to return a value
2022-06-27 06:29:12 -06:00
blk-mq-virtio.c
block: Change the return type of blk_mq_map_queues() into void
2022-08-22 10:07:53 -06:00
blk-mq.c
blk-mq: Fix potential io hung for shared sbitmap per tagset
2023-03-10 09:32:44 +01:00
blk-mq.h
block: adapt blk_mq_plug() to not plug for writes that require a zone lock
2022-09-29 07:45:47 -06:00
blk-pm.c
scsi: block: pm: Always set request queue runtime active in blk_post_runtime_resume()
2021-12-22 23:38:29 -05:00
blk-pm.h
block: Remove unused blk_pm_*() function definitions
2021-02-22 06:33:48 -07:00
blk-rq-qos.c
block/rq_qos: Use atomic_try_cmpxchg in atomic_inc_below
2022-07-12 14:38:52 -06:00
blk-rq-qos.h
block/blk-rq-qos: delete useless enmu RQ_QOS_IOPRIO
2022-09-21 19:50:53 -06:00
blk-settings.c
block: make blk_set_default_limits() private
2022-11-16 15:58:11 -07:00
blk-stat.c
block: make queue stat accounting a reference
2021-12-14 17:23:05 -07:00
blk-stat.h
block: make queue stat accounting a reference
2021-12-14 17:23:05 -07:00
blk-sysfs.c
blk-throttle: pass a gendisk to blk_throtl_register_queue
2022-09-26 19:17:27 -06:00
blk-throttle.c
blk-throttle: pass a gendisk to blk_throtl_cancel_bios
2022-09-26 19:17:28 -06:00
blk-throttle.h
blk-throttle: pass a gendisk to blk_throtl_cancel_bios
2022-09-26 19:17:28 -06:00
blk-timeout.c
block: blk-timeout: delete duplicated word
2020-07-31 16:29:47 -06:00
blk-wbt.c
blk-wbt: fix that 'rwb->wc' is always set to 1 in wbt_init()
2022-10-09 07:48:16 -06:00
blk-wbt.h
blk-wbt: remove wbt_track stub
2022-03-31 12:58:38 -06:00
blk-zoned.c
block: adapt blk_mq_plug() to not plug for writes that require a zone lock
2022-09-29 07:45:47 -06:00
blk.h
block: Do not reread partition table on exclusively open device
2023-01-04 11:29:01 +01:00
bounce.c
block: change the blk_queue_bounce calling convention
2022-08-02 17:22:54 -06:00
bsg-lib.c
blk-mq: Drop blk_mq_ops.timeout 'reserved' arg
2022-07-06 06:33:53 -06:00
bsg.c
scsi: core: bsg: Remove usage of the deprecated ida_simple_xxx() API
2022-06-21 21:22:51 -04:00
disk-events.c
block: remove genhd.h
2022-02-02 07:49:59 -07:00
elevator.c
blk-mq: use quiesced elevator switch when reinitializing queues
2022-09-27 09:58:56 -06:00
elevator.h
block: Use the new blk_opf_t type
2022-07-14 12:14:30 -06:00
fops.c
block: don't allow multiple bios for IOCB_NOWAIT issue
2023-03-10 09:34:02 +01:00
genhd.c
block: Do not reread partition table on exclusively open device
2023-01-04 11:29:01 +01:00
holder.c
block: remove WARN_ON() from bd_link_disk_holder
2022-06-23 07:48:05 -06:00
ioctl.c
block: Do not reread partition table on exclusively open device
2023-01-04 11:29:01 +01:00
ioprio.c
block: Fix handling of tasks without ioprio in ioprio_get(2)
2022-06-27 06:29:12 -06:00
Kconfig
block: remove "select BLK_RQ_IO_DATA_LEN" from BLK_CGROUP_IOCOST dependency
2022-06-29 08:35:57 -06:00
Kconfig.iosched
block: only build the icq tracking code when needed
2021-12-16 10:59:02 -07:00
kyber-iosched.c
block/kyber: Use the new blk_opf_t type
2022-07-14 12:14:30 -06:00
Makefile
blk-cgroup: move blkcg_{get,set}_fc_appid out of line
2022-05-02 14:06:20 -06:00
mq-deadline.c
block: mq-deadline: Rename deadline_is_seq_writes()
2023-01-24 07:24:44 +01:00
opal_proto.h
block: sed-opal: Add ioctl to return device status
2022-08-22 07:52:51 -06:00
sed-opal.c
block: sed-opal: kmalloc the cmd/resp buffers
2022-11-08 07:14:35 -07:00
t10-pi.c
block: add pi for extended integrity
2022-03-07 12:48:35 -07:00