Florian Westphal 7c96643519 netfilter: move nat hlist_head to nf_conn
The nat extension structure is 32bytes in size on x86_64:

struct nf_conn_nat {
        struct hlist_node          bysource;             /*     0    16 */
        struct nf_conn *           ct;                   /*    16     8 */
        union nf_conntrack_nat_help help;                /*    24     4 */
        int                        masq_index;           /*    28     4 */
        /* size: 32, cachelines: 1, members: 4 */
        /* last cacheline: 32 bytes */
};

The hlist is needed to quickly check for possible tuple collisions
when installing a new nat binding. Storing this in the extension
area has two drawbacks:

1. We need ct backpointer to get the conntrack struct from the extension.
2. When reallocation of extension area occurs we need to fixup the bysource
   hash head via hlist_replace_rcu.

We can avoid both by placing the hlist_head in nf_conn and place nf_conn in
the bysource hash rather than the extenstion.

We can also remove the ->move support; no other extension needs it.

Moving the entire nat extension into nf_conn would be possible as well but
then we have to add yet another callback for deletion from the bysource
hash table rather than just using nat extension ->destroy hook for this.

nf_conn size doesn't increase due to aligment, followup patch replaces
hlist_node with single pointer.

Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
2016-07-11 11:47:50 +02:00
..
2016-06-03 19:37:21 -04:00
2016-06-15 20:41:23 -07:00
2015-03-04 00:23:23 -05:00
2015-06-28 16:55:44 -07:00
2015-11-18 16:17:38 -05:00
2016-04-25 16:44:27 -04:00
2016-04-25 16:44:27 -04:00
2016-06-09 23:41:03 -07:00
2015-03-06 21:50:02 -05:00
2015-09-17 17:18:37 -07:00
2016-02-16 20:21:48 -05:00
2016-06-08 11:36:02 -07:00
2016-05-20 18:03:16 -04:00
2016-04-28 17:03:38 -04:00
2016-04-25 16:45:53 -04:00
2016-06-15 22:15:21 -07:00
2016-04-27 22:48:25 -04:00
2016-05-20 18:03:17 -04:00
2016-05-03 16:08:14 -04:00
2016-03-10 14:42:03 -05:00
2016-02-21 22:00:28 -05:00
2015-10-23 06:26:42 -07:00
2016-06-15 20:41:23 -07:00
2016-05-16 13:46:23 -04:00
2016-03-23 22:09:58 -04:00
2016-04-07 16:53:30 -04:00
2015-03-12 22:58:12 -04:00
2016-05-03 16:08:14 -04:00
2015-10-26 22:24:22 -07:00
2016-04-27 22:48:23 -04:00