eab302e89f
Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to sysfs_emit(). sprintf() and scnprintf() will be converted as well if they have. Generally, this patch is generated by make coccicheck M=<path/to/file> MODE=patch \ COCCI=scripts/coccinelle/api/device_attr_show.cocci No functional change intended CC: Karan Tilak Kumar <kartilak@cisco.com> CC: Sesidhar Baddela <sebaddel@cisco.com> CC: James E.J. Bottomley <jejb@linux.ibm.com> CC: Martin K. Petersen <martin.petersen@oracle.com> CC: linux-scsi@vger.kernel.org Signed-off-by: Li Zhijian <lizhijian@fujitsu.com> Link: https://lore.kernel.org/r/20240319063132.1588443-12-lizhijian@fujitsu.com Reviewed-by: Karan Tilak Kumar <kartilak@cisco.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
72 lines
1.7 KiB
C
72 lines
1.7 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
// Copyright 2014 Cisco Systems, Inc. All rights reserved.
|
|
|
|
#include <linux/string.h>
|
|
#include <linux/device.h>
|
|
|
|
#include "snic.h"
|
|
|
|
static ssize_t
|
|
snic_show_sym_name(struct device *dev,
|
|
struct device_attribute *attr,
|
|
char *buf)
|
|
{
|
|
struct snic *snic = shost_priv(class_to_shost(dev));
|
|
|
|
return sysfs_emit(buf, "%s\n", snic->name);
|
|
}
|
|
|
|
static ssize_t
|
|
snic_show_state(struct device *dev,
|
|
struct device_attribute *attr,
|
|
char *buf)
|
|
{
|
|
struct snic *snic = shost_priv(class_to_shost(dev));
|
|
|
|
return sysfs_emit(buf, "%s\n", snic_state_str[snic_get_state(snic)]);
|
|
}
|
|
|
|
static ssize_t
|
|
snic_show_drv_version(struct device *dev,
|
|
struct device_attribute *attr,
|
|
char *buf)
|
|
{
|
|
return sysfs_emit(buf, "%s\n", SNIC_DRV_VERSION);
|
|
}
|
|
|
|
static ssize_t
|
|
snic_show_link_state(struct device *dev,
|
|
struct device_attribute *attr,
|
|
char *buf)
|
|
{
|
|
struct snic *snic = shost_priv(class_to_shost(dev));
|
|
|
|
if (snic->config.xpt_type == SNIC_DAS)
|
|
snic->link_status = svnic_dev_link_status(snic->vdev);
|
|
|
|
return sysfs_emit(buf, "%s\n",
|
|
(snic->link_status) ? "Link Up" : "Link Down");
|
|
}
|
|
|
|
static DEVICE_ATTR(snic_sym_name, S_IRUGO, snic_show_sym_name, NULL);
|
|
static DEVICE_ATTR(snic_state, S_IRUGO, snic_show_state, NULL);
|
|
static DEVICE_ATTR(drv_version, S_IRUGO, snic_show_drv_version, NULL);
|
|
static DEVICE_ATTR(link_state, S_IRUGO, snic_show_link_state, NULL);
|
|
|
|
static struct attribute *snic_host_attrs[] = {
|
|
&dev_attr_snic_sym_name.attr,
|
|
&dev_attr_snic_state.attr,
|
|
&dev_attr_drv_version.attr,
|
|
&dev_attr_link_state.attr,
|
|
NULL,
|
|
};
|
|
|
|
static const struct attribute_group snic_host_attr_group = {
|
|
.attrs = snic_host_attrs
|
|
};
|
|
|
|
const struct attribute_group *snic_host_groups[] = {
|
|
&snic_host_attr_group,
|
|
NULL
|
|
};
|