iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs
History
dean gaudet 7d95c8f27d [PATCH] fcntl F_SETFL and read-only IS_APPEND files 
There is code in setfl() which attempts to preserve the O_APPEND flag on
IS_APPEND files...  however IS_APPEND files could also be opened O_RDONLY
and in that case setfl() should not require O_APPEND...

coreutils 5.93 tail -f attempts to set O_NONBLOCK even on regular files...
unfortunately if you try this on an append-only log file the result is
this:

fcntl64(3, F_GETFL)                     = 0x8000 (flags O_RDONLY|O_LARGEFILE)
fcntl64(3, F_SETFL, O_RDONLY|O_NONBLOCK|O_LARGEFILE) = -1 EPERM (Operation not permitted)

I offer up the patch below as one way of fixing the problem...  i've tested
it fixes the problem with tail -f but haven't really tested beyond that.

(I also reported the coreutils bug upstream... it shouldn't fail imho...
<https://savannah.gnu.org/bugs/index.php?func=detailitem&item_id=15473>)

Signed-off-by: dean gaudet <dean@arctic.org>
Cc: Al Viro <viro@ftp.linux.org.uk>
Acked-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-02-03 08:32:07 -08:00
..
9p
[PATCH] v9fs: fix corner cases when flushing request
2006-02-03 08:32:06 -08:00
adfs
[PATCH] changing CONFIG_LOCALVERSION rebuilds too much, for no good reason
2005-11-09 07:55:57 -08:00
affs
[PATCH] mutex subsystem, semaphore to mutex: VFS, ->i_sem
2006-01-09 15:59:24 -08:00
afs
add loglevel to printk in fs/afs/cmservice.c
2006-01-11 01:52:40 +01:00
autofs
[PATCH] capable/capability.h (fs/)
2006-01-11 18:42:13 -08:00
autofs4
[PATCH] autofs4 oops fix
2006-01-14 18:25:19 -08:00
befs
remove unused fs/befs/attribute.c
2005-11-08 16:54:53 +01:00
bfs
[PATCH] bfs iget() abuses
2005-10-04 13:22:01 -07:00
cifs
[CIFS] Remove compiler warning
2006-01-27 18:36:11 -08:00
coda
[PATCH] mutex subsystem, semaphore to mutex: VFS, ->i_sem
2006-01-09 15:59:24 -08:00
configfs
[PATCH] mutex subsystem, semaphore to mutex: VFS, ->i_sem
2006-01-09 15:59:24 -08:00
cramfs
[PATCH] fs/cramfs/uncompress.c should #include <linux/cramfs_fs.h>
2005-09-10 10:06:35 -07:00
debugfs
[PATCH] mutex subsystem, semaphore to mutex: VFS, ->i_sem
2006-01-09 15:59:24 -08:00
devfs
[PATCH] mutex subsystem, semaphore to mutex: VFS, ->i_sem
2006-01-09 15:59:24 -08:00
devpts
[PATCH] mutex subsystem, semaphore to mutex: VFS, ->i_sem
2006-01-09 15:59:24 -08:00
efs
return statement cleanup - kill pointless parentheses
2006-01-15 02:37:08 +01:00
exportfs
[PATCH] exportfs: add find_acceptable_alias helper
2006-01-18 19:20:28 -08:00
ext2
[PATCH] ext2: print xip mount option in ext2_show_options
2006-02-03 08:32:07 -08:00
ext3
[PATCH] Fix two ext[23] uninitialized warnings
2006-02-03 08:32:05 -08:00
fat
[PATCH] capable/capability.h (fs/)
2006-01-11 18:42:13 -08:00
freevxfs
[PATCH] fix possible PAGE_CACHE_SHIFT overflows
2006-01-08 20:13:54 -08:00
fuse
[PATCH] fuse: fix async read for legacy filesystems
2006-02-01 08:53:09 -08:00
hfs
[PATCH] hfs: cleanup HFS prints
2006-01-18 19:20:23 -08:00
hfsplus
[PATCH] hfs: set type/creator for symlinks
2006-01-18 19:20:23 -08:00
hostfs
[PATCH] uml: hostfs - fix possible PAGE_CACHE_SHIFT overflows
2005-12-29 09:48:15 -08:00
hpfs
[PATCH] mutex subsystem, semaphore to mutex: VFS, ->i_sem
2006-01-09 15:59:24 -08:00
hppfs
[PATCH] mutex subsystem, semaphore to mutex: VFS, ->i_sem
2006-01-09 15:59:24 -08:00
hugetlbfs
[PATCH] mm: hugepage accounting fix
2006-02-01 08:53:15 -08:00
isofs
[PATCH] isofs: remove d_splice_alias NULL check from isofs_lookup
2006-01-14 18:27:12 -08:00
jbd
[PATCH] jbd: remove_transaction fix
2006-01-18 19:20:16 -08:00
jffs
[PATCH] fs/jffs/intrep.c: 255 is unsigned char
2006-02-03 08:32:05 -08:00
jffs2
[PATCH] Unlinline a bunch of other functions
2006-01-14 18:27:06 -08:00
jfs
[PATCH] capable/capability.h (fs/)
2006-01-11 18:42:13 -08:00
lockd
NLM: Ensure that nlmclnt_cancel_callback() doesn't loop forever
2006-02-01 12:52:23 -05:00
minix
[PATCH] update filesystems for new delete_inode behavior
2005-09-09 13:57:27 -07:00
msdos
[PATCH] fat: remove the unneeded vfat_find() in vfat_rename()
2005-10-30 17:37:32 -08:00
ncpfs
[PATCH] ncpfs: remove kmalloc wrapper
2006-01-14 18:27:12 -08:00
nfs
NFSv3: fix sync_retry in direct i/o NFS
2006-02-01 12:52:25 -05:00
nfs_common
[PATCH] nfsacl: Solaris VxFS compatibility fix
2005-10-11 09:46:54 -07:00
nfsd
[PATCH] knfsd: Restore recently broken ACL functionality to NFS server
2006-02-01 08:53:09 -08:00
nls
[PATCH] make some things static
2005-05-05 16:36:47 -07:00
ntfs
[PATCH] ntfs: remove superflous MS_NOATIME/MS_NODIRATIME assignments
2006-01-10 08:01:33 -08:00
ocfs2
[PATCH] capable/capability.h (fs/)
2006-01-11 18:42:13 -08:00
openpromfs
[PATCH] kfree cleanup: fs
2005-11-07 07:54:06 -08:00
partitions
[PATCH] partitions: Read Rio Karma partition table
2006-01-16 23:15:29 -08:00
proc
[PATCH] disable per cpu intr in /proc/stat
2006-02-03 08:32:07 -08:00
qnx4
fs/qnx4/bitmap.c: #if 0 qnx4_new_block()
2006-01-03 13:21:37 +01:00
ramfs
[PATCH] NOMMU: Provide shared-writable mmap support on ramfs
2006-01-06 08:33:32 -08:00
reiserfs
[PATCH] someone broke reiserfs V3 mount options, this fixes it
2006-02-03 08:32:03 -08:00
relayfs
[PATCH] mutex subsystem, semaphore to mutex: VFS, ->i_sem
2006-01-09 15:59:24 -08:00
romfs
[PATCH] fix possible PAGE_CACHE_SHIFT overflows
2006-01-08 20:13:54 -08:00
smbfs
[PATCH] smbfs readdir vs signal fix
2006-02-01 08:53:09 -08:00
sysfs
[PATCH] capable/capability.h (fs/)
2006-01-11 18:42:13 -08:00
sysv
correct email address of Manfred Spraul
2006-01-15 02:43:54 +01:00
udf
[PATCH] capable/capability.h (fs/)
2006-01-11 18:42:13 -08:00
ufs
[PATCH] ufs: fix hang during `rm'
2006-02-03 08:32:04 -08:00
vfat
[PATCH] fat: remove the unneeded vfat_find() in vfat_rename()
2005-10-30 17:37:32 -08:00
xfs
[PATCH] Direct Migration V9: Avoid writeback / page_migrate() method
2006-02-01 08:53:17 -08:00
aio.c
[PATCH] rcu file: use atomic primitives
2006-01-08 20:13:48 -08:00
attr.c
[PATCH] capable/capability.h (fs/)
2006-01-11 18:42:13 -08:00
bad_inode.c
[PATCH] make some things static
2005-05-05 16:36:47 -07:00
binfmt_aout.c
[PATCH] dump_thread() cleanup
2006-01-10 08:01:25 -08:00
binfmt_elf_fdpic.c
[PATCH] fs/binfmt_elf: Remove unneeded kmalloc() return value casts
2006-01-10 08:02:01 -08:00
binfmt_elf.c
[PATCH] Unlinline a bunch of other functions
2006-01-14 18:27:06 -08:00
binfmt_em86.c
Linux-2.6.12-rc2
2005-04-16 15:20:36 -07:00
binfmt_flat.c
[PATCH] uclinux: delay binfmt_flat trace
2006-01-10 09:31:27 -08:00
binfmt_misc.c
[PATCH] Unlinline a bunch of other functions
2006-01-14 18:27:06 -08:00
binfmt_script.c
Linux-2.6.12-rc2
2005-04-16 15:20:36 -07:00
binfmt_som.c
[PATCH] mm: mm_init set_mm_counters
2005-10-29 21:40:38 -07:00
bio.c
[BLOCK] A few kerneldoc fixups
2006-01-31 15:24:34 +01:00
block_dev.c
[PATCH] mutex subsystem, semaphore to mutex: VFS, ->i_sem
2006-01-09 15:59:24 -08:00
buffer.c
[PATCH] reiserfs: zero b_private when allocating buffer heads
2006-02-01 08:53:26 -08:00
char_dev.c
[PATCH] convert /proc/devices to use seq_file interface
2006-01-14 18:25:19 -08:00
compat_ioctl.c
[PATCH] Implement ioctl emulation for the parport character device
2006-01-12 09:08:49 -08:00
compat.c
[PATCH] compat: fix compat_sys_openat and friends
2006-02-01 22:04:33 -08:00
dcache.c
[PATCH] make "struct d_cookie" depend on CONFIG_PROFILING
2006-02-03 08:32:04 -08:00
dcookies.c
[PATCH] capable/capability.h (fs/)
2006-01-11 18:42:13 -08:00
direct-io.c
[PATCH] fix O_DIRECT read of last block in a sparse file
2006-02-03 08:32:07 -08:00
dnotify.c
Linux-2.6.12-rc2
2005-04-16 15:20:36 -07:00
dquot.c
[PATCH] capable/capability.h (fs/)
2006-01-11 18:42:13 -08:00
drop_caches.c
[PATCH] drop-pagecache
2006-01-08 20:12:40 -08:00
eventpoll.c
[PATCH] epoll: handle timeout overflow
2005-09-28 07:46:41 -07:00
exec.c
[PATCH] vfs: *at functions: core
2006-01-18 19:20:29 -08:00
fcntl.c
[PATCH] fcntl F_SETFL and read-only IS_APPEND files
2006-02-03 08:32:07 -08:00
fifo.c
[PATCH] mutex subsystem, semaphore to mutex: VFS, ->i_sem
2006-01-09 15:59:24 -08:00
file_table.c
[PATCH] capable/capability.h (fs/)
2006-01-11 18:42:13 -08:00
file.c
[PATCH] Fix the fdtable freeing in the case of vmalloced fdset/arrays
2005-09-14 12:38:26 -07:00
filesystems.c
[PATCH] fix missing includes
2005-10-30 17:37:32 -08:00
fs-writeback.c
[PATCH] kernel-docs: fix kernel-doc format problems
2005-11-07 07:53:55 -08:00
inode.c
[PATCH] DocBook: fix some kernel-doc comments in fs and block
2006-02-01 08:53:27 -08:00
inotify.c
[PATCH] add missing syscall declarations
2006-01-18 19:20:22 -08:00
ioctl.c
[PATCH] capable/capability.h (fs/)
2006-01-11 18:42:13 -08:00
ioprio.c
[PATCH] capable/capability.h (fs/)
2006-01-11 18:42:13 -08:00
Kconfig
[PATCH] Mark CONFIG_UFS_FS_WRITE as BROKEN
2006-02-01 08:53:14 -08:00
Kconfig.binfmt
[PATCH] frv: suppress configuration of certain features for FRV
2006-01-08 20:13:36 -08:00
libfs.c
[PATCH] mutex subsystem, semaphore to mutex: VFS, ->i_sem
2006-01-09 15:59:24 -08:00
locks.c
[PATCH] tiny: Uninline some fslocks.c functions
2006-01-08 20:14:10 -08:00
Makefile
[PATCH] sanitize building of fs/compat_ioctl.c
2006-01-10 08:01:33 -08:00
mbcache.c
[PATCH] Unlinline a bunch of other functions
2006-01-14 18:27:06 -08:00
mpage.c
[PATCH] fix possible PAGE_CACHE_SHIFT overflows
2006-01-08 20:13:54 -08:00
namei.c
[PATCH] DocBook: fix some kernel-doc comments in fs and block
2006-02-01 08:53:27 -08:00
namespace.c
[PATCH] add /sys/fs
2006-01-16 23:15:29 -08:00
nfsctl.c
[PATCH] EDAC: atomic scrub operations
2006-01-18 19:20:30 -08:00
open.c
[PATCH] vfs: *at functions: core
2006-01-18 19:20:29 -08:00
pipe.c
[PATCH] Unlinline a bunch of other functions
2006-01-14 18:27:06 -08:00
pnode.c
[PATCH] shared mounts: cleanup
2006-01-08 20:13:56 -08:00
pnode.h
[PATCH] unbindable mounts
2005-11-07 18:18:11 -08:00
posix_acl.c
[PATCH] gfp flags annotations - part 1
2005-10-08 15:00:57 -07:00
quota_v1.c
Linux-2.6.12-rc2
2005-04-16 15:20:36 -07:00
quota_v2.c
[PATCH] quota_v2: printk warning fixes
2006-02-03 08:32:03 -08:00
quota.c
[PATCH] capable/capability.h (fs/)
2006-01-11 18:42:13 -08:00
read_write.c
[PATCH] mutex subsystem, semaphore to mutex: VFS, ->i_sem
2006-01-09 15:59:24 -08:00
readdir.c
[PATCH] mutex subsystem, semaphore to mutex: VFS, ->i_sem
2006-01-09 15:59:24 -08:00
select.c
[PATCH] Add pselect/ppoll system call implementation
2006-01-18 19:20:30 -08:00
seq_file.c
[PATCH] allow callers of seq_open do allocation themselves
2005-11-07 18:18:09 -08:00
stat.c
[PATCH] vfs: *at functions: core
2006-01-18 19:20:29 -08:00
super.c
[PATCH] mutex subsystem, semaphore to mutex: VFS, sb->s_lock
2006-01-09 15:59:25 -08:00
xattr_acl.c
Linux-2.6.12-rc2
2005-04-16 15:20:36 -07:00
xattr.c
[PATCH] move xattr permission checks into the VFS
2006-01-10 08:01:29 -08:00