Jan Kara 7f5aa21508 jbd2: Avoid possible NULL dereference in jbd2_journal_begin_ordered_truncate()
If we race with commit code setting i_transaction to NULL, we could
possibly dereference it.  Proper locking requires the journal pointer
(to access journal->j_list_lock), which we don't have.  So we have to
change the prototype of the function so that filesystem passes us the
journal pointer.  Also add a more detailed comment about why the
function jbd2_journal_begin_ordered_truncate() does what it does and
how it should be used.

Thanks to Dan Carpenter <error27@gmail.com> for pointing to the
suspitious code.

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Acked-by: Joel Becker <joel.becker@oracle.com>
CC: linux-ext4@vger.kernel.org
CC: ocfs2-devel@oss.oracle.com
CC: mfasheh@suse.de
CC: Dan Carpenter <error27@gmail.com>
2009-02-10 11:15:34 -05:00
..
2009-01-22 13:16:01 +03:00
2009-01-22 13:15:56 +03:00
2009-01-22 13:15:56 +03:00
2009-01-22 13:16:01 +03:00
2009-01-22 13:15:57 +03:00
2009-01-22 13:15:57 +03:00
2009-02-09 16:22:03 -05:00
2009-01-22 13:16:01 +03:00
2009-01-22 13:15:58 +03:00
2009-01-22 13:15:57 +03:00
2009-01-22 13:15:55 +03:00
2009-01-22 13:15:58 +03:00
2009-01-22 13:15:57 +03:00
2009-01-22 13:15:57 +03:00
2009-01-22 13:15:59 +03:00
2008-11-14 10:39:25 +11:00
2009-01-22 13:15:55 +03:00
2009-01-09 21:05:21 +00:00
2009-01-22 13:15:54 +03:00
2009-01-22 13:15:58 +03:00
2009-01-22 13:16:00 +03:00
2008-10-17 02:38:36 +11:00
2009-01-22 13:15:55 +03:00
2009-01-22 13:15:58 +03:00
2009-01-22 13:15:59 +03:00
2009-01-22 13:15:53 +03:00
2009-01-22 13:15:59 +03:00
2009-01-22 13:16:01 +03:00
2009-01-22 13:15:58 +03:00
2009-01-22 13:15:59 +03:00
2009-01-29 16:34:30 +02:00
2009-01-22 13:15:55 +03:00
2009-01-22 13:16:00 +03:00
2008-12-31 18:07:43 -05:00
2009-01-03 11:45:54 -08:00
2009-02-06 17:34:07 -08:00
2009-01-30 12:34:36 +01:00
2008-01-30 13:31:46 +01:00
2009-02-05 16:35:52 -08:00
2009-02-07 08:46:18 +11:00
2009-01-16 18:02:10 +01:00
2009-02-07 08:46:18 +11:00
2009-01-06 15:59:09 -08:00
2009-02-07 08:46:18 +11:00
2009-01-22 13:16:01 +03:00