iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/kernel
History
Lorenzo Bianconi c576b9c77b bpf: cpumap: Fix possible rcpu kthread hung 
Fix the following cpumap kthread hung. The issue is currently occurring
when __cpu_map_load_bpf_program fails (e.g if the bpf prog has not
BPF_XDP_CPUMAP as expected_attach_type)

$./test_progs -n 101
101/1 cpumap_with_progs:OK
101 xdp_cpumap_attach:OK
Summary: 1/1 PASSED, 0 SKIPPED, 0 FAILED
[  369.996478] INFO: task cpumap/0/map:7:205 blocked for more than 122 seconds.
[  369.998463]       Not tainted 5.8.0-rc4-01472-ge57892f50a07 #212
[  370.000102] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
[  370.001918] cpumap/0/map:7  D    0   205      2 0x00004000
[  370.003228] Call Trace:
[  370.003930]  __schedule+0x5c7/0xf50
[  370.004901]  ? io_schedule_timeout+0xb0/0xb0
[  370.005934]  ? static_obj+0x31/0x80
[  370.006788]  ? mark_held_locks+0x24/0x90
[  370.007752]  ? cpu_map_bpf_prog_run_xdp+0x6c0/0x6c0
[  370.008930]  schedule+0x6f/0x160
[  370.009728]  schedule_preempt_disabled+0x14/0x20
[  370.010829]  kthread+0x17b/0x240
[  370.011433]  ? kthread_create_worker_on_cpu+0xd0/0xd0
[  370.011944]  ret_from_fork+0x1f/0x30
[  370.012348]
               Showing all locks held in the system:
[  370.013025] 1 lock held by khungtaskd/33:
[  370.013432]  #0: ffffffff82b24720 (rcu_read_lock){....}-{1:2}, at: debug_show_all_locks+0x28/0x1c3

[  370.014461] =============================================

Fixes: 9216477449f3 ("bpf: cpumap: Add the possibility to attach an eBPF program to cpumap")
Reported-by: Jakub Sitnicki <jakub@cloudflare.com>
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Tested-by: Jakub Sitnicki <jakub@cloudflare.com>
Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com>
Link: https://lore.kernel.org/bpf/e54f2aabf959f298939e5507b09c48f8c2e380be.1595170625.git.lorenzo@kernel.org
2020-07-21 09:15:28 -07:00
..
bpf
bpf: cpumap: Fix possible rcpu kthread hung
2020-07-21 09:15:28 -07:00
cgroup
cgroup: fix cgroup_sk_alloc() for sk_clone_lock()
2020-07-07 13:34:11 -07:00
configs
compiler: remove CONFIG_OPTIMIZE_INLINING entirely
2020-04-07 10:43:42 -07:00
debug
kgdb: Avoid suspicious RCU usage warning
2020-06-26 15:41:40 +01:00
dma
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-07-10 18:16:22 -07:00
events
perf: Expose get/put_callchain_entry()
2020-07-01 08:22:08 -07:00
gcov
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
irq
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
kcsan
kcsan: Support distinguishing volatile accesses
2020-06-11 20:04:01 +02:00
livepatch
livepatch: Make klp_apply_object_relocs static
2020-05-11 00:31:38 +02:00
locking
The X86 entry, exception and interrupt code rework
2020-06-13 10:05:47 -07:00
power
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
printk
Revert "kernel/printk: add kmsg SEEK_CUR handling"
2020-06-21 20:47:20 -07:00
rcu
A single fix for a printk format warning in RCU.
2020-07-05 12:21:28 -07:00
sched
Peter Zijlstra says:
2020-06-28 10:37:39 -07:00
time
The X86 entry, exception and interrupt code rework
2020-06-13 10:05:47 -07:00
trace
bpf: Use dedicated bpf_trace_printk event instead of trace_printk()
2020-07-13 16:55:49 -07:00
.gitignore
.gitignore: add SPDX License Identifier
2020-03-25 11:50:48 +01:00
acct.c
mmap locking API: convert mmap_sem comments
2020-06-09 09:39:14 -07:00
async.c
…
audit_fsnotify.c
fsnotify: use helpers to access data by data_type
2020-03-23 18:19:06 +01:00
audit_tree.c
…
audit_watch.c
\n
2020-04-06 08:58:42 -07:00
audit.c
audit/stable-5.8 PR 20200601
2020-06-02 17:13:37 -07:00
audit.h
audit: fix a net reference leak in audit_list_rules_send()
2020-04-22 15:23:10 -04:00
auditfilter.c
audit: fix a net reference leak in audit_list_rules_send()
2020-04-22 15:23:10 -04:00
auditsc.c
audit: add subj creds to NETFILTER_CFG record to
2020-05-20 18:09:19 -04:00
backtracetest.c
…
bounds.c
…
capability.c
…
compat.c
uaccess: Selectively open read or write user access
2020-05-01 12:35:21 +10:00
configs.c
proc: convert everything to "struct proc_ops"
2020-02-04 03:05:26 +00:00
context_tracking.c
context_tracking: Ensure that the critical path cannot be instrumented
2020-06-11 15:14:36 +02:00
cpu_pm.c
kernel/cpu_pm: Fix uninitted local in cpu_pm
2020-05-15 11:44:34 -07:00
cpu.c
The changes in this cycle are:
2020-06-03 13:06:42 -07:00
crash_core.c
…
crash_dump.c
crash_dump: Remove no longer used saved_max_pfn
2020-04-15 11:21:54 +02:00
cred.c
exec: Teach prepare_exec_creds how exec treats uids & gids
2020-05-20 14:44:21 -05:00
delayacct.c
…
dma.c
…
elfcore.c
…
exec_domain.c
…
exit.c
umd: Remove exit_umh
2020-07-07 11:58:59 -05:00
extable.c
kernel/extable.c: use address-of operator on section symbols
2020-04-07 10:43:42 -07:00
fail_function.c
…
fork.c
Merge branch 'usermode-driver-cleanup' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace into bpf-next
2020-07-14 12:18:01 -07:00
freezer.c
…
futex.c
mmap locking API: use coccinelle to convert mmap_sem rwsem call sites
2020-06-09 09:39:14 -07:00
gen_kheaders.sh
kbuild: add variables for compression tools
2020-06-06 23:42:01 +09:00
groups.c
mm: remove the pgprot argument to __vmalloc
2020-06-02 10:59:11 -07:00
hung_task.c
kernel/hung_task.c: introduce sysctl to print all traces when a hung task is detected
2020-06-08 11:05:56 -07:00
iomem.c
…
irq_work.c
irq_work, smp: Allow irq_work on call_single_queue
2020-05-28 10:54:15 +02:00
jump_label.c
…
kallsyms.c
kallsyms: Refactor kallsyms_show_value() to take cred
2020-07-08 15:59:57 -07:00
kcmp.c
kernel/kcmp.c: Use new infrastructure to fix deadlocks in execve
2020-03-25 10:04:01 -05:00
Kconfig.freezer
…
Kconfig.hz
…
Kconfig.locks
sched/rt, locking: Use CONFIG_PREEMPTION
2019-12-08 14:37:36 +01:00
Kconfig.preempt
…
kcov.c
kcov: check kcov_softirq in kcov_remote_stop()
2020-06-10 19:14:17 -07:00
kexec_core.c
kexec: add machine_kexec_post_load()
2020-01-08 16:32:55 +00:00
kexec_elf.c
…
kexec_file.c
kexec: do not verify the signature without the lockdown or mandatory signature
2020-06-26 00:27:36 -07:00
kexec_internal.h
kexec: add machine_kexec_post_load()
2020-01-08 16:32:55 +00:00
kexec.c
kexec: add machine_kexec_post_load()
2020-01-08 16:32:55 +00:00
kheaders.c
…
kmod.c
kmod: make request_module() return an error when autoloading is disabled
2020-04-10 15:36:22 -07:00
kprobes.c
kprobes: Do not expose probe addresses to non-CAP_SYSLOG
2020-07-08 16:00:22 -07:00
ksysfs.c
…
kthread.c
maccess: rename probe_kernel_{read,write} to copy_{from,to}_kernel_nofault
2020-06-17 10:57:41 -07:00
latencytop.c
sysctl: pass kernel pointers to ->proc_handler
2020-04-27 02:07:40 -04:00
Makefile
umh: Separate the user mode driver and the user mode helper support
2020-07-04 09:34:32 -05:00
module_signature.c
…
module_signing.c
…
module-internal.h
…
module.c
Refactor kallsyms_show_value() users for correct cred
2020-07-09 13:09:30 -07:00
notifier.c
mm: remove vmalloc_sync_(un)mappings()
2020-06-02 10:59:12 -07:00
nsproxy.c
nsproxy: restore EINVAL for non-namespace file descriptor
2020-06-17 00:33:12 +02:00
padata.c
padata: upgrade smp_mb__after_atomic to smp_mb in padata_do_serial
2020-06-18 17:09:54 +10:00
panic.c
bug: Annotate WARN/BUG/stackfail as noinstr safe
2020-06-11 15:14:36 +02:00
params.c
…
pid_namespace.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
2020-06-03 16:27:18 -07:00
pid.c
remove the no longer needed pid_alive() check in __task_pid_nr_ns()
2020-04-30 06:40:14 -05:00
profile.c
proc: convert everything to "struct proc_ops"
2020-02-04 03:05:26 +00:00
ptrace.c
ptrace: reintroduce usage of subjective credentials in ptrace_has_cap()
2020-01-18 13:51:39 +01:00
range.c
…
reboot.c
printk: Collapse shutdown types into a single dump reason
2020-05-30 10:34:03 -07:00
relay.c
mmap locking API: convert mmap_sem comments
2020-06-09 09:39:14 -07:00
resource.c
/dev/mem: Revoke mappings when a driver claims the region
2020-05-27 11:10:05 +02:00
rseq.c
rseq: Reject unknown flags on rseq unregister
2019-12-25 10:41:20 +01:00
scs.c
scs: Report SCS usage in bytes rather than number of entries
2020-06-04 16:14:56 +01:00
seccomp.c
sysctl: pass kernel pointers to ->proc_handler
2020-04-27 02:07:40 -04:00
signal.c
task_work: teach task_work_add() to do signal_wake_up()
2020-06-30 12:18:08 -06:00
smp.c
smp, irq_work: Continue smp_call_function*() and irq_work*() integration
2020-06-28 17:01:20 +02:00
smpboot.c
…
smpboot.h
…
softirq.c
x86/entry: Clarify irq_{enter,exit}_rcu()
2020-06-11 15:15:24 +02:00
stackleak.c
…
stacktrace.c
…
stop_machine.c
stop_machine: Make stop_cpus() static
2020-01-17 10:19:21 +01:00
sys_ni.c
…
sys.c
Add additional LSM hooks for SafeSetID
2020-06-14 11:39:31 -07:00
sysctl_binary.c
sysctl: Remove the sysctl system call
2019-11-26 13:03:56 -06:00
sysctl-test.c
kunit: allow kunit tests to be loaded as a module
2020-01-09 16:42:29 -07:00
sysctl.c
kernel/sysctl.c: ignore out-of-range taint bits introduced via kernel.tainted
2020-06-08 11:05:56 -07:00
task_work.c
task_work: teach task_work_add() to do signal_wake_up()
2020-06-30 12:18:08 -06:00
taskstats.c
taskstats: fix data-race
2019-12-04 15:18:39 +01:00
test_kprobes.c
…
torture.c
CPU (hotplug) updates:
2020-03-30 18:06:39 -07:00
tracepoint.c
…
tsacct.c
tsacct: add 64-bit btime field
2019-12-18 18:07:31 +01:00
ucount.c
ucount: Make sure ucounts in /proc/sys/user don't regress again
2020-04-07 21:51:27 +02:00
uid16.c
…
uid16.h
…
umh.c
umh: Stop calling do_execve_file
2020-07-04 09:35:36 -05:00
up.c
smp/up: Make smp_call_function_single() match SMP semantics
2020-02-07 15:34:12 +01:00
user_namespace.c
nsproxy: add struct nsset
2020-05-09 13:57:12 +02:00
user-return-notifier.c
…
user.c
user.c: make uidhash_table static
2020-06-04 19:06:24 -07:00
usermode_driver.c
umd: Stop using split_argv
2020-07-07 11:58:59 -05:00
utsname_sysctl.c
sysctl: pass kernel pointers to ->proc_handler
2020-04-27 02:07:40 -04:00
utsname.c
nsproxy: add struct nsset
2020-05-09 13:57:12 +02:00
watch_queue.c
Notifications over pipes + Keyring notifications
2020-06-13 09:56:21 -07:00
watchdog_hld.c
…
watchdog.c
kernel/watchdog.c: convert {soft/hard}lockup boot parameters to sysctl aliases
2020-06-08 11:05:56 -07:00
workqueue_internal.h
…
workqueue.c
maccess: rename probe_kernel_{read,write} to copy_{from,to}_kernel_nofault
2020-06-17 10:57:41 -07:00