iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/scsi
History
James Smart 807e7353d8 scsi: lpfc: Fix crash in target side cable pulls hitting WAIT_FOR_UNREG 
Kernel is crashing with the following stacktrace:

  BUG: unable to handle kernel NULL pointer dereference at
    00000000000005bc
  IP: lpfc_nvme_register_port+0x1a8/0x3a0 [lpfc]
  ...
  Call Trace:
  lpfc_nlp_state_cleanup+0x2b2/0x500 [lpfc]
  lpfc_nlp_set_state+0xd7/0x1a0 [lpfc]
  lpfc_cmpl_prli_prli_issue+0x1f7/0x450 [lpfc]
  lpfc_disc_state_machine+0x7a/0x1e0 [lpfc]
  lpfc_cmpl_els_prli+0x16f/0x1e0 [lpfc]
  lpfc_sli_sp_handle_rspiocb+0x5b2/0x690 [lpfc]
  lpfc_sli_handle_slow_ring_event_s4+0x182/0x230 [lpfc]
  lpfc_do_work+0x87f/0x1570 [lpfc]
  kthread+0x10d/0x130
  ret_from_fork+0x35/0x40

During target side fault injections, it is possible to hit the
NLP_WAIT_FOR_UNREG case in lpfc_nvme_remoteport_delete. A prior commit
fixed a rebind and delete race condition, but called lpfc_nlp_put
unconditionally. This triggered a deletion and the crash.

Fix by movng nlp_put to inside the NLP_WAIT_FOR_UNREG case, where the nlp
will be being unregistered/removed. Leave the reference if the flag isn't
set.

Link: https://lore.kernel.org/r/20200322181304.37655-8-jsmart2021@gmail.com
Fixes: b15bd3e6212e ("scsi: lpfc: Fix nvme remoteport registration race conditions")
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2020-03-26 23:15:10 -04:00
..
aacraid
scsi: aacraid: Use scnprintf() for avoiding potential buffer overflow
2020-03-17 13:36:09 -04:00
aic7xxx
scsi: aic7xxx: aic97xx: Remove FreeBSD-specific code
2020-03-26 23:00:14 -04:00
aic94xx
compat_ioctl: scsi: handle HDIO commands from drivers
2020-01-03 09:42:52 +01:00
arcmsr
scsi: docs: convert arcmsr_spec.txt to ReST
2020-03-11 23:08:03 -04:00
arm
scsi: Fix various misspellings of "connect"
2019-10-24 21:22:32 -04:00
be2iscsi
scsi: be2iscsi: Use scnprintf() for avoiding potential buffer overflow
2020-03-17 13:36:09 -04:00
bfa
scsi: bfa: Make restart_bfa static
2019-09-30 23:59:53 -04:00
bnx2fc
remove ioremap_nocache and devm_ioremap_nocache
2020-01-06 09:45:59 +01:00
bnx2i
remove ioremap_nocache and devm_ioremap_nocache
2020-01-06 09:45:59 +01:00
csiostor
SCSI misc on 20200129
2020-01-29 18:16:16 -08:00
cxgbi
SCSI fixes on 20191227
2019-12-27 17:28:41 -08:00
cxlflash
SCSI misc on 20191130
2019-12-02 13:37:02 -08:00
device_handler
SCSI fixes on 20191101
2019-11-07 06:43:18 -07:00
dpt
scsi: docs: convert dpti.txt to ReST
2020-03-11 23:07:59 -04:00
esas2r
proc: convert everything to "struct proc_ops"
2020-02-04 03:05:26 +00:00
fcoe
SCSI misc on 20190919
2019-09-21 10:50:15 -07:00
fnic
scsi: fnic: Use scnprintf() for avoiding potential buffer overflow
2020-03-17 13:36:10 -04:00
hisi_sas
scsi: hisi_sas: Use dev_err() in read_iost_itct_cache_v3_hw()
2020-03-16 18:24:23 -04:00
ibmvscsi
scsi: ibmvfc: Fix NULL return compiler warning
2020-03-11 23:07:57 -04:00
ibmvscsi_tgt
scsi: ibmvscsi_tgt: remove set but not used variables 'iue' and 'sd'
2019-12-19 22:08:54 -05:00
isci
scsi: Replace zero-length array with flexible-array member
2020-03-11 23:07:56 -04:00
libfc
scsi: fcoe: Embed fc_rport_priv in fcoe_rport structure
2019-07-29 21:12:35 -04:00
libsas
scsi: libsas: Tidy SAS address print format
2019-12-21 13:42:42 -05:00
lpfc
scsi: lpfc: Fix crash in target side cable pulls hitting WAIT_FOR_UNREG
2020-03-26 23:15:10 -04:00
megaraid
scsi: megaraid_sas: Use scnprintf() for avoiding potential buffer overflow
2020-03-17 13:36:12 -04:00
mpt3sas
scsi: Replace zero-length array with flexible-array member
2020-03-11 23:07:56 -04:00
mvsas
scsi: Replace zero-length array with flexible-array member
2020-03-11 23:07:56 -04:00
pcmcia
scsi: docs: convert NinjaSCSI.txt to ReST
2020-03-11 23:08:01 -04:00
pm8001
scsi: pm80xx: Introduce read and write length for IOCTL payload structure
2020-03-17 13:57:19 -04:00
qedf
scsi: Fix various misspellings of "connect"
2019-10-24 21:22:32 -04:00
qedi
scsi: qedi: Add PCI shutdown handler support
2020-03-26 22:38:54 -04:00
qla2xxx
scsi: qla2xxx: Remove non functional code
2020-03-26 21:07:29 -04:00
qla4xxx
scsi: qla4xxx: Adjust indentation in qla4xxx_mem_free
2019-12-19 22:08:55 -05:00
smartpqi
scsi: smartpqi: Use scnprintf() for avoiding potential buffer overflow
2020-03-17 13:36:13 -04:00
snic
scsi: Replace zero-length array with flexible-array member
2020-03-11 23:07:56 -04:00
sym53c8xx_2
scsi: sym53c8xx: fix typos in comments
2019-12-19 22:08:54 -05:00
ufs
scsi: ufs: Do not rely on prefetched data
2020-03-26 22:56:33 -04:00
.gitignore
…
3w-9xxx.c
scsi: 3w-9xxx: fix calls to dma_set_mask_and_coherent()
2019-02-25 21:37:25 -05:00
3w-9xxx.h
…
3w-sas.c
SCSI fixes on 20190302
2019-03-02 11:39:54 -08:00
3w-sas.h
…
3w-xxxx.c
compat_ioctl: move more drivers to compat_ptr_ioctl
2019-10-23 17:23:44 +02:00
3w-xxxx.h
scsi: 3w-xxx: fully convert to the generic DMA API
2018-10-17 21:58:51 -04:00
53c700_d.h_shipped
…
53c700.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61
2019-05-24 17:36:45 +02:00
53c700.h
scsi: 53c700: Fix spelling of 'NEGOTIATION'
2018-08-30 07:27:22 -04:00
53c700.scr
…
a100u2w.c
cross-tree: phase out dma_zalloc_coherent()
2019-01-08 07:58:37 -05:00
a100u2w.h
…
a2091.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
a2091.h
…
a3000.c
scsi: Use pr_warn instead of pr_warning
2019-10-18 15:01:54 +02:00
a3000.h
…
a4000t.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
advansys.c
scsi: advansys: Replace zero-length array with flexible-array member
2020-02-18 00:39:54 -05:00
aha152x.c
scsi: docs: convert aha152x.txt to ReST
2020-03-11 23:07:58 -04:00
aha152x.h
…
aha1542.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
aha1542.h
…
aha1740.c
scsi: aha1740: Fix an errro handling path in aha1740_probe()
2020-03-26 21:10:53 -04:00
aha1740.h
…
am53c974.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
atari_scsi.c
scsi: atari_scsi: sun3_scsi: Set sg_tablesize to 1 instead of SG_NONE
2019-11-12 22:21:34 -05:00
atp870u.c
scsi: core: Clean up SG_NONE
2019-11-12 22:21:35 -05:00
atp870u.h
…
BusLogic.c
scsi: docs: convert BusLogic.txt to ReST
2020-03-11 23:07:59 -04:00
BusLogic.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 388
2019-06-05 17:37:11 +02:00
bvme6000_scsi.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
ch.c
scsi: ch: remove ch_mutex()
2020-02-24 14:54:25 -05:00
constants.c
…
dc395x.c
scsi: dc395x: remove dc395x_bios_param
2020-03-26 22:51:18 -04:00
dc395x.h
…
dmx3191d.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61
2019-05-24 17:36:45 +02:00
dpt_i2o.c
scsi: docs: convert dpti.txt to ReST
2020-03-11 23:07:59 -04:00
dpti.h
scsi: docs: convert dpti.txt to ReST
2020-03-11 23:07:59 -04:00
esp_scsi.c
scsi: esp_scsi: Add support for FSC chip
2019-12-19 22:08:51 -05:00
esp_scsi.h
scsi: esp_scsi: Add support for FSC chip
2019-12-19 22:08:51 -05:00
fdomain_isa.c
scsi: fdomain_isa: use CFG1_IRQ_MASK
2019-07-30 12:18:24 -04:00
fdomain_pci.c
scsi: fdomain: Resurrect driver - PCI support
2019-06-18 19:46:18 -04:00
fdomain.c
scsi: fdomain: use BSTAT_{MSG|CMD|IO} in fdomain_work()
2019-07-30 12:17:28 -04:00
fdomain.h
scsi: fdomain: Add register definitions
2019-06-18 19:46:22 -04:00
FlashPoint.c
scsi: FlashPoint: Remove unnecessary parentheses
2018-09-25 20:45:53 -04:00
g_NCR5380.c
scsi: docs: convert g_NCR5380.txt to ReST
2020-03-11 23:08:00 -04:00
gdth_ioctl.h
scsi: gdth: remove dead code under #ifdef GDTH_IOCTL_PROC
2019-01-08 21:58:35 -05:00
gdth_proc.c
scsi: gdth: Use scnprintf() for avoiding potential buffer overflow
2020-03-17 13:36:10 -04:00
gdth_proc.h
scsi: gdth: remove gdth_{alloc,free}_ioctl
2019-01-08 21:57:42 -05:00
gdth.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 148
2019-05-30 11:25:18 -07:00
gdth.h
scsi: gdth: remove ISA and EISA support
2019-01-08 21:58:35 -05:00
gvp11.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
gvp11.h
…
hosts.c
scsi: core: add scsi_host_busy_iter()
2020-02-28 20:54:52 -05:00
hpsa_cmd.h
SCSI misc on 20190709
2019-07-11 15:14:01 -07:00
hpsa.c
scsi: hpsa: correct race condition in offload enabled
2020-03-26 22:44:41 -04:00
hpsa.h
scsi: hpsa: correct device resets
2019-06-18 19:46:18 -04:00
hptiop.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 285
2019-06-05 17:36:37 +02:00
hptiop.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 285
2019-06-05 17:36:37 +02:00
imm.c
SCSI sg on 20190709
2019-07-11 15:17:41 -07:00
imm.h
…
initio.c
scsi: initio: make initio_state_7() static
2019-12-19 22:08:54 -05:00
initio.h
…
ipr.c
scsi: ipr: Use scnprintf() for avoiding potential buffer overflow
2020-03-17 13:36:11 -04:00
ipr.h
scsi: Replace zero-length array with flexible-array member
2020-03-11 23:07:56 -04:00
ips.c
scsi: ips: make array 'options' static const, makes object smaller
2019-09-30 22:46:40 -04:00
ips.h
scsi: ips: properly handle 64-bit DMA
2018-11-06 21:31:28 -05:00
iscsi_boot_sysfs.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 287
2019-06-05 17:36:37 +02:00
iscsi_tcp.c
scsi: iscsi: Don't destroy session if there are outstanding connections
2020-01-15 22:48:34 -05:00
iscsi_tcp.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157
2019-05-30 11:26:37 -07:00
jazz_esp.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
Kconfig
scsi: docs: convert sym53c8xx_2.txt to ReST
2020-03-11 23:08:03 -04:00
lasi700.c
remove ioremap_nocache and devm_ioremap_nocache
2020-01-06 09:45:59 +01:00
libiscsi_tcp.c
SCSI misc on 20190709
2019-07-11 15:14:01 -07:00
libiscsi.c
scsi: libiscsi: Fix error count for active session
2020-03-26 22:48:58 -04:00
mac53c94.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
mac53c94.h
…
mac_esp.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
mac_scsi.c
scsi: atari_scsi: sun3_scsi: Set sg_tablesize to 1 instead of SG_NONE
2019-11-12 22:21:34 -05:00
Makefile
scsi: remove pointless $(MODVERDIR)/$(obj)/53c700.ver
2019-07-17 22:39:27 +09:00
megaraid.c
scsi: megaraid: disable device when probe failed after enabled device
2019-09-23 23:09:42 -04:00
megaraid.h
…
mesh.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
mesh.h
…
mvme16x_scsi.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
mvme147.c
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
mvme147.h
…
mvumi.c
SCSI sg on 20190709
2019-07-11 15:17:41 -07:00
mvumi.h
scsi: Replace zero-length array with flexible-array member
2020-03-11 23:07:56 -04:00
myrb.c
remove ioremap_nocache and devm_ioremap_nocache
2020-01-06 09:45:59 +01:00
myrb.h
scsi: mylex: Use the correct style for SPDX License Identifier
2020-01-02 21:57:44 -05:00
myrs.c
remove ioremap_nocache and devm_ioremap_nocache
2020-01-06 09:45:59 +01:00
myrs.h
scsi: mylex: Use the correct style for SPDX License Identifier
2020-01-02 21:57:44 -05:00
ncr53c8xx.c
scsi: docs: convert ncr53c8xx.txt to ReST
2020-03-11 23:08:01 -04:00
ncr53c8xx.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61
2019-05-24 17:36:45 +02:00
NCR5380.c
scsi: NCR5380: Add disconnect_mask module parameter
2019-11-19 21:37:34 -05:00
NCR5380.h
Revert "scsi: ncr5380: Increase register polling limit"
2019-06-20 15:37:02 -04:00
nsp32_debug.c
…
nsp32_io.h
…
nsp32.c
scsi: Fix various misspellings of "connect"
2019-10-24 21:22:32 -04:00
nsp32.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 118
2019-05-24 17:39:02 +02:00
pmcraid.c
compat_ioctl: move more drivers to compat_ptr_ioctl
2019-10-23 17:23:44 +02:00
pmcraid.h
scsi: Replace zero-length array with flexible-array member
2020-03-11 23:07:56 -04:00
ppa.c
scsi: ppa: use sg helper to iterate over scatterlist
2019-06-20 15:21:33 -04:00
ppa.h
…
ps3rom.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 164
2019-05-30 11:26:38 -07:00
qla1280.c
scsi: qla1280: Make checking for 64bit support consistent
2020-01-20 18:35:55 -05:00
qla1280.h
scsi: qla1280: Fix dma firmware download, if dma address is 64bit
2020-01-15 23:09:11 -05:00
qlogicfas408.c
scsi: qlogicfas408: clean up a couple of indentation issues
2019-03-19 17:11:37 -04:00
qlogicfas408.h
…
qlogicfas.c
scsi: remove the use_clustering flag
2018-12-18 23:19:21 -05:00
qlogicpti.c
scsi: qlogicpti: Mark expected switch fall-throughs
2019-08-07 21:32:53 -04:00
qlogicpti.h
scsi: qlogicpti: Use of_node_name_eq for node name comparisons
2019-02-13 22:07:03 -05:00
raid_class.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 437
2019-06-05 17:37:17 +02:00
script_asm.pl
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61
2019-05-24 17:36:45 +02:00
scsi_common.c
…
scsi_debug.c
scsi: scsi_debug: num_tgts must be >= 0
2019-11-19 21:37:34 -05:00
scsi_debugfs.c
scsi: scsi_debugfs: Use for_each_set_bit to simplify code
2019-07-30 12:42:55 -04:00
scsi_debugfs.h
scsi: core: add SPDX tags to scsi midlayer files missing licensing information
2019-05-21 06:16:21 -04:00
scsi_devinfo.c
proc: convert everything to "struct proc_ops"
2020-02-04 03:05:26 +00:00
scsi_dh.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
scsi_error.c
scsi: core: Remove cmd_list functionality
2020-02-28 20:54:55 -05:00
scsi_ioctl.c
compat_ioctl: add scsi_compat_ioctl
2020-01-03 09:33:18 +01:00
scsi_lib_dma.c
…
scsi_lib.c
scsi: core: avoid repetitive logging of device offline messages
2020-03-11 23:09:27 -04:00
scsi_logging.c
scsi: core: Log SCSI command age with errors
2019-09-30 23:07:16 -04:00
scsi_logging.h
scsi: core: Fix a compiler warning triggered by the SCSI logging code
2019-12-19 22:08:54 -05:00
scsi_netlink.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
scsi_pm.c
scsi: core: remove dummy q->dev check
2019-09-12 07:11:58 -06:00
scsi_priv.h
scsi: core: Remove cmd_list functionality
2020-02-28 20:54:55 -05:00
scsi_proc.c
proc: convert everything to "struct proc_ops"
2020-02-04 03:05:26 +00:00
scsi_sas_internal.h
…
scsi_scan.c
scsi: core: Remove cmd_list functionality
2020-02-28 20:54:55 -05:00
scsi_sysctl.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 209
2019-05-30 11:29:53 -07:00
scsi_sysfs.c
scsi: core: Use scnprintf() for avoiding potential buffer overflow
2020-03-17 13:36:12 -04:00
scsi_trace.c
scsi: scsi_trace: Use get_unaligned_be24()
2020-03-16 22:08:36 -04:00
scsi_transport_api.h
…
scsi_transport_fc.c
SCSI misc on 20190709
2019-07-11 15:14:01 -07:00
scsi_transport_iscsi.c
scsi: iscsi: Report connection state in sysfs
2020-03-26 21:59:20 -04:00
scsi_transport_sas.c
scsi: scsi_transport_sas: Fix memory leak when removing devices
2019-11-21 21:12:39 -05:00
scsi_transport_spi.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
scsi_transport_srp.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 502
2019-06-19 17:09:56 +02:00
scsi.c
scsi: core: Remove cmd_list functionality
2020-02-28 20:54:55 -05:00
scsi.h
…
scsicam.c
…
sd_dif.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 410
2019-06-05 17:37:14 +02:00
sd_zbc.c
scsi: sd_zbc: Rename sd_zbc_check_zones()
2020-01-02 21:53:31 -05:00
sd.c
SCSI misc on 20200129
2020-01-29 18:16:16 -08:00
sd.h
SCSI misc on 20191207
2019-12-08 12:23:42 -08:00
sense_codes.h
…
ses.c
SCSI misc on 20190709
2019-07-11 15:14:01 -07:00
sg.c
proc: convert everything to "struct proc_ops"
2020-02-04 03:05:26 +00:00
sgiwd93.c
scsi: remove the use_clustering flag
2018-12-18 23:19:21 -05:00
sim710.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61
2019-05-24 17:36:45 +02:00
sni_53c710.c
remove ioremap_nocache and devm_ioremap_nocache
2020-01-06 09:45:59 +01:00
sr_ioctl.c
…
sr_vendor.c
scsi: sr: remove references to BLK_DEV_SR_VENDOR, leave it enabled
2020-02-24 14:59:01 -05:00
sr.c
scsi: sr: get rid of sr global mutex
2020-02-24 15:01:57 -05:00
sr.h
scsi: sr: get rid of sr global mutex
2020-02-24 15:01:57 -05:00
st_options.h
…
st.c
scsi: st: Use get_unaligned_be24() and sign_extend32()
2020-03-16 22:08:34 -04:00
st.h
…
stex.c
scsi: Replace zero-length array with flexible-array member
2020-03-11 23:07:56 -04:00
storvsc_drv.c
scsi: storvsc: Correctly set number of hardware queues for IDE disk
2020-01-15 23:02:24 -05:00
sun3_scsi_vme.c
…
sun3_scsi.c
scsi: atari_scsi: sun3_scsi: Set sg_tablesize to 1 instead of SG_NONE
2019-11-12 22:21:34 -05:00
sun3x_esp.c
remove ioremap_nocache and devm_ioremap_nocache
2020-01-06 09:45:59 +01:00
sun_esp.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
virtio_scsi.c
scsi: core: remove .for_blk_mq
2020-02-10 22:46:55 -05:00
vmw_pvscsi.c
scsi: vmw_pvscsi: Silence dma mapping errors
2019-12-19 22:42:44 -05:00
vmw_pvscsi.h
…
wd33c93.c
scsi: wd33c93: Mark expected switch fall-through
2019-08-07 21:35:59 -04:00
wd33c93.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 118
2019-05-24 17:39:02 +02:00
wd719x.c
SCSI misc on 20190709
2019-07-11 15:14:01 -07:00
wd719x.h
scsi: wd719x: use per-command private data
2018-11-15 14:27:08 -05:00
xen-scsifront.c
scsi: xen-scsifront: remove DISABLE_CLUSTERING
2018-12-18 23:13:12 -05:00
zalon.c
remove ioremap_nocache and devm_ioremap_nocache
2020-01-06 09:45:59 +01:00
zorro7xx.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
zorro_esp.c
scsi: zorro_esp: Restore devm_ioremap() alignment
2020-02-12 22:56:47 -05:00