Dmitry Monakhov 6af9fc4273 bio-integrity: Do not allocate integrity context for bio w/o data ...

[ Upstream commit 3116a23bb30272d74ea81baf5d0ee23f602dd15b ]

If bio has no data, such as ones from blkdev_issue_flush(),
then we have nothing to protect.

This patch prevent bugon like follows:

kfree_debugcheck: out of range ptr ac1fa1d106742a5ah
kernel BUG at mm/slab.c:2773!
invalid opcode: 0000 [#1] SMP
Modules linked in: bcache
CPU: 0 PID: 4428 Comm: xfs_io Tainted: G        W       4.11.0-rc4-ext4-00041-g2ef0043-dirty #43
Hardware name: Virtuozzo KVM, BIOS seabios-1.7.5-11.vz7.4 04/01/2014
task: ffff880137786440 task.stack: ffffc90000ba8000
RIP: 0010:kfree_debugcheck+0x25/0x2a
RSP: 0018:ffffc90000babde0 EFLAGS: 00010082
RAX: 0000000000000034 RBX: ac1fa1d106742a5a RCX: 0000000000000007
RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff88013f3ccb40
RBP: ffffc90000babde8 R08: 0000000000000000 R09: 0000000000000000
R10: 00000000fcb76420 R11: 00000000725172ed R12: 0000000000000282
R13: ffffffff8150e766 R14: ffff88013a145e00 R15: 0000000000000001
FS:  00007fb09384bf40(0000) GS:ffff88013f200000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fd0172f9e40 CR3: 0000000137fa9000 CR4: 00000000000006f0
Call Trace:
 kfree+0xc8/0x1b3
 bio_integrity_free+0xc3/0x16b
 bio_free+0x25/0x66
 bio_put+0x14/0x26
 blkdev_issue_flush+0x7a/0x85
 blkdev_fsync+0x35/0x42
 vfs_fsync_range+0x8e/0x9f
 vfs_fsync+0x1c/0x1e
 do_fsync+0x31/0x4a
 SyS_fsync+0x10/0x14
 entry_SYSCALL_64_fastpath+0x1f/0xc2

Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
Signed-off-by: Jens Axboe <axboe@fb.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2018-04-13 19:50:17 +02:00

..

partitions

partitions/msdos: Unable to mount UFS 44bsd partitions

2018-04-08 11:51:56 +02:00

bio-integrity.c

bio-integrity: Do not allocate integrity context for bio w/o data

2018-04-13 19:50:17 +02:00

bio.c

more bio_map_user_iov() leak fixes

2017-12-16 10:33:56 +01:00

blk-cgroup.c

blkcg: fix double free of new_blkg in blkcg_init_queue

2018-03-22 09:23:19 +01:00

blk-core.c

block: wake up all tasks blocked in get_request()

2017-12-16 10:33:55 +01:00

blk-exec.c

block: move PM request support to IDE

2015-05-05 13:40:42 -06:00

blk-flush.c

Revert "blk-flush: Queue through IO scheduler when flush not required"

2015-11-25 10:12:54 -07:00

blk-integrity.c

block: fix blk_integrity_register to use template's interval_exp if not 0

2017-05-20 14:27:00 +02:00

blk-ioc.c

mm, page_alloc: distinguish between being unable to sleep, unwilling to sleep and avoiding waking kswapd

2015-11-06 17:50:42 -08:00

blk-iopoll.c

Merge branch 'locking-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip into next

2014-06-03 12:57:53 -07:00

blk-lib.c

block: re-add discard_granularity and alignment checks

2015-10-28 09:12:58 +09:00

blk-map.c

Don't feed anything but regular iovec's to blk_rq_map_user_iov

2016-12-10 19:07:26 +01:00

blk-merge.c

block: make sure a big bio is split into at most 256 bvecs

2016-09-15 08:27:51 +02:00

blk-mq-cpu.c

blk-mq: add file comments and update copyright notices

2014-05-28 10:15:41 -06:00

blk-mq-cpumap.c

blk-mq: avoid inserting requests before establishing new mapping

2015-09-29 11:32:50 -06:00

blk-mq-sysfs.c

block: add block polling support

2015-11-07 10:40:47 -07:00

blk-mq-tag.c

mm, page_alloc: distinguish between being unable to sleep, unwilling to sleep and avoiding waking kswapd

2015-11-06 17:50:42 -08:00

blk-mq-tag.h

blk-mq: factor out a helper to iterate all tags for a request_queue

2015-10-01 10:10:57 +02:00

blk-mq.c

blk-mq: NVMe 512B/4K+T10 DIF/DIX format returns I/O error on dd with split op

2018-04-13 19:50:03 +02:00

blk-mq.h

blk-mq: mark __blk_mq_complete_request() static

2015-11-11 09:36:56 -07:00

blk-settings.c

block: Initialize max_dev_sectors to 0

2016-03-09 15:34:49 -08:00

blk-softirq.c

block: fix regression with block enabled tagging

2014-04-09 21:54:06 -06:00

blk-sysfs.c

Merge branch 'mkp-fixes' into fixes

2015-12-03 09:32:33 -08:00

blk-tag.c

block: support different tag allocation policy

2015-01-23 14:15:46 -07:00

blk-throttle.c

blk-throttle: make sure expire time isn't too big

2018-03-22 09:23:22 +01:00

blk-timeout.c

block: fix blk_abort_request for blk-mq drivers

2015-11-24 15:24:10 -07:00

blk.h

block: protect rw_page against device teardown

2015-11-19 13:47:10 -08:00

bounce.c

Merge branch 'for-linus' of git://git.kernel.dk/linux-block

2015-09-19 18:57:09 -07:00

bsg-lib.c

Revert "bsg-lib: don't free job in bsg_prepare_job"

2017-10-21 17:09:03 +02:00

bsg.c

sg_write()/bsg_write() is not fit to be called under KERNEL_DS

2017-01-09 08:07:53 +01:00

cfq-iosched.c

block: cfq_cpd_alloc() should use @gfp

2017-01-19 20:17:22 +01:00

cmdline-parser.c

block: remove unrelated header files and export symbol

2014-01-21 20:18:26 -08:00

compat_ioctl.c

block, bdi: an active gendisk always has a request_queue associated with it

2014-09-08 10:00:35 -06:00

deadline-iosched.c

block: Stop abusing csd.list for fifo_time

2014-02-24 14:46:32 -08:00

elevator.c

block: check bio_mergeable() early before merging

2015-10-21 15:00:54 -06:00

genhd.c

block: fix del_gendisk() vs blkdev_ioctl crash

2017-04-27 09:09:34 +02:00

ioctl.c

block: add an API for Persistent Reservations

2015-10-21 14:46:56 -06:00

ioprio.c

block: fix use-after-free in sys_ioprio_get()

2016-08-10 11:49:28 +02:00

Kconfig

block: Add T10 Protection Information functions

2014-09-27 09:14:59 -06:00

Kconfig.iosched

blkcg: make CONFIG_BLK_CGROUP bool

2012-03-06 21:27:21 +01:00

Makefile

block: Add T10 Protection Information functions

2014-09-27 09:14:59 -06:00

noop-iosched.c

elevator: use list_{first,prev,next}_entry

2015-11-16 15:21:48 -07:00

partition-generic.c

block: fix an error code in add_partition()

2018-04-13 19:50:10 +02:00

scsi_ioctl.c

block: allow WRITE_SAME commands with the SG_IO ioctl

2017-03-30 09:35:20 +02:00

t10-pi.c

block: Consolidate static integrity profile properties

2015-10-21 14:42:38 -06:00