linux

iv/linux

History

Jack Pham 4a71fcb8ac usb: dwc3: gadget: only unmap requests from DMA if mapped

A recent optimization was made so that a request put on the
pending_list wouldn't get mapped for DMA until just before
preparing a TRB for it. However, this poses a problem in case
the request is dequeued or the endpoint is disabled before the
mapping is done as that would lead to dwc3_gadget_giveback()
unconditionally calling usb_gadget_unmap_request_for_dev() with
an invalid request->dma handle. Depending on the platform's DMA
implementation the unmap operation could result in a panic.

Since we know a successful mapping is a prerequisite for getting
a TRB, the unmap can be conditionally called only when req->trb
is non-NULL.

Fixes: cdb55b39fab8 ("usb: dwc3: gadget: lazily map requests for DMA")
Signed-off-by: Jack Pham <jackp@codeaurora.org>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

2017-07-17 11:01:27 +03:00

core.c

usb: dwc3: core: Call dwc3_core_get_phy() before initializing phys

2017-07-17 10:58:56 +03:00

core.h

usb: dwc3: update documentation

2017-06-02 11:22:27 +03:00

debug.h

usb: dwc3: trace: decode ctrl request

2017-06-02 11:22:29 +03:00

debugfs.c

usb: dwc3: debugfs: slightly improve output of trb_ring