iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/mm
History
Hailong.Liu c55d3564ad mm/vmalloc: fix vmalloc which may return null if called with __GFP_NOFAIL 
commit 8e0545c83d672750632f46e3f9ad95c48c91a0fc upstream.

commit a421ef303008 ("mm: allow !GFP_KERNEL allocations for kvmalloc")
includes support for __GFP_NOFAIL, but it presents a conflict with commit
dd544141b9eb ("vmalloc: back off when the current task is OOM-killed").  A
possible scenario is as follows:

process-a
__vmalloc_node_range(GFP_KERNEL | __GFP_NOFAIL)
    __vmalloc_area_node()
        vm_area_alloc_pages()
		--> oom-killer send SIGKILL to process-a
        if (fatal_signal_pending(current)) break;
--> return NULL;

To fix this, do not check fatal_signal_pending() in vm_area_alloc_pages()
if __GFP_NOFAIL set.

This issue occurred during OPLUS KASAN TEST. Below is part of the log
-> oom-killer sends signal to process
[65731.222840] [ T1308] oom-kill:constraint=CONSTRAINT_NONE,nodemask=(null),cpuset=/,mems_allowed=0,global_oom,task_memcg=/apps/uid_10198,task=gs.intelligence,pid=32454,uid=10198

[65731.259685] [T32454] Call trace:
[65731.259698] [T32454]  dump_backtrace+0xf4/0x118
[65731.259734] [T32454]  show_stack+0x18/0x24
[65731.259756] [T32454]  dump_stack_lvl+0x60/0x7c
[65731.259781] [T32454]  dump_stack+0x18/0x38
[65731.259800] [T32454]  mrdump_common_die+0x250/0x39c [mrdump]
[65731.259936] [T32454]  ipanic_die+0x20/0x34 [mrdump]
[65731.260019] [T32454]  atomic_notifier_call_chain+0xb4/0xfc
[65731.260047] [T32454]  notify_die+0x114/0x198
[65731.260073] [T32454]  die+0xf4/0x5b4
[65731.260098] [T32454]  die_kernel_fault+0x80/0x98
[65731.260124] [T32454]  __do_kernel_fault+0x160/0x2a8
[65731.260146] [T32454]  do_bad_area+0x68/0x148
[65731.260174] [T32454]  do_mem_abort+0x151c/0x1b34
[65731.260204] [T32454]  el1_abort+0x3c/0x5c
[65731.260227] [T32454]  el1h_64_sync_handler+0x54/0x90
[65731.260248] [T32454]  el1h_64_sync+0x68/0x6c

[65731.260269] [T32454]  z_erofs_decompress_queue+0x7f0/0x2258
--> be->decompressed_pages = kvcalloc(be->nr_pages, sizeof(struct page *), GFP_KERNEL | __GFP_NOFAIL);
	kernel panic by NULL pointer dereference.
	erofs assume kvmalloc with __GFP_NOFAIL never return NULL.
[65731.260293] [T32454]  z_erofs_runqueue+0xf30/0x104c
[65731.260314] [T32454]  z_erofs_readahead+0x4f0/0x968
[65731.260339] [T32454]  read_pages+0x170/0xadc
[65731.260364] [T32454]  page_cache_ra_unbounded+0x874/0xf30
[65731.260388] [T32454]  page_cache_ra_order+0x24c/0x714
[65731.260411] [T32454]  filemap_fault+0xbf0/0x1a74
[65731.260437] [T32454]  __do_fault+0xd0/0x33c
[65731.260462] [T32454]  handle_mm_fault+0xf74/0x3fe0
[65731.260486] [T32454]  do_mem_abort+0x54c/0x1b34
[65731.260509] [T32454]  el0_da+0x44/0x94
[65731.260531] [T32454]  el0t_64_sync_handler+0x98/0xb4
[65731.260553] [T32454]  el0t_64_sync+0x198/0x19c

Link: https://lkml.kernel.org/r/20240510100131.1865-1-hailong.liu@oppo.com
Fixes: 9376130c390a ("mm/vmalloc: add support for __GFP_NOFAIL")
Signed-off-by: Hailong.Liu <hailong.liu@oppo.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Suggested-by: Barry Song <21cnbao@gmail.com>
Reported-by: Oven <liyangouwen1@oppo.com>
Reviewed-by: Barry Song <baohua@kernel.org>
Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
Cc: Chao Yu <chao@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Gao Xiang <xiang@kernel.org>
Cc: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-06-16 13:47:42 +02:00
..
damon
kthread: add kthread_stop_put
2024-06-12 11:12:52 +02:00
kasan
kasan/test: avoid gcc warning for intentional overflow
2024-04-03 15:28:20 +02:00
kfence
LoongArch changes for v6.6
2023-09-08 12:16:52 -07:00
kmsan
kmsan: do not wipe out origin when doing partial unpoisoning
2024-06-16 13:47:41 +02:00
backing-dev.c
blk-wbt: Fix detection of dirty-throttled tasks
2024-02-23 09:25:16 +01:00
balloon_compaction.c
…
bootmem_info.c
…
cma_debug.c
…
cma_sysfs.c
mm: cma: make kobj_type structure constant
2023-03-28 16:20:06 -07:00
cma.c
mm/cma: drop incorrect alignment check in cma_init_reserved_mem
2024-06-16 13:47:42 +02:00
cma.h
…
compaction.c
mm, treewide: introduce NR_PAGE_ORDERS
2024-05-02 16:32:41 +02:00
debug_page_alloc.c
mm: page_alloc: split out DEBUG_PAGEALLOC
2023-06-09 16:25:23 -07:00
debug_page_ref.c
…
debug_vm_pgtable.c
mm/debug_vm_pgtable: fix BUG_ON with pud advanced test
2024-03-06 14:48:41 +00:00
debug.c
mm: update validate_mm() to use vma iterator
2023-06-09 16:25:31 -07:00
dmapool_test.c
dmapool: add alloc/free performance test
2023-04-05 19:42:38 -07:00
dmapool.c
dmapool: create/destroy cleanup
2023-06-09 16:25:17 -07:00
early_ioremap.c
mm/early_ioremap.c: improve the execution efficiency of early_ioremap_setup()
2023-06-09 16:25:56 -07:00
fadvise.c
mm: remove unnecessary pagevec includes
2023-06-23 16:59:31 -07:00
fail_page_alloc.c
mm: page_alloc: split out FAIL_PAGE_ALLOC
2023-06-09 16:25:23 -07:00
failslab.c
…
filemap.c
mm: cachestat: fix two shmem bugs
2024-04-03 15:28:55 +02:00
folio-compat.c
filemap: Add fgf_t typedef
2023-07-24 18:04:30 -04:00
gup_test.c
Merge mm-hotfixes-stable into mm-stable to pick up depended-upon changes.
2023-06-23 16:58:19 -07:00
gup_test.h
…
gup.c
mm/madvise: make MADV_POPULATE_(READ|WRITE) handle VM_FAULT_RETRY properly
2024-05-02 16:32:40 +02:00
highmem.c
mm: ptep_get() conversion
2023-06-19 16:19:25 -07:00
hmm.c
mm: enable page walking API to lock vmas during the walk
2023-08-21 13:07:20 -07:00
huge_memory.c
mm: fix race between __split_huge_pmd_locked() and GUP-fast
2024-06-16 13:47:40 +02:00
hugetlb_cgroup.c
mm/hugetlb: increase use of folios in alloc_huge_page()
2023-02-13 15:54:27 -08:00
hugetlb_vmemmap.c
mm: hugetlb_vmemmap: fix a race between vmemmap pmd split
2023-08-18 10:12:14 -07:00
hugetlb_vmemmap.h
…
hugetlb.c
mm/hugetlb: pass correct order_per_bit to cma_declare_contiguous_nid
2024-06-16 13:47:42 +02:00
hwpoison-inject.c
…
init-mm.c
mm: move dummy_vm_ops out of a header
2023-08-21 13:37:46 -07:00
internal.h
mm/madvise: make MADV_POPULATE_(READ|WRITE) handle VM_FAULT_RETRY properly
2024-05-02 16:32:40 +02:00
interval_tree.c
…
io-mapping.c
…
ioremap.c
mm: ioremap: remove unneeded ioremap_allowed and iounmap_allowed
2023-08-18 10:12:36 -07:00
Kconfig
- Some swap cleanups from Ma Wupeng ("fix WARN_ON in add_to_avail_list")
2023-08-29 14:25:26 -07:00
Kconfig.debug
mm: page_table_check: Make it dependent on EXCLUSIVE_SYSTEM_RAM
2023-05-29 16:14:28 +01:00
khugepaged.c
- Some swap cleanups from Ma Wupeng ("fix WARN_ON in add_to_avail_list")
2023-08-29 14:25:26 -07:00
kmemleak.c
mm/kmemleak: move up cond_resched() call in page scanning loop
2023-09-02 15:17:34 -07:00
ksm.c
mm/ksm: fix ksm_zero_pages accounting
2024-06-16 13:47:41 +02:00
list_lru.c
…
maccess.c
mm: Fix copy_from_user_nofault().
2023-04-12 17:36:23 -07:00
madvise.c
mm/madvise: make MADV_POPULATE_(READ|WRITE) handle VM_FAULT_RETRY properly
2024-05-02 16:32:40 +02:00
Makefile
- Some swap cleanups from Ma Wupeng ("fix WARN_ON in add_to_avail_list")
2023-08-29 14:25:26 -07:00
mapping_dirty_helpers.c
mm: fix clean_record_shared_mapping_range kernel-doc
2023-08-24 16:20:30 -07:00
memblock.c
x86/numa: Fix the address overlap check in numa_fill_memblks()
2024-03-01 13:35:06 +01:00
memcontrol.c
mm: memcontrol: clarify swapaccount=0 deprecation warning
2024-03-01 13:35:00 +01:00
memfd.c
revert "memfd: improve userspace warnings for missing exec-related flags".
2023-09-05 11:11:52 -07:00
memory_hotplug.c
mm/memory_hotplug: fix memmap_on_memory sysfs value retrieval
2024-01-20 11:51:49 +01:00
memory-failure.c
mm/memory-failure: fix deadlock when hugetlb_optimize_vmemmap is enabled
2024-04-27 17:11:42 +02:00
memory-tiers.c
memory tier: use helper macro __ATTR_RW()
2023-08-18 10:12:38 -07:00
memory.c
x86/mm/pat: fix VM_PAT handling in COW mappings
2024-04-10 16:36:03 +02:00
mempolicy.c
numa: Generalize numa_map_to_online_node()
2023-11-20 11:58:51 +01:00
mempool.c
…
memremap.c
mm/memremap.c: fix outdated comment in devm_memremap_pages
2023-02-09 16:51:46 -08:00
memtest.c
memtest: use {READ,WRITE}_ONCE in memory scanning
2024-04-03 15:28:33 +02:00
migrate_device.c
Add x86 shadow stack support
2023-08-31 12:20:12 -07:00
migrate.c
mm/vmscan: fix a bug calling wakeup_kswapd() with a wrong zone index
2024-03-15 10:48:14 -04:00
mincore.c
mm: enable page walking API to lock vmas during the walk
2023-08-21 13:07:20 -07:00
mlock.c
merge mm-hotfixes-stable into mm-stable to pick up depended-upon changes
2023-08-21 14:26:20 -07:00
mm_init.c
efi: disable mirror feature during crashkernel
2024-01-31 16:18:56 -08:00
mm_slot.h
…
mmap_lock.c
…
mmap.c
mm, mmap: fix vma_merge() case 7 with vma_ops->close
2024-04-03 15:28:40 +02:00
mmu_gather.c
mm: fix kernel-doc warning from tlb_flush_rmaps()
2023-08-24 16:20:30 -07:00
mmu_notifier.c
mmu_notifiers: rename invalidate_range notifier
2023-08-18 10:12:41 -07:00
mmzone.c
…
mprotect.c
Add x86 shadow stack support
2023-08-31 12:20:12 -07:00
mremap.c
vm: fix move_vma() memory accounting being off
2023-09-16 15:23:31 -07:00
msync.c
…
nommu.c
Add x86 shadow stack support
2023-08-31 12:20:12 -07:00
oom_kill.c
mm: remove redundant K() macro definition
2023-08-21 13:37:44 -07:00
page_alloc.c
mm, treewide: introduce NR_PAGE_ORDERS
2024-05-02 16:32:41 +02:00
page_counter.c
…
page_ext.c
mm/page_ext: move functions around for minor cleanups to page_ext
2023-08-18 10:12:31 -07:00
page_idle.c
mm: page_idle: convert page idle to use a folio
2023-01-18 17:12:52 -08:00
page_io.c
zswap: make zswap_load() take a folio
2023-08-21 13:37:27 -07:00
page_isolation.c
mm/hugetlb: get rid of page_hstate()
2023-08-18 10:12:39 -07:00
page_owner.c
mm/page_ext: use page_ext_data helper in page_owner
2023-08-21 13:37:27 -07:00
page_poison.c
mm/page_poison: remove unused page_ext.h from page_poison
2023-08-21 13:37:30 -07:00
page_reporting.c
mm, treewide: introduce NR_PAGE_ORDERS
2024-05-02 16:32:41 +02:00
page_reporting.h
…
page_table_check.c
mm: convert page_table_check_pte_set() to page_table_check_ptes_set()
2023-08-24 16:20:18 -07:00
page_vma_mapped.c
mm: correct stale comment of function check_pte
2023-08-18 10:12:13 -07:00
page-writeback.c
blk-wbt: Fix detection of dirty-throttled tasks
2024-02-23 09:25:16 +01:00
pagewalk.c
mm/pagewalk: fix bootstopping regression from extra pte_unmap()
2023-09-02 08:39:21 -07:00
percpu-internal.h
percpu-internal/pcpu_chunk: re-layout pcpu_chunk structure to reduce false sharing
2023-06-19 16:19:29 -07:00
percpu-km.c
…
percpu-stats.c
…
percpu-vm.c
…
percpu.c
mm: Introduce flush_cache_vmap_early()
2024-02-16 19:10:52 +01:00
pgalloc-track.h
…
pgtable-generic.c
mm: fix race between __split_huge_pmd_locked() and GUP-fast
2024-06-16 13:47:40 +02:00
process_vm_access.c
mm/gup: remove unused vmas parameter from pin_user_pages_remote()
2023-06-09 16:25:25 -07:00
ptdump.c
mm: ptdump should use ptep_get_lockless()
2023-06-19 16:19:24 -07:00
readahead.c
mm: use memalloc_nofs_save() in page_cache_ra_order()
2024-05-17 12:02:36 +02:00
rmap.c
mm: hugetlb: add huge page size param to set_huge_pte_at()
2023-09-29 17:20:47 -07:00
rodata_test.c
…
secretmem.c
mm/secretmem: use a folio in secretmem_fault()
2023-08-21 13:38:02 -07:00
shmem_quota.c
tmpfs: fix race on handling dquot rbtree
2024-04-03 15:28:54 +02:00
shmem.c
mm/shmem: inline shmem_is_huge() for disabled transparent hugepages
2024-04-27 17:11:42 +02:00
show_mem.c
mm, treewide: introduce NR_PAGE_ORDERS
2024-05-02 16:32:41 +02:00
shrinker_debug.c
Revert "mm: shrinkers: make count and scan in shrinker debugfs lockless"
2023-06-19 13:19:34 -07:00
shuffle.c
…
shuffle.h
mm, treewide: redefine MAX_ORDER sanely
2023-04-05 19:42:46 -07:00
slab_common.c
mm: slab: Do not create kmalloc caches smaller than arch_slab_minalign()
2023-10-11 15:24:49 +02:00
slab.c
Randomized slab caches for kmalloc()
2023-07-18 10:07:47 +02:00
slab.h
Randomized slab caches for kmalloc()
2023-07-18 10:07:47 +02:00
slub.c
mm/slub: remove freelist_dereference()
2023-07-14 09:57:21 +02:00
sparse-vmemmap.c
mm/vmemmap: allow architectures to override how vmemmap optimization works
2023-08-18 10:12:53 -07:00
sparse.c
mm/sparsemem: fix race in accessing memory_section->usage
2024-01-31 16:18:56 -08:00
swap_cgroup.c
…
swap_slots.c
…
swap_state.c
mm/swap: inline folio_set_swap_entry() and folio_swap_entry()
2023-08-24 16:20:28 -07:00
swap.c
mm: remove references to pagevec
2023-06-23 16:59:30 -07:00
swap.h
mm/swap: fix race when skipping swapcache
2024-03-01 13:35:00 +01:00
swapfile.c
mm: swap: fix race between free_swap_and_cache() and swapoff()
2024-04-03 15:28:27 +02:00
truncate.c
- Some swap cleanups from Ma Wupeng ("fix WARN_ON in add_to_avail_list")
2023-08-29 14:25:26 -07:00
usercopy.c
mm: Fix copy_from_user_nofault().
2023-04-12 17:36:23 -07:00
userfaultfd.c
mm/userfaultfd: Do not place zeropages when zeropages are disallowed
2024-06-12 11:11:33 +02:00
util.c
parisc: fix mmap_base calculation when stack grows upwards
2023-11-28 17:20:08 +00:00
vmalloc.c
mm/vmalloc: fix vmalloc which may return null if called with __GFP_NOFAIL
2024-06-16 13:47:42 +02:00
vmpressure.c
net-memcg: Fix scope of sockmem pressure indicators
2023-08-16 12:21:32 +01:00
vmscan.c
mm, vmscan: prevent infinite loop for costly GFP_NOIO | __GFP_RETRY_MAYFAIL allocations
2024-04-03 15:28:44 +02:00
vmstat.c
mm, treewide: introduce NR_PAGE_ORDERS
2024-05-02 16:32:41 +02:00
workingset.c
mm: ratelimit stat flush from workingset shrinker
2024-06-16 13:47:31 +02:00
z3fold.c
mm/z3fold: remove obsolete comment for struct z3fold_pool
2023-08-21 13:37:51 -07:00
zbud.c
mm: zswap: remove shrink from zpool interface
2023-06-19 16:19:27 -07:00
zpool.c
mm: zswap: remove shrink from zpool interface
2023-06-19 16:19:27 -07:00
zsmalloc.c
merge mm-hotfixes-stable into mm-stable to pick up depended-upon changes
2023-08-21 14:26:20 -07:00
zswap.c
mm: zswap: fix missing folio cleanup in writeback race path
2024-03-01 13:35:10 +01:00