iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/sched
History
Eric Dumazet dfd2f0eb23 net/sched: flower: fix fl_change() error recovery path 
The two "goto errout;" paths in fl_change() became wrong
after cited commit.

Indeed we only must not call __fl_put() until the net pointer
has been set in tcf_exts_init_ex()

This is a minimal fix. We might in the future validate TCA_FLOWER_FLAGS
before we allocate @fnew.

BUG: KASAN: null-ptr-deref in instrument_atomic_read include/linux/instrumented.h:72 [inline]
BUG: KASAN: null-ptr-deref in atomic_read include/linux/atomic/atomic-instrumented.h:27 [inline]
BUG: KASAN: null-ptr-deref in refcount_read include/linux/refcount.h:147 [inline]
BUG: KASAN: null-ptr-deref in __refcount_add_not_zero include/linux/refcount.h:152 [inline]
BUG: KASAN: null-ptr-deref in __refcount_inc_not_zero include/linux/refcount.h:227 [inline]
BUG: KASAN: null-ptr-deref in refcount_inc_not_zero include/linux/refcount.h:245 [inline]
BUG: KASAN: null-ptr-deref in maybe_get_net include/net/net_namespace.h:269 [inline]
BUG: KASAN: null-ptr-deref in tcf_exts_get_net include/net/pkt_cls.h:260 [inline]
BUG: KASAN: null-ptr-deref in __fl_put net/sched/cls_flower.c:513 [inline]
BUG: KASAN: null-ptr-deref in __fl_put+0x13e/0x3b0 net/sched/cls_flower.c:508
Read of size 4 at addr 000000000000014c by task syz-executor548/5082

CPU: 0 PID: 5082 Comm: syz-executor548 Not tainted 6.2.0-syzkaller-05251-g5b7c4cabbb65 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/21/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106
print_report mm/kasan/report.c:420 [inline]
kasan_report+0xec/0x130 mm/kasan/report.c:517
check_region_inline mm/kasan/generic.c:183 [inline]
kasan_check_range+0x141/0x190 mm/kasan/generic.c:189
instrument_atomic_read include/linux/instrumented.h:72 [inline]
atomic_read include/linux/atomic/atomic-instrumented.h:27 [inline]
refcount_read include/linux/refcount.h:147 [inline]
__refcount_add_not_zero include/linux/refcount.h:152 [inline]
__refcount_inc_not_zero include/linux/refcount.h:227 [inline]
refcount_inc_not_zero include/linux/refcount.h:245 [inline]
maybe_get_net include/net/net_namespace.h:269 [inline]
tcf_exts_get_net include/net/pkt_cls.h:260 [inline]
__fl_put net/sched/cls_flower.c:513 [inline]
__fl_put+0x13e/0x3b0 net/sched/cls_flower.c:508
fl_change+0x101b/0x4ab0 net/sched/cls_flower.c:2341
tc_new_tfilter+0x97c/0x2290 net/sched/cls_api.c:2310
rtnetlink_rcv_msg+0x996/0xd50 net/core/rtnetlink.c:6165
netlink_rcv_skb+0x165/0x440 net/netlink/af_netlink.c:2574
netlink_unicast_kernel net/netlink/af_netlink.c:1339 [inline]
netlink_unicast+0x547/0x7f0 net/netlink/af_netlink.c:1365
netlink_sendmsg+0x925/0xe30 net/netlink/af_netlink.c:1942
sock_sendmsg_nosec net/socket.c:722 [inline]
sock_sendmsg+0xde/0x190 net/socket.c:745
____sys_sendmsg+0x334/0x900 net/socket.c:2504
___sys_sendmsg+0x110/0x1b0 net/socket.c:2558
__sys_sendmmsg+0x18f/0x460 net/socket.c:2644
__do_sys_sendmmsg net/socket.c:2673 [inline]
__se_sys_sendmmsg net/socket.c:2670 [inline]
__x64_sys_sendmmsg+0x9d/0x100 net/socket.c:2670

Fixes: 08a0063df3ae ("net/sched: flower: Move filter handle initialization earlier")
Reported-by: syzbot+baabf3efa7c1e57d28b2@syzkaller.appspotmail.com
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Paul Blakey <paulb@nvidia.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2023-03-01 08:49:54 +00:00
..
act_api.c
net/sched: act_api: move TCA_EXT_WARN_MSG to the correct hierarchy
2023-02-27 12:16:34 +00:00
act_bpf.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_connmark.c
net/sched: act_connmark: handle errno on tcf_idr_check_alloc
2023-03-01 08:19:09 +00:00
act_csum.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_ct.c
net: extract nf_ct_handle_fragments to nf_conntrack_ovs
2023-02-10 16:23:03 -08:00
act_ctinfo.c
net/sched: act_ctinfo: use percpu stats
2023-02-13 20:09:01 -08:00
act_gact.c
Networking changes for 6.2.
2022-12-13 15:47:48 -08:00
act_gate.c
net/sched: act_gate: use percpu stats
2023-02-16 10:39:28 +01:00
act_ife.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_ipt.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_meta_mark.c
…
act_meta_skbprio.c
…
act_meta_skbtcindex.c
…
act_mirred.c
act_mirred: use the backlog for nested calls to mirred ingress
2023-01-24 10:30:54 +01:00
act_mpls.c
net/sched: act_mpls: fix action bind logic
2023-02-26 18:27:45 +00:00
act_nat.c
net/sched: act_nat: transition to percpu stats and rcu
2023-02-16 10:39:28 +01:00
act_pedit.c
net/sched: act_pedit: fix action bind logic
2023-02-26 18:27:45 +00:00
act_police.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_sample.c
net/sched: act_sample: fix action bind logic
2023-02-26 18:27:45 +00:00
act_simple.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_skbedit.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_skbmod.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_tunnel_key.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_vlan.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
cls_api.c
net/sched: cls_api: Move call to tcf_exts_miss_cookie_base_destroy()
2023-02-26 14:51:25 +00:00
cls_basic.c
net/sched: avoid indirect classify functions on retpoline kernels
2022-12-09 09:18:07 +00:00
cls_bpf.c
net/sched: avoid indirect classify functions on retpoline kernels
2022-12-09 09:18:07 +00:00
cls_cgroup.c
net/sched: avoid indirect classify functions on retpoline kernels
2022-12-09 09:18:07 +00:00
cls_flow.c
treewide: Convert del_timer*() to timer_shutdown*()
2022-12-25 13:38:09 -08:00
cls_flower.c
net/sched: flower: fix fl_change() error recovery path
2023-03-01 08:49:54 +00:00
cls_fw.c
net/sched: avoid indirect classify functions on retpoline kernels
2022-12-09 09:18:07 +00:00
cls_matchall.c
net/sched: support per action hw stats
2023-02-14 11:00:01 +01:00
cls_route.c
net/sched: avoid indirect classify functions on retpoline kernels
2022-12-09 09:18:07 +00:00
cls_u32.c
net/sched: avoid indirect classify functions on retpoline kernels
2022-12-09 09:18:07 +00:00
em_canid.c
net: sched: kerneldoc fixes
2020-07-13 17:20:40 -07:00
em_cmp.c
net: sched: fix misspellings using misspell-fixer tool
2020-11-10 17:00:28 -08:00
em_ipset.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-03 14:34:53 -07:00
em_ipt.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-03 14:34:53 -07:00
em_meta.c
net_sched: em_meta: add READ_ONCE() in var_sk_bound_if()
2022-05-16 10:31:06 +01:00
em_nbyte.c
net: sched: Return the correct errno code
2021-02-06 11:15:28 -08:00
em_text.c
…
em_u32.c
…
ematch.c
net_sched: reject TCF_EM_SIMPLE case for complex ematch module
2022-12-19 09:43:18 +00:00
Kconfig
net/sched: Retire rsvp classifier
2023-02-16 09:27:07 +01:00
Makefile
net/sched: Retire rsvp classifier
2023-02-16 09:27:07 +01:00
sch_api.c
net/sched: fix error recovery in qdisc_create()
2023-02-13 09:51:59 +00:00
sch_blackhole.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_cake.c
net: sched: use skb_ip_totlen and iph_totlen
2023-02-01 20:54:27 -08:00
sch_cbs.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_choke.c
treewide: use get_random_u32_below() instead of deprecated function
2022-11-18 02:15:15 +01:00
sch_codel.c
net: sched: remove redundant NULL check in change hook function
2022-09-01 08:06:45 +02:00
sch_drr.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_etf.c
net: sched: etf: remove true check in etf_enable_offload()
2022-09-01 20:08:32 -07:00
sch_ets.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_fifo.c
net_sched: fix NULL deref in fifo_set_limit()
2021-10-01 14:59:10 -07:00
sch_fq_codel.c
Revert "net: sched: fq_codel: remove redundant resource cleanup in fq_codel_init()"
2022-10-19 13:47:09 +01:00
sch_fq_pie.c
net: sched: remove redundant NULL check in change hook function
2022-09-01 08:06:45 +02:00
sch_fq.c
net: sched: remove redundant NULL check in change hook function
2022-09-01 08:06:45 +02:00
sch_frag.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next
2021-12-31 14:35:40 +00:00
sch_generic.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2022-09-01 12:58:02 -07:00
sch_gred.c
net: sched: gred: prevent races when adding offloads to stats
2023-01-18 20:28:25 -08:00
sch_hfsc.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_hhf.c
net: sched: remove redundant NULL check in change hook function
2022-09-01 08:06:45 +02:00
sch_htb.c
net: sched: sch: Fix off by one in htb_activate_prios()
2023-02-07 23:38:53 -08:00
sch_ingress.c
…
sch_mq.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_mqprio_lib.c
net/sched: refactor mqprio qopt reconstruction to a library function
2023-02-06 10:06:44 +00:00
sch_mqprio_lib.h
net/sched: refactor mqprio qopt reconstruction to a library function
2023-02-06 10:06:44 +00:00
sch_mqprio.c
net/sched: refactor mqprio qopt reconstruction to a library function
2023-02-06 10:06:44 +00:00
sch_multiq.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_netem.c
treewide: use get_random_u32_below() instead of deprecated function
2022-11-18 02:15:15 +01:00
sch_pie.c
treewide: use get_random_bytes() when possible
2022-10-11 17:42:58 -06:00
sch_plug.c
net: sched: remove redundant NULL check in change hook function
2022-09-01 08:06:45 +02:00
sch_prio.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_qfq.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_red.c
net: sched: Fix use after free in red_enqueue()
2022-10-31 11:55:39 +00:00
sch_sfb.c
Networking fixes for 6.1-rc2, including fixes from netfilter
2022-10-20 17:24:59 -07:00
sch_sfq.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_skbprio.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_taprio.c
net/sched: taprio: dynamic max_sdu larger than the max_mtu is unlimited
2023-02-20 08:46:57 +01:00
sch_tbf.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_teql.c
net: sched: delete duplicate cleanup of backlog and qlen
2022-08-25 15:10:17 +02:00