Stefano Brivio 8399a6930d vxlan: Don't assume linear buffers in error handler
In commit c3a43b9fec8a ("vxlan: ICMP error lookup handler") I wrongly
assumed buffers from icmp_socket_deliver() would be linear. This is not
the case: icmp_socket_deliver() only guarantees we have 8 bytes of linear
data.

Eric fixed this same issue for fou and fou6 in commits 26fc181e6cac
("fou, fou6: do not assume linear skbs") and 5355ed6388e2 ("fou, fou6:
avoid uninit-value in gue_err() and gue6_err()").

Use pskb_may_pull() instead of checking skb->len, and take into account
the fact we later access the VXLAN header with udp_hdr(), so we also
need to sum skb_transport_header() here.

Reported-by: Guillaume Nault <gnault@redhat.com>
Fixes: c3a43b9fec8a ("vxlan: ICMP error lookup handler")
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-06-11 12:07:33 -07:00
..
2019-05-31 10:38:35 -07:00
2019-06-02 09:27:44 -07:00
2019-05-31 08:34:32 -07:00
2019-05-25 10:11:23 -07:00
2019-05-31 08:34:32 -07:00
2019-05-31 08:34:32 -07:00
2019-05-31 08:34:32 -07:00
2019-06-07 09:25:27 -07:00
2019-05-31 08:34:32 -07:00
2019-06-02 10:14:25 -07:00
2019-05-31 08:34:32 -07:00
2019-05-25 10:11:23 -07:00
2019-05-24 16:02:14 -07:00
2019-06-02 09:26:34 -07:00
2019-05-27 11:08:23 -04:00
2019-05-31 08:34:32 -07:00
2019-05-31 10:53:34 -07:00