iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net
History
David Ahern 83daab0625 l3mdev: l3mdev_master_upper_ifindex_by_index_rcu should be using netdev_master_upper_dev_get_rcu 
Next patch uses l3mdev_master_upper_ifindex_by_index_rcu which throws
a splat with debug kernels:

[13783.087570] ------------[ cut here ]------------
[13783.093974] RTNL: assertion failed at net/core/dev.c (6702)
[13783.100761] WARNING: CPU: 3 PID: 51132 at net/core/dev.c:6702 netdev_master_upper_dev_get+0x16a/0x1a0

[13783.184226] CPU: 3 PID: 51132 Comm: kworker/3:3 Not tainted 5.17.0-custom-100090-g6f963aafb1cc #682
[13783.194788] Hardware name: Mellanox Technologies Ltd. MSN2010/SA002610, BIOS 5.6.5 08/24/2017
[13783.204755] Workqueue: mld mld_ifc_work [ipv6]
[13783.210338] RIP: 0010:netdev_master_upper_dev_get+0x16a/0x1a0
[13783.217209] Code: 0f 85 e3 fe ff ff e8 65 ac ec fe ba 2e 1a 00 00 48 c7 c6 60 6f 38 83 48 c7 c7 c0 70 38 83 c6 05 5e b5 d7 01 01 e8 c6 29 52 00 <0f> 0b e9 b8 fe ff ff e8 5a 6c 35 ff e9 1c ff ff ff 48 89 ef e8 7d
[13783.238659] RSP: 0018:ffffc9000b37f5a8 EFLAGS: 00010286
[13783.244995] RAX: 0000000000000000 RBX: ffff88812ee5c000 RCX: 0000000000000000
[13783.253379] RDX: ffff88811ce09d40 RSI: ffffffff812d0fcd RDI: fffff5200166fea7
[13783.261769] RBP: 0000000000000000 R08: 0000000000000001 R09: ffff8882375f4287
[13783.270138] R10: ffffed1046ebe850 R11: 0000000000000001 R12: dffffc0000000000
[13783.278510] R13: 0000000000000275 R14: ffffc9000b37f688 R15: ffff8881273b4af8
[13783.286870] FS:  0000000000000000(0000) GS:ffff888237400000(0000) knlGS:0000000000000000
[13783.296352] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[13783.303177] CR2: 00007ff25fc9b2e8 CR3: 0000000174d23000 CR4: 00000000001006e0
[13783.311546] Call Trace:
[13783.314660]  <TASK>
[13783.317553]  l3mdev_master_upper_ifindex_by_index_rcu+0x43/0xe0
...

Change l3mdev_master_upper_ifindex_by_index_rcu to use
netdev_master_upper_dev_get_rcu.

Fixes: 6a6d6681ac1a ("l3mdev: add function to retreive upper master")
Signed-off-by: Ido Schimmel <idosch@idosch.org>
Signed-off-by: David Ahern <dsahern@kernel.org>
Cc: Alexis Bauvin <abauvin@scaleway.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2022-04-15 14:27:24 -07:00
..
6lowpan
net: don't include ndisc.h from ipv6.h
2022-02-04 14:15:11 -08:00
9p
xen/grant-table: remove readonly parameter from functions
2022-03-15 20:34:40 -05:00
802
net: 802: Use memset_startat() to clear struct fields
2021-11-19 11:23:23 +00:00
8021q
vlan: use correct format characters
2022-03-17 16:34:49 -07:00
appletalk
…
atm
proc: remove PDE_DATA() completely
2022-01-22 08:33:37 +02:00
ax25
ax25: Fix UAF bugs in ax25 timers
2022-03-29 10:24:34 +02:00
batman-adv
batman-adv: Use netif_rx().
2022-03-07 11:40:41 +00:00
bluetooth
Bluetooth: call hci_le_conn_failed with hdev lock in hci_le_conn_failed
2022-03-18 17:12:08 +01:00
bpf
bpf, test_run: Fix packet size check for live packet mode
2022-03-11 22:01:26 +01:00
bpfilter
uaccess: remove CONFIG_SET_FS
2022-02-25 09:36:06 +01:00
bridge
net: bridge: mst: Restrict info size queries to bridge ports
2022-03-23 10:32:44 -07:00
caif
net: caif: Use netif_rx().
2022-03-04 12:02:19 +00:00
can
can: isotp: restore accidentally removed MSG_PEEK feature
2022-03-31 09:46:58 +02:00
ceph
libceph: drop else branches in prepare_read_data{,_cont}
2022-03-01 18:26:36 +01:00
core
rtnetlink: Fix handling of disabled L3 stats in RTM_GETSTATS replies
2022-04-14 09:01:26 +02:00
dcb
net: dcb: disable softirqs in dcbnl_flush_dev()
2022-03-03 08:01:55 -08:00
dccp
dccp: remove max48()
2022-01-27 13:53:27 +00:00
decnet
net: decnet: use time_is_before_jiffies() instead of open coding it
2022-02-28 13:21:32 +00:00
dns_resolver
…
dsa
Revert "net: dsa: setup master before ports"
2022-04-13 12:38:06 +01:00
ethernet
gro: remove rcu_read_lock/rcu_read_unlock from gro_complete handlers
2021-11-24 17:21:42 -08:00
ethtool
ethtool: add support to set/get completion queue event size
2022-02-23 20:33:05 -08:00
hsr
net: add per-cpu storage and net->core_stats
2022-03-11 23:17:24 -08:00
ieee802154
net: ipv6: Handle delivery_time in ipv6 defrag
2022-03-03 14:38:48 +00:00
ife
…
ipv4
esp: limit skb_page_frag_refill use to a single page
2022-04-13 10:16:11 +02:00
ipv6
ip6_gre: Fix skb_under_panic in __gre6_xmit()
2022-04-15 11:48:34 +01:00
iucv
s390/iucv: sort out physical vs virtual pointers usage
2022-02-22 16:09:13 -08:00
kcm
net: Don't include filter.h from net/sock.h
2021-12-29 08:48:14 -08:00
key
af_key: add __GFP_ZERO flag for compose_sadb_supported in function pfkey_register
2022-03-10 07:39:47 +01:00
l2tp
l2tp: add netns refcount tracker to l2tp_dfs_seq_data
2021-12-10 06:38:27 -08:00
l3mdev
l3mdev: l3mdev_master_upper_ifindex_by_index_rcu should be using netdev_master_upper_dev_get_rcu
2022-04-15 14:27:24 -07:00
lapb
…
llc
llc: only change llc->dev when bind() succeeds
2022-03-25 16:55:41 -07:00
mac80211
mac80211: fix ht_capa printout in debugfs
2022-04-11 11:57:27 +02:00
mac802154
…
mctp
mctp: Use output netdev to allocate skb headroom
2022-04-01 12:04:15 +01:00
mpls
net: mpls: Fix GCC 12 warning
2022-02-10 15:29:39 +00:00
mptcp
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2022-03-23 10:53:49 -07:00
ncsi
all: replace find_next{,_zero}_bit with find_first{,_zero}_bit where appropriate
2022-01-15 08:47:31 -08:00
netfilter
netfilter: nf_tables: nft_parse_register can return a negative value
2022-04-12 11:36:37 +02:00
netlabel
netlabel: fix out-of-bounds memory accesses
2022-03-21 10:59:11 +00:00
netlink
af_netlink: Fix shift out of bounds in group mask calculation
2022-03-18 21:47:14 -07:00
netrom
netrom: fix api breakage in nr_setsockopt()
2022-01-07 14:11:05 +00:00
nfc
nfc: nci: add flush_workqueue to prevent uaf
2022-04-13 14:44:44 +01:00
nsh
…
openvswitch
openvswitch: fix OOB access in reserve_sfa_size()
2022-04-15 11:50:02 +01:00
packet
net/packet: fix packet_sock xmit return value checking
2022-04-15 11:17:30 +01:00
phonet
phonet: Use netif_rx().
2022-03-07 11:40:41 +00:00
psample
…
qrtr
bus: mhi: core: Add an API for auto queueing buffers for DL channel
2021-12-17 17:17:14 +01:00
rds
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2021-12-16 16:13:19 -08:00
rfkill
rfkill: make new event layout opt-in
2022-03-18 13:09:17 +02:00
rose
net: Don't include filter.h from net/sock.h
2021-12-29 08:48:14 -08:00
rxrpc
rxrpc: Restore removed timer deletion
2022-04-15 10:54:49 +01:00
sched
net/sched: cls_u32: fix possible leak in u32_init_knode()
2022-04-15 14:26:11 -07:00
sctp
sctp: Initialize daddr on peeled off socket
2022-04-11 20:33:10 -07:00
smc
net/smc: Fix sock leak when release after smc_shutdown()
2022-04-15 11:14:38 +01:00
strparser
bpf: sockmap, strparser, and tls are reusing qdisc_skb_cb and colliding
2021-11-09 01:05:28 +01:00
sunrpc
NFSD bug fixes for 5.18-rc:
2022-04-12 14:23:19 -10:00
switchdev
net: switchdev: remove lag_mod_cb from switchdev_handle_fdb_event_to_device
2022-02-24 21:31:43 -08:00
tipc
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2022-03-23 10:53:49 -07:00
tls
net/tls: fix slab-out-of-bounds bug in decrypt_internal
2022-04-01 11:53:35 +01:00
unix
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2022-03-23 10:53:49 -07:00
vmw_vsock
vsock/virtio: enable VQs early on probe
2022-03-24 18:36:36 -07:00
wireless
cfg80211: hold bss_lock while updating nontrans_list
2022-04-11 11:55:36 +02:00
x25
net/x25: Fix null-ptr-deref caused by x25_disconnect
2022-03-26 11:48:16 -07:00
xdp
xsk: Do not write NULL in SW ring at allocation failure
2022-03-28 19:56:28 -07:00
xfrm
xfrm: Pass flowi_oif or l3mdev as oif to xfrm_dst_lookup
2022-04-04 13:32:56 +02:00
compat.c
…
devres.c
…
Kconfig
page_pool: Add allocation stats
2022-03-03 09:55:28 +00:00
Kconfig.debug
net: add networking namespace refcount tracker
2021-12-10 06:38:26 -08:00
Makefile
…
socket.c
fs: allocate inode by using alloc_inode_sb()
2022-03-22 15:57:03 -07:00
sysctl_net.c
sections: move and rename core_kernel_data() to is_kernel_core_data()
2021-11-09 10:02:50 -08:00