Ye Bin
84a2f2ed49
ext4: init quota for 'old.inode' in 'ext4_rename' ...
commit fae381a3d79bb94aa2eb752170d47458d778b797 upstream.
Syzbot found the following issue:
ext4_parse_param: s_want_extra_isize=128
ext4_inode_info_init: s_want_extra_isize=32
ext4_rename: old.inode=ffff88823869a2c8 old.dir=ffff888238699828 new.inode=ffff88823869d7e8 new.dir=ffff888238699828
__ext4_mark_inode_dirty: inode=ffff888238699828 ea_isize=32 want_ea_size=128
__ext4_mark_inode_dirty: inode=ffff88823869a2c8 ea_isize=32 want_ea_size=128
ext4_xattr_block_set: inode=ffff88823869a2c8
------------[ cut here ]------------
WARNING: CPU: 13 PID: 2234 at fs/ext4/xattr.c:2070 ext4_xattr_block_set.cold+0x22/0x980
Modules linked in:
RIP: 0010:ext4_xattr_block_set.cold+0x22/0x980
RSP: 0018:ffff888227d3f3b0 EFLAGS: 00010202
RAX: 0000000000000001 RBX: ffff88823007a000 RCX: 0000000000000000
RDX: 0000000000000a03 RSI: 0000000000000040 RDI: ffff888230078178
RBP: 0000000000000000 R08: 000000000000002c R09: ffffed1075c7df8e
R10: ffff8883ae3efc6b R11: ffffed1075c7df8d R12: 0000000000000000
R13: ffff88823869a2c8 R14: ffff8881012e0460 R15: dffffc0000000000
FS: 00007f350ac1f740(0000) GS:ffff8883ae200000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f350a6ed6a0 CR3: 0000000237456000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
? ext4_xattr_set_entry+0x3b7/0x2320
? ext4_xattr_block_set+0x0/0x2020
? ext4_xattr_set_entry+0x0/0x2320
? ext4_xattr_check_entries+0x77/0x310
? ext4_xattr_ibody_set+0x23b/0x340
ext4_xattr_move_to_block+0x594/0x720
ext4_expand_extra_isize_ea+0x59a/0x10f0
__ext4_expand_extra_isize+0x278/0x3f0
__ext4_mark_inode_dirty.cold+0x347/0x410
ext4_rename+0xed3/0x174f
vfs_rename+0x13a7/0x2510
do_renameat2+0x55d/0x920
__x64_sys_rename+0x7d/0xb0
do_syscall_64+0x3b/0xa0
entry_SYSCALL_64_after_hwframe+0x72/0xdc
As 'ext4_rename' will modify 'old.inode' ctime and mark inode dirty,
which may trigger expand 'extra_isize' and allocate block. If inode
didn't init quota will lead to warning. To solve above issue, init
'old.inode' firstly in 'ext4_rename'.
Reported-by: syzbot+98346927678ac3059c77@syzkaller.appspotmail.com
Signed-off-by: Ye Bin <yebin10@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20221107015335.2524319-1-yebin@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-01-14 10:16:38 +01:00
2022-06-22 14:13:12 +02:00
2020-10-24 12:26:05 -07:00
2021-03-04 11:38:37 +01:00
2023-01-14 10:16:22 +01:00
2020-10-16 11:11:22 -07:00
2021-01-06 14:56:52 +01:00
2023-01-14 10:16:30 +01:00
2021-03-30 14:32:07 +02:00
2022-12-02 17:40:03 +01:00
2023-01-14 10:16:34 +01:00
2023-01-14 10:15:37 +01:00
2022-11-10 18:14:25 +01:00
2023-01-14 10:15:19 +01:00
2022-02-01 17:25:39 +01:00
2022-10-26 13:25:08 +02:00
2021-05-26 12:06:55 +02:00
2020-11-25 16:55:02 +01:00
2022-08-21 15:15:35 +02:00
2022-06-06 08:42:42 +02:00
2022-08-21 15:15:28 +02:00
2023-01-14 10:16:38 +01:00
2023-01-14 10:16:27 +01:00
2022-06-09 10:20:58 +02:00
2021-09-18 13:40:15 +02:00
2022-12-19 12:27:31 +01:00
2022-11-25 17:45:56 +01:00
2023-01-14 10:16:14 +01:00
2023-01-14 10:16:26 +01:00
2021-04-14 08:42:06 +02:00
2023-01-14 10:16:20 +01:00
2022-07-07 17:52:19 +02:00
2021-11-12 14:58:33 +01:00
2022-10-26 13:25:13 +02:00
2022-06-14 18:32:35 +02:00
2023-01-14 10:16:14 +01:00
2022-11-03 23:57:50 +09:00
2021-09-18 13:40:30 +02:00
2022-04-13 21:01:01 +02:00
2023-01-14 10:15:38 +01:00
2020-12-30 11:53:45 +01:00
2023-01-14 10:16:09 +01:00
2023-01-14 10:16:14 +01:00
2022-06-09 10:21:03 +02:00
2022-11-25 17:45:57 +01:00
2023-01-14 10:15:19 +01:00
2023-01-14 10:16:20 +01:00
2023-01-14 10:16:26 +01:00
2023-01-04 11:39:24 +01:00
2023-01-14 10:16:26 +01:00
2021-09-30 10:11:08 +02:00
2023-01-14 10:16:38 +01:00
2020-10-16 11:11:22 -07:00
2023-01-14 10:16:23 +01:00
2020-10-24 12:26:05 -07:00
2021-05-19 10:13:10 +02:00
2020-10-02 12:02:30 +02:00
2023-01-14 10:15:22 +01:00
2022-09-20 12:38:31 +02:00
2022-04-13 21:00:53 +02:00
2023-01-14 10:16:13 +01:00
2020-10-24 12:26:05 -07:00
2021-10-17 10:43:33 +02:00
2021-10-06 15:55:46 +02:00
2022-09-28 11:10:29 +02:00
2022-12-02 17:40:05 +01:00
2021-12-14 11:32:40 +01:00
2022-08-21 15:15:22 +02:00
2023-01-14 10:16:26 +01:00
2022-11-03 23:57:49 +09:00
2022-06-09 10:20:47 +02:00
2023-01-14 10:16:13 +01:00
2021-06-03 09:00:45 +02:00
2022-11-25 17:45:56 +01:00
2023-01-14 10:15:59 +01:00
2023-01-04 11:39:22 +01:00
2020-10-14 14:54:45 -07:00
2022-06-09 10:21:16 +02:00
2021-04-14 08:41:58 +02:00
2023-01-04 11:39:24 +01:00
2023-01-04 11:39:24 +01:00
2022-11-03 23:57:49 +09:00
2022-10-30 09:41:18 +01:00
2022-05-18 10:23:48 +02:00
2023-01-04 11:39:18 +01:00
2022-02-08 18:30:36 +01:00
2020-10-13 18:38:27 -07:00
2022-06-09 10:21:22 +02:00
2022-10-15 07:55:51 +02:00
2023-01-04 11:39:18 +01:00
2022-05-25 09:17:54 +02:00
2021-02-17 11:02:21 +01:00
2021-10-27 09:56:51 +02:00
2023-01-14 10:15:19 +01:00
2021-03-20 10:43:44 +01:00
2023-01-04 11:39:23 +01:00
2023-01-04 11:39:18 +01:00
2021-08-26 08:35:57 -04:00
2023-01-04 11:39:17 +01:00
2022-06-06 08:42:41 +02:00
2023-01-14 10:16:27 +01:00
2021-03-17 17:06:13 +01:00
2020-12-30 11:54:02 +01:00
2022-12-19 12:27:30 +01:00
2021-04-21 13:00:54 +02:00
2022-07-21 21:20:01 +02:00
2022-01-29 10:26:11 +01:00
2021-07-20 16:05:59 +02:00
2022-09-05 10:28:58 +02:00
2022-10-17 17:26:07 +02:00
2022-04-27 13:53:54 +02:00
2022-11-10 18:14:25 +01:00
2022-08-31 17:15:14 +02:00
2022-10-26 13:25:17 +02:00
2023-01-14 10:15:16 +01:00
84a2f2ed49