9b39b01303
If we unplug a udl device, the usb callback with deinit the mode_config struct, however userspace will still have an open file descriptor and a framebuffer on that device. When userspace closes the fd, we'll oops because it'll try and look stuff up in the object idr which we've destroyed. This punts destroying the mode objects until release time instead. Cc: stable@vger.kernel.org Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Dave Airlie <airlied@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190405031715.5959-2-airlied@gmail.com
142 lines
3.5 KiB
C
142 lines
3.5 KiB
C
/*
|
|
* Copyright (C) 2012 Red Hat
|
|
*
|
|
* This file is subject to the terms and conditions of the GNU General Public
|
|
* License v2. See the file COPYING in the main directory of this archive for
|
|
* more details.
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <drm/drmP.h>
|
|
#include <drm/drm_crtc_helper.h>
|
|
#include <drm/drm_probe_helper.h>
|
|
#include "udl_drv.h"
|
|
|
|
static int udl_usb_suspend(struct usb_interface *interface,
|
|
pm_message_t message)
|
|
{
|
|
struct drm_device *dev = usb_get_intfdata(interface);
|
|
|
|
drm_kms_helper_poll_disable(dev);
|
|
return 0;
|
|
}
|
|
|
|
static int udl_usb_resume(struct usb_interface *interface)
|
|
{
|
|
struct drm_device *dev = usb_get_intfdata(interface);
|
|
|
|
drm_kms_helper_poll_enable(dev);
|
|
udl_modeset_restore(dev);
|
|
return 0;
|
|
}
|
|
|
|
static const struct vm_operations_struct udl_gem_vm_ops = {
|
|
.fault = udl_gem_fault,
|
|
.open = drm_gem_vm_open,
|
|
.close = drm_gem_vm_close,
|
|
};
|
|
|
|
static const struct file_operations udl_driver_fops = {
|
|
.owner = THIS_MODULE,
|
|
.open = drm_open,
|
|
.mmap = udl_drm_gem_mmap,
|
|
.poll = drm_poll,
|
|
.read = drm_read,
|
|
.unlocked_ioctl = drm_ioctl,
|
|
.release = drm_release,
|
|
.compat_ioctl = drm_compat_ioctl,
|
|
.llseek = noop_llseek,
|
|
};
|
|
|
|
static struct drm_driver driver = {
|
|
.driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_PRIME,
|
|
.load = udl_driver_load,
|
|
.unload = udl_driver_unload,
|
|
.release = udl_driver_release,
|
|
|
|
/* gem hooks */
|
|
.gem_free_object_unlocked = udl_gem_free_object,
|
|
.gem_vm_ops = &udl_gem_vm_ops,
|
|
|
|
.dumb_create = udl_dumb_create,
|
|
.dumb_map_offset = udl_gem_mmap,
|
|
.fops = &udl_driver_fops,
|
|
|
|
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
|
|
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
|
|
.gem_prime_export = udl_gem_prime_export,
|
|
.gem_prime_import = udl_gem_prime_import,
|
|
|
|
.name = DRIVER_NAME,
|
|
.desc = DRIVER_DESC,
|
|
.date = DRIVER_DATE,
|
|
.major = DRIVER_MAJOR,
|
|
.minor = DRIVER_MINOR,
|
|
.patchlevel = DRIVER_PATCHLEVEL,
|
|
};
|
|
|
|
static int udl_usb_probe(struct usb_interface *interface,
|
|
const struct usb_device_id *id)
|
|
{
|
|
struct usb_device *udev = interface_to_usbdev(interface);
|
|
struct drm_device *dev;
|
|
int r;
|
|
|
|
dev = drm_dev_alloc(&driver, &interface->dev);
|
|
if (IS_ERR(dev))
|
|
return PTR_ERR(dev);
|
|
|
|
r = drm_dev_register(dev, (unsigned long)udev);
|
|
if (r)
|
|
goto err_free;
|
|
|
|
usb_set_intfdata(interface, dev);
|
|
DRM_INFO("Initialized udl on minor %d\n", dev->primary->index);
|
|
|
|
return 0;
|
|
|
|
err_free:
|
|
drm_dev_put(dev);
|
|
return r;
|
|
}
|
|
|
|
static void udl_usb_disconnect(struct usb_interface *interface)
|
|
{
|
|
struct drm_device *dev = usb_get_intfdata(interface);
|
|
|
|
drm_kms_helper_poll_disable(dev);
|
|
udl_fbdev_unplug(dev);
|
|
udl_drop_usb(dev);
|
|
drm_dev_unplug(dev);
|
|
}
|
|
|
|
/*
|
|
* There are many DisplayLink-based graphics products, all with unique PIDs.
|
|
* So we match on DisplayLink's VID + Vendor-Defined Interface Class (0xff)
|
|
* We also require a match on SubClass (0x00) and Protocol (0x00),
|
|
* which is compatible with all known USB 2.0 era graphics chips and firmware,
|
|
* but allows DisplayLink to increment those for any future incompatible chips
|
|
*/
|
|
static const struct usb_device_id id_table[] = {
|
|
{.idVendor = 0x17e9, .bInterfaceClass = 0xff,
|
|
.bInterfaceSubClass = 0x00,
|
|
.bInterfaceProtocol = 0x00,
|
|
.match_flags = USB_DEVICE_ID_MATCH_VENDOR |
|
|
USB_DEVICE_ID_MATCH_INT_CLASS |
|
|
USB_DEVICE_ID_MATCH_INT_SUBCLASS |
|
|
USB_DEVICE_ID_MATCH_INT_PROTOCOL,},
|
|
{},
|
|
};
|
|
MODULE_DEVICE_TABLE(usb, id_table);
|
|
|
|
static struct usb_driver udl_driver = {
|
|
.name = "udl",
|
|
.probe = udl_usb_probe,
|
|
.disconnect = udl_usb_disconnect,
|
|
.suspend = udl_usb_suspend,
|
|
.resume = udl_usb_resume,
|
|
.id_table = id_table,
|
|
};
|
|
module_usb_driver(udl_driver);
|
|
MODULE_LICENSE("GPL");
|