iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/nvme/target
History
zhenwei pi 85bd23f3dc nvmet: fix uninitialized work for zero kato 
When connecting a controller with a zero kato value using the following
command line

   nvme connect -t tcp -n NQN -a ADDR -s PORT --keep-alive-tmo=0

the warning below can be reproduced:

WARNING: CPU: 1 PID: 241 at kernel/workqueue.c:1627 __queue_delayed_work+0x6d/0x90
with trace:
  mod_delayed_work_on+0x59/0x90
  nvmet_update_cc+0xee/0x100 [nvmet]
  nvmet_execute_prop_set+0x72/0x80 [nvmet]
  nvmet_tcp_try_recv_pdu+0x2f7/0x770 [nvmet_tcp]
  nvmet_tcp_io_work+0x63f/0xb2d [nvmet_tcp]
  ...

This is caused by queuing up an uninitialized work.  Althrough the
keep-alive timer is disabled during allocating the controller (fixed in
0d3b6a8d213a), ka_work still has a chance to run (called by
nvmet_start_ctrl).

Fixes: 0d3b6a8d213a ("nvmet: Disable keep-alive timer when kato is cleared to 0h")
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
2020-10-22 15:27:14 +02:00
..
admin-cmd.c
nvmet: handle keep-alive timer when kato is modified by a set features cmd
2020-09-27 09:14:19 +02:00
configfs.c
nvmet: fix a memory leak
2020-08-21 17:14:27 -06:00
core.c
nvmet: fix uninitialized work for zero kato
2020-10-22 15:27:14 +02:00
discovery.c
nvmet: introduce flags member in nvmet_fabrics_ops
2020-07-08 16:16:17 +02:00
fabrics-cmd.c
nvmet: add metadata/T10-PI support
2020-05-27 07:12:40 +02:00
fc.c
nvmet-fc: fix missing check for no hostport struct
2020-09-27 09:14:19 +02:00
fcloop.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
io-cmd-bdev.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
io-cmd-file.c
nvmet: rename nvmet_check_data_len to nvmet_check_transfer_len
2020-05-27 07:12:39 +02:00
Kconfig
nvmet: introduce the passthru Kconfig option
2020-07-29 07:45:21 +02:00
loop.c
nvme-loop: don't put ctrl on nvme_init_ctrl error
2020-10-07 07:56:16 +02:00
Makefile
nvmet: add passthru code to process commands
2020-07-29 07:45:21 +02:00
nvmet.h
nvmet: handle keep-alive timer when kato is modified by a set features cmd
2020-09-27 09:14:19 +02:00
passthru.c
nvmet: add passthru ZNS support
2020-09-27 09:14:19 +02:00
rdma.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
tcp.c
nvmet-tcp: have queue io_work context run on sock incoming cpu
2020-09-27 09:14:18 +02:00
trace.c
nvmet: trace: parse Get LBA Status command in detail
2019-08-29 12:55:01 -07:00
trace.h
nvmet: add async event tracing support
2020-05-27 07:12:38 +02:00