linux

iv/linux

History

Marek Vasut 85de7fac39 i2c: mxs: Fix misuse init_completion

The init_completion() call does reinit not only the variable carrying
the flag that the completion finished, but also initialized the
waitqueue associated with the completion. On the contrary, the
INIT_COMPLETION() call only reinits the flag.

In case there was anything still stuck in the waitqueue, subsequent call
to init_completion() would be able to create possible race condition. This
patch uses the proper function and moves init_completion() into .probe() call
of the driver, to be issued only once.

Note that such scenario is impossible, since two threads can never enter the
mxs_i2c_xfer_msg(), since whole this section is protected by mutex in I2C core.
This by no means allows this issue to exit though.

Signed-off-by: Marek Vasut <marex@denx.de>
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>

2013-01-21 16:26:29 +01:00

algos

Linux 3.6-rc7

2012-10-08 12:46:32 +02:00

busses

i2c: mxs: Fix misuse init_completion

2013-01-21 16:26:29 +01:00

muxes

i2c: remove __dev* attributes from subsystem

2012-12-22 20:13:45 +01:00

i2c-boardinfo.c

i2c: Update the FSF address