Guenter Roeck 866cf12a0e hwmon: (pmbus) Don't return errors from driver remove functions
Driver remove functions have an error return value, but rarely return an error
in practice. If a driver does return an error from its remove function, the
driver won't be unloaded and is expected to stay alive.

pmbus_do_remove() is defined as returning an int, but always returns 0 (no
error). Calling code passes that return value on to high level driver
remove functions, but does not evaluate it and removes driver data even if
pmbus_do_remove() returned an error (which it in practice never does). Even if
this code could never cause a real problem, it is nevertheless conceptually
wrong.

To reduce confusion and simplify the code, change pmbus_do_remove() to be a void
function, and have PMBus client drivers always return zero in their driver
remove functions.

Reported-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
Acked-by: Jean Delvare <khali@linux-fr.org>
2011-10-24 11:09:33 -07:00
..
2011-05-25 20:43:33 +02:00
2011-05-25 20:43:33 +02:00
2009-12-14 21:17:27 +01:00
2011-03-31 11:26:23 -03:00
2009-12-14 21:17:26 +01:00
2010-10-28 20:31:50 +02:00
2010-10-28 20:31:50 +02:00
2011-01-12 21:55:13 +01:00
2009-12-14 21:17:26 +01:00
2011-01-12 21:55:11 +01:00
2009-12-14 21:17:27 +01:00
2011-08-11 10:14:18 -07:00
2011-05-25 20:43:32 +02:00
2011-03-21 17:59:36 +01:00
2009-12-14 21:17:26 +01:00
2011-07-25 21:46:11 +02:00
2009-12-14 21:17:26 +01:00
2009-12-14 21:17:27 +01:00
2009-12-14 21:17:27 +01:00
2009-12-14 21:17:26 +01:00
2011-01-18 12:22:54 -08:00
2011-07-28 00:17:35 -07:00
2011-03-14 22:39:11 -07:00
2009-12-14 21:17:26 +01:00
2011-07-25 21:46:09 +02:00
2011-07-25 21:46:09 +02:00
2011-07-26 16:49:47 -07:00
2009-12-14 21:17:26 +01:00
2009-12-14 21:17:27 +01:00
2011-03-31 11:26:23 -03:00
2010-10-28 20:31:50 +02:00
2009-12-14 21:17:26 +01:00
2009-12-14 21:17:26 +01:00
2011-03-31 11:26:23 -03:00
2011-03-31 11:26:23 -03:00