Ye Bin
86c2a2ec4b
ext4: fix reserved cluster accounting in __es_remove_extent() ...
commit 1da18e38cb97e9521e93d63034521a9649524f64 upstream.
When bigalloc is enabled, reserved cluster accounting for delayed
allocation is handled in extent_status.c. With a corrupted file
system, it's possible for this accounting to be incorrect,
dsicovered by Syzbot:
EXT4-fs error (device loop0): ext4_validate_block_bitmap:398: comm rep:
bg 0: block 5: invalid block bitmap
EXT4-fs (loop0): Delayed block allocation failed for inode 18 at logical
offset 0 with max blocks 32 with error 28
EXT4-fs (loop0): This should not happen!! Data will be lost
EXT4-fs (loop0): Total free blocks count 0
EXT4-fs (loop0): Free/Dirty block details
EXT4-fs (loop0): free_blocks=0
EXT4-fs (loop0): dirty_blocks=32
EXT4-fs (loop0): Block reservation details
EXT4-fs (loop0): i_reserved_data_blocks=2
EXT4-fs (loop0): Inode 18 (00000000845cd634):
i_reserved_data_blocks (1) not cleared!
Above issue happens as follows:
Assume:
sbi->s_cluster_ratio = 16
Step1:
Insert delay block [0, 31] -> ei->i_reserved_data_blocks=2
Step2:
ext4_writepages
mpage_map_and_submit_extent -> return failed
mpage_release_unused_pages -> to release [0, 30]
ext4_es_remove_extent -> remove lblk=0 end=30
__es_remove_extent -> len1=0 len2=31-30=1
__es_remove_extent:
...
if (len2 > 0) {
...
if (len1 > 0) {
...
} else {
es->es_lblk = end + 1;
es->es_len = len2;
...
}
if (count_reserved)
count_rsvd(inode, lblk, ...);
goto out; -> will return but didn't calculate 'reserved'
...
Step3:
ext4_destroy_inode -> trigger "i_reserved_data_blocks (1) not cleared!"
To solve above issue if 'len2>0' call 'get_rsvd()' before goto out.
Reported-by: syzbot+05a0f0ccab4a25626e38@syzkaller.appspotmail.com
Fixes: 8fcc3a580651 ("ext4: rework reserved cluster accounting when invalidating pages")
Signed-off-by: Ye Bin <yebin10@huawei.com>
Reviewed-by: Eric Whitney <enwlinux@gmail.com>
Link: https://lore.kernel.org/r/20221208033426.1832460-2-yebin@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-01-14 10:16:38 +01:00
2022-06-22 14:13:12 +02:00
2020-10-24 12:26:05 -07:00
2021-03-04 11:38:37 +01:00
2023-01-14 10:16:22 +01:00
2020-10-16 11:11:22 -07:00
2021-01-06 14:56:52 +01:00
2023-01-14 10:16:30 +01:00
2021-03-30 14:32:07 +02:00
2022-12-02 17:40:03 +01:00
2023-01-14 10:16:34 +01:00
2023-01-14 10:15:37 +01:00
2022-11-10 18:14:25 +01:00
2023-01-14 10:15:19 +01:00
2022-02-01 17:25:39 +01:00
2022-10-26 13:25:08 +02:00
2021-05-26 12:06:55 +02:00
2020-11-25 16:55:02 +01:00
2022-08-21 15:15:35 +02:00
2022-06-06 08:42:42 +02:00
2022-08-21 15:15:28 +02:00
2023-01-14 10:16:38 +01:00
2023-01-14 10:16:27 +01:00
2022-06-09 10:20:58 +02:00
2021-09-18 13:40:15 +02:00
2022-12-19 12:27:31 +01:00
2022-11-25 17:45:56 +01:00
2023-01-14 10:16:14 +01:00
2023-01-14 10:16:26 +01:00
2021-04-14 08:42:06 +02:00
2023-01-14 10:16:20 +01:00
2022-07-07 17:52:19 +02:00
2021-11-12 14:58:33 +01:00
2022-10-26 13:25:13 +02:00
2022-06-14 18:32:35 +02:00
2023-01-14 10:16:14 +01:00
2022-11-03 23:57:50 +09:00
2021-09-18 13:40:30 +02:00
2022-04-13 21:01:01 +02:00
2023-01-14 10:15:38 +01:00
2020-12-30 11:53:45 +01:00
2023-01-14 10:16:09 +01:00
2023-01-14 10:16:14 +01:00
2022-06-09 10:21:03 +02:00
2022-11-25 17:45:57 +01:00
2023-01-14 10:15:19 +01:00
2023-01-14 10:16:20 +01:00
2023-01-14 10:16:26 +01:00
2023-01-04 11:39:24 +01:00
2023-01-14 10:16:26 +01:00
2021-09-30 10:11:08 +02:00
2023-01-14 10:16:38 +01:00
2020-10-16 11:11:22 -07:00
2023-01-14 10:16:23 +01:00
2020-10-24 12:26:05 -07:00
2021-05-19 10:13:10 +02:00
2020-10-02 12:02:30 +02:00
2023-01-14 10:15:22 +01:00
2022-09-20 12:38:31 +02:00
2022-04-13 21:00:53 +02:00
2023-01-14 10:16:13 +01:00
2020-10-24 12:26:05 -07:00
2021-10-17 10:43:33 +02:00
2021-10-06 15:55:46 +02:00
2022-09-28 11:10:29 +02:00
2022-12-02 17:40:05 +01:00
2021-12-14 11:32:40 +01:00
2022-08-21 15:15:22 +02:00
2023-01-14 10:16:26 +01:00
2022-11-03 23:57:49 +09:00
2022-06-09 10:20:47 +02:00
2023-01-14 10:16:13 +01:00
2021-06-03 09:00:45 +02:00
2022-11-25 17:45:56 +01:00
2023-01-14 10:15:59 +01:00
2023-01-04 11:39:22 +01:00
2020-10-14 14:54:45 -07:00
2022-06-09 10:21:16 +02:00
2021-04-14 08:41:58 +02:00
2023-01-04 11:39:24 +01:00
2023-01-04 11:39:24 +01:00
2022-11-03 23:57:49 +09:00
2022-10-30 09:41:18 +01:00
2022-05-18 10:23:48 +02:00
2023-01-04 11:39:18 +01:00
2022-02-08 18:30:36 +01:00
2020-10-13 18:38:27 -07:00
2022-06-09 10:21:22 +02:00
2022-10-15 07:55:51 +02:00
2023-01-04 11:39:18 +01:00
2022-05-25 09:17:54 +02:00
2021-02-17 11:02:21 +01:00
2021-10-27 09:56:51 +02:00
2023-01-14 10:15:19 +01:00
2021-03-20 10:43:44 +01:00
2023-01-04 11:39:23 +01:00
2023-01-04 11:39:18 +01:00
2021-08-26 08:35:57 -04:00
2023-01-04 11:39:17 +01:00
2022-06-06 08:42:41 +02:00
2023-01-14 10:16:27 +01:00
2021-03-17 17:06:13 +01:00
2020-12-30 11:54:02 +01:00
2022-12-19 12:27:30 +01:00
2021-04-21 13:00:54 +02:00
2022-07-21 21:20:01 +02:00
2022-01-29 10:26:11 +01:00
2021-07-20 16:05:59 +02:00
2022-09-05 10:28:58 +02:00
2022-10-17 17:26:07 +02:00
2022-04-27 13:53:54 +02:00
2022-11-10 18:14:25 +01:00
2022-08-31 17:15:14 +02:00
2022-10-26 13:25:17 +02:00
2023-01-14 10:15:16 +01:00
86c2a2ec4b